#1667 Anniversaries of 30 CHV KSL ADR

[Greg Roach]

Split from: [1793229] Calendar / New Date Functions
Quote:

It is customary to show 29 February on 28 February on non-leap
Gregorian years. I have no problems with such a solution for the Gregorian
month.

Then we have the issues of the 30th day of Adar I, Cheshvan and Kislev.
See http://www.drissman.com/avi/newton/HebrewDateConvert/HDCReadMe.html
This is from our closed posting 1744312.
30 CHV, 30 KSL and 30 ADR are not automatically celebrated/observed on 29
of the month when the 30 of the month does not exist.
We should not try to force the Hebrew year to behave like the Gregorian
year, although it would be nice if we could.
* 30 CHV YYYY - if 30 CHV does not exist for the calendar or block year
show birth and any non death event on 1 KSL.
show death according to the following rule
if CHV in year YYYY+1 has 30 days, then show the date on 1 KSL (when 30
CHV does not exist in the reporting year)
if CHV in year YYYY+1 has 29 days, then show the date on 29 CHV (when 30
CHV does not exist in the reporting year)
* 30 KSL YYYY - if 30 KSL does not exist for the calendar or block year
show birth/marriage etc. on 1 TVT.
show death according to the following rule
if KSL in year YYYY+1 has 30 days, then show the date on 1 TVT (when 30
KSL does not exist in the reporting year)
if KSL in year YYYY+1 has 29 days, then show the date on 29 KSL (when 30
CHV does not exist in the reporting year)
* 30 ADR YYYY - if 30 ADR does not exist for the calendar or block year
show birth/marriage on 1 NSN.
show death on 30 SHV and on 1 NSN (if only one Adar exists on the year)
– we planned if possible to print ** next to these duplicate events

The same rules are required on the related blocks.

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: YES

SVN1719.

Meliza - this works for me for every test case (valid and invalid) I can find. Please don't be *too* harsh on me if I've missed something ;-)

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: NO

Test Dates I211 died on 30 HSV. I see it in the Upcomin Yahrzeits on 2 KSL. I do not see this event in the calendar either in Heshvan or in Kislev.

Big file I7670 died on 30 KSL 5670. I do not see her in this year's calendar.
I wanted to test this date in the blocks already now, but PGV does not allow me to change the limit to more than 30 days.

Big file I9983 died on 30 ADR 5679. I do not see this event in the calendar of 5678.

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: NO

I look at the Test Dates file.

I177 "30 ADR" prints in the monthly Adar page in the undefined box.
I138 "30 ADR 5684" birth prints in the 29 Adar box.

1. Why the different behaviour?
2. 30 ADR should show on 1 Nisan when 30 Adar does not exist in a certain year.

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: YES

<<Test Dates I211 died on 30 HSV. I see it in the Upcomin Yahrzeits on 2 KSL. I do not see this event in the calendar either in Heshvan or in Kislev.>>

I've fixed the yahrzeit special rules in SVN.

<<I177 "30 ADR" prints in the monthly Adar page in the undefined box.>>

This is because 30 ADR 0000 only has 29 days. (Or it would, if the year existed!)
TODO: CalendarDate::IsDayValid() needs to be passed a default year to be used for dates with no year.

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: YES

<<TODO: CalendarDate::IsDayValid() needs to be passed a default year to be used for dates with no year.>>

SVN2116

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: YES

<<PGV does not allow me to change the limit to more than 30 days.>>

BTW - the 30 day maximum is a gedcom config setting.

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: NO

30 day max - yes, but 30 days is the most one can fill for the GEDCOM.
I will have to wait to test the relevant blocks later this year and in future years.

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: YES

In the gedcom config, you can set this value (default 30).
Display-and-layout -> Hide-and-show -> Upcoming-events-block-day-limit

In the blocks, you can select between 1 and this limit.

At least, that's how it is supposed to work. Let me check....

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: NO

I have I7670 who died on 30 KSL 5670.
I do not see the date in the Upcomming Events block or in the Yahrzeiten block (the date does not exist in 2007 and the event should be shown on another day).

I do neither see the event in the 5768 or 2007 daily or monthly calendars.

(The parallel Gregorian date shows as expected)

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: NO

I have I7670 who died on 30 KSL 5670.
I do not see the date in the Upcomming Events block or in the Yahrzeiten block (the date does not exist in 2007 and the event should be shown on another day).

I do neither see the event in the 5768 or 2007 daily or monthly calendars.

(The parallel Gregorian date shows as expected)