[Phpfreechat-svn] SF.net SVN: phpfreechat: [706] trunk/src/client

[<ke...@us...>]

Revision: 706
Author:   kerphi
Date:     2006-08-26 05:01:52 -0700 (Sat, 26 Aug 2006)
ViewCVS:  http://svn.sourceforge.net/phpfreechat/?rev=706&view=rev

Log Message:
-----------
[en] Bug fix: each commands which displayed an info message (/identify, /rehash ...) just cleared the screen on IE6. I found a workaround by moving the info message into the red error box.
[fr] Bug fix?\194?\160: toutes les commandes qui affichaient un message en retour (/identify, /rehash ...) provoquaient l'effacement de l'?\195?\169cran sous IE6. J'ai trouv?\195?\169 un moyen de contourner le probl?\195?\168me en affichant le message d'information dans la boite des erreurs.

Modified Paths:
--------------
    trunk/src/client/pfcclient.js
    trunk/src/client/pfcgui.js
    trunk/themes/default/style.css
Modified: trunk/src/client/pfcclient.js
===================================================================
--- trunk/src/client/pfcclient.js	2006-08-26 09:31:12 UTC (rev 705)
+++ trunk/src/client/pfcclient.js	2006-08-26 12:01:52 UTC (rev 706)
@@ -601,28 +601,26 @@
 
   displayMsg: function( cmd, msg )
   {
+    this.setError(msg);
+
+    // @todo find a better crossbrowser way to display messages
+/*
     // get the current selected tab container
     var tabid     = this.gui.getTabId();
     var container = this.gui.getChatContentFromTabId(tabid);
 
+    // to fix IE6 display bug
+    // http://sourceforge.net/tracker/index.php?func=detail&aid=1545403&group_id=158880&atid=809601
     div = document.createElement('div');
-    div.style.padding = "2px 5px 2px 5px";
-    
-    pre = document.createElement('pre');
-    pre.setAttribute('class', 'pfc_info pfc_info_'+cmd);
-    pre.setAttribute('className', 'pfc_info pfc_info_'+cmd); // for IE6
-    //    Element.addClassName(pre, 'pfc_info');
-    //    Element.addClassName(pre, 'pfc_info_'+cmd);
-    pre.style.border  = "1px solid #555";
-    pre.style.padding = "5px";
-    pre.innerHTML = msg;
-    div.appendChild(pre); 
-    
+    // div.style.padding = "2px 5px 2px 5px"; // this will clear the screen in IE6
+    div.innerHTML = '<div class="pfc_info pfc_info_'+cmd+'" style="margin:5px">'+msg+'</div>';
+
     // finaly append this to the message list
     container.appendChild(div); 
     this.gui.scrollDown(tabid, div);
+*/
   },
-  
+
   handleComingRequest: function( cmds )
   {
     var msg_html = $H();

Modified: trunk/src/client/pfcgui.js
===================================================================
--- trunk/src/client/pfcgui.js	2006-08-26 09:31:12 UTC (rev 705)
+++ trunk/src/client/pfcgui.js	2006-08-26 12:01:52 UTC (rev 706)
@@ -561,16 +561,16 @@
       clist.appendChild(img);
     }
 
+    // error box : <p id="pfc_errors">
+    var errorbox = document.createElement('div');
+    errorbox.setAttribute('id', 'pfc_errors');
+    inputcontainer.appendChild(errorbox);
+
     // smiley box :  <div id="pfc_smileys">
     var smileybox = document.createElement('div');
     smileybox.setAttribute('id', 'pfc_smileys');
     inputcontainer.appendChild(smileybox);
     this.loadSmileyBox();
-
-    // error box : <p id="pfc_errors">
-    var errorbox = document.createElement('div');
-    errorbox.setAttribute('id', 'pfc_errors');
-    contentexp.appendChild(errorbox);
   }
   
 };

Modified: trunk/themes/default/style.css
===================================================================
--- trunk/themes/default/style.css	2006-08-26 09:31:12 UTC (rev 705)
+++ trunk/themes/default/style.css	2006-08-26 12:01:52 UTC (rev 706)
@@ -217,16 +217,13 @@
 
 div#pfc_errors {
   display: none;
-  margin-top: 5px;
-  padding: 2px;
-  height: 18px;
-
+  padding: 5px;
   border: 1px solid #555;
-  color: #FC4A1F;
-  background-color: #FFBA76;
-  text-align: center;
+  color: #EC4B0F;
+  background-color: #FFBB77;
   font-style: italic;
-  font-weight: bold;
+  font-family: monospace;
+  font-size: 90%;
 }
 
 /* commands */
@@ -243,12 +240,19 @@
 }
 
 /* commands info */
-pre.pfc_info {
+.pfc_info {
   color: #888;
+
+  /* to fix IE6 display bug */
+  /* http://sourceforge.net/tracker/index.php?func=detail&aid=1545403&group_id=158880&atid=809601 */
+  font-family: sans-serif; /* do NOT setup monospace font or it will not work in IE6 */
+
   font-style: italic;
   background-color: #EEE;
+  font-size: 80%;
 }
 
+
 div#pfc_colorlist {
   display: none;
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.