phpesp-general

[phpesp-general] errors in my public/handler

[Nick C. <ni...@ni...>]

Hi, I appear to have created some bugs:

I have updated phpESP to the latest version but, 

1.Survey form has two error notices at top: there are undefined variables in
/public/handler, lines 465,466.
<input type="hidden" name="referer" value="" />
<input type="hidden" name="direct"  value="" />

2. I have filled in box on General page for email notification, but am not
getting any. 

3. on submitting, get Thanks page of errors, all on line 386
Notice: Undefined offset: 3 in
/home/bridlew1/public_html/survey/public/handler.php on line 386
Notice: Undefined offset: 4 in
/home/bridlew1/public_html/survey/public/handler.php on line 386
And these two lines repeat themselves all the way down the page.
Return

Thanks for helping
Nick
No virus found in this outgoing message.
Checked by AVG - www.avg.com 
Version: 9.0.791 / Virus Database: 271.1.1/2768 - Release Date: 03/24/10
19:33:00

Re: [phpesp-general] errors in my public/handler

[Franky V. L. <lie...@te...>]

On Fri, 26 Mar 2010 21:00:14 -0000
"Nick Coleman" <ni...@ni...> wrote:

> Hi, I appear to have created some bugs:
> 
> I have updated phpESP to the latest version but, 
> 
> 1.Survey form has two error notices at top: there are undefined
> variables in /public/handler, lines 465,466.
> <input type="hidden" name="referer" value="" />
> <input type="hidden" name="direct"  value="" />
> 
> 2. I have filled in box on General page for email notification, but
> am not getting any. 
> 
> 3. on submitting, get Thanks page of errors, all on line 386
> Notice: Undefined offset: 3 in
> /home/bridlew1/public_html/survey/public/handler.php on line 386
> Notice: Undefined offset: 4 in
> /home/bridlew1/public_html/survey/public/handler.php on line 386
> And these two lines repeat themselves all the way down the page.
> Return
> 
> Thanks for helping
> Nick

Hi,

it seems you have your error level in php.ini way too high. Remember
that showing php notices to the public is a security risk, showing eg.
the path to the script (as in your case). The recommended settings in
php.ini are:

display_errors = Off
log_errors = On

I added a check in admin/test.php for the display_errors variable.
But anyway, these php notices (which are NOT errors btw) should not
occur. I've uploaded a new version of public/handler.php to svn. For the
differences:
http://phpesp.svn.sourceforge.net/viewvc/phpesp/trunk/phpESP/public/handler.php?r1=1147&r2=1144

About the mail: check your maillogs for errors, maybe they get blocked.
Make sure the php mail() function works. Maybe I'll add the option to
directly contact a smtp server via php mail(), but for now you'll need
to check/correct your php.ini file for that (on unix it works via
sendmail, on windows it uses a specified smtp server). And also check
the values of:

$ESPCONFIG['email_from_address']
$ESPCONFIG['email_return_path']

it might be they are incorrect and your mailserver blocks the mails
because of this.

Franky

Re: [phpesp-general] errors in my public/handler

[eindaeast <ein...@gm...>]

Franky Van Liedekerke <liedekef <at> telenet.be> writes:

> 
> On Fri, 26 Mar 2010 21:00:14 -0000
> "Nick Coleman" <nick <at> nickcoleman.net> wrote:
> 
> > Hi, I appear to have created some bugs:
> > 
> > I have updated phpESP to the latest version but, 
> > 
> > 1.Survey form has two error notices at top: there are undefined
> > variables in /public/handler, lines 465,466.
> > <input type="hidden" name="referer" value="" />
> > <input type="hidden" name="direct"  value="" />
> > 
> > 2. I have filled in box on General page for email notification, but
> > am not getting any. 
> > 
> > 3. on submitting, get Thanks page of errors, all on line 386
> > Notice: Undefined offset: 3 in
> > /home/bridlew1/public_html/survey/public/handler.php on line 386
> > Notice: Undefined offset: 4 in
> > /home/bridlew1/public_html/survey/public/handler.php on line 386
> > And these two lines repeat themselves all the way down the page.
> > Return
> > 
> > Thanks for helping
> > Nick
> 
> Hi,
> 
> it seems you have your error level in php.ini way too high. Remember
> that showing php notices to the public is a security risk, showing eg.
> the path to the script (as in your case). The recommended settings in
> php.ini are:
> 
> display_errors = Off
> log_errors = On
> 

Many thanks for your work on the phpESP project Franky.
I'm most grateful.

I'm also having problems recently with the following

Deprecated: Assigning the return value of new by reference is deprecated in
/home/xxxxxxx/xxxxxxx/xxxxxxx/admin/include/lib/adodb/adodb-xmlschema03.inc.php
on line 404

Deprecated: Assigning the return value of new by reference is deprecated in
/home/xxxxxxx/xxxxxxx/xxxxxxx/admin/include/lib/adodb/adodb-xmlschema03.inc.php
on line 416

Notice: Undefined variable: request_referer in
/home/xxxxxxx/public_html/xxxxxxx/public/handler.php on line 464

Notice: Undefined variable: request_direct in
/home/xxxxxxx/public_html/xxxxxxx/public/handler.php on line 465

You mention that we need to change the php.ini file.
With my cpanel I can't see one anywhere in the files included in your package.
Should I create one? If so, where? Or should I add the lines in the
phpESP.ini.php file?

This has only started to be a problem in the last 2 months. Perhaps the hosting
company has updated their php version.

If you or anyone else could help, I would be most grateful.

Kind regards,

E

Re: [phpesp-general] errors in my public/handler

[eindaeast <ein...@gm...>]

> > > 1.Survey form has two error notices at top: there are undefined
> > > variables in /public/handler, lines 465,466.
> > > <input type="hidden" name="referer" value="" />
> > > <input type="hidden" name="direct"  value="" />
>
> > 
> > display_errors = Off
> > log_errors = On

> Deprecated: Assigning the return value of new by reference is deprecated in
> /home/xxxxxxx/xxxxxxx/xxxxxxx/admin/include/lib/adodb/adodb-xmlschema03.inc.php
> on line 404
> 
> Deprecated: Assigning the return value of new by reference is deprecated in
> /home/xxxxxxx/xxxxxxx/xxxxxxx/admin/include/lib/adodb/adodb-xmlschema03.inc.php
> on line 416
> 
> Notice: Undefined variable: request_referer in
> /home/xxxxxxx/public_html/xxxxxxx/public/handler.php on line 464
> 
> Notice: Undefined variable: request_direct in
> /home/xxxxxxx/public_html/xxxxxxx/public/handler.php on line 465
> 
> You mention that we need to change the php.ini file.
> With my cpanel I can't see one anywhere in the files included in your package.
> Should I create one? If so, where? Or should I add the lines in the
> phpESP.ini.php file?
> 
> This has only started to be a problem in the last 2 months. Perhaps the hosting
> company has updated their php version.
> 
> E


I seem to have worked out what to do to fix this.
I have created a php.ini file in each of the 4 folders
>admin
>public
>admin>include
>admin>include>lib
(Didn't seem to fix things unless I put a php.ini in each of those folders.)
I added just the following lines to each php.ini file

display_errors = Off
log_errors = On

I also went into the following files and added an @ mark in front of all the
"ereg"s. So for example in >admin>include>lib>espauth.inc I used the "find"
function after clicking "edit" to find anywhere where "ereg" was written and
then added an @ mark before it. Saved the files and now my phpESP is working
smoothly with no error messages. 

>admin>include>lib>espauth.inc
>admin>public>survey.php
>admin>include>lib>espresponse.inc (lots there but Do NOT put an @ before the
"eregi")

Thank you again Franky!