Thread: [phpesp-dev] Problem in Japanese environment

Status: Inactive

Brought to you by: bishopb, greggmc, liedekef

phpesp-devel

[phpesp-dev] Problem in Japanese environment

From: Hiroki N. <no...@en...> - 2008-10-23 07:29:03

Attachments: phpESP.html.tag.patch

hi all
	
The following issue in the Japanese environment.
 - A browser fails in the judgment of the character-code type
   because there is <META> tag behind <TITLE> tag.

The problem was fixed.
To send patches.

Re: [phpesp-dev] Problem in Japanese environment

From: Bishop B. <ph...@id...> - 2008-10-23 13:45:17

I have not applied this patch, but visually scanning the diff shows  
Hiroki's changes to be correct: meta content-type should always come  
right after <head>.

However, the one change I would suggest is that instead of showing the  
content-type meta only when one is defined, the meta tag is always  
shown but a default charset is used when absent from configuration.   
Example:

if (empty($cfg['charset'])) {
     $cfg['charset'] = 'UTF-8';
}
printf(
     "<meta http-equiv='Content-Type' content='text/html; charset=%s' />\n",
     $cfg['charset']
);



Regards,
bishop

Quoting Hiroki Nose <no...@en...>:

> hi all
>
> The following issue in the Japanese environment.
>  - A browser fails in the judgment of the character-code type
>    because there is <META> tag behind <TITLE> tag.
>
> The problem was fixed.
> To send patches.
>
>
>



-- 
Bishop Bettini
ideacode, Inc.
(main) +1 919 341 5170 / (fax) +1 919 521 4100

Visit us on the web at:
ideacode.com          Professional software research and development
reviewmysoftware.com  Improve sales! Review your software before you release
bytejar.com           Solutions to those annoying development problems

Re: [phpesp-dev] Problem in Japanese environment

From: Franky V. L. <lie...@te...> - 2008-11-20 22:52:38

On Thu, 23 Oct 2008 16:13:42 +0900
Hiroki Nose <no...@en...> wrote:

> hi all
> 	
> The following issue in the Japanese environment.
>  - A browser fails in the judgment of the character-code type
>    because there is <META> tag behind <TITLE> tag.
> 
> The problem was fixed.
> To send patches.
> 
> 

Hi Hiroki,

the changes have been implemented, thanks for the patch. Bishop: I
haven't added the check for empty charset, since it gets set by
default (admin/phpESP.ini.php.default) and if afterwards people decide
to unset it, that will not change what was now. If anywhere, the
emptyness could be tackled in admin/phpESP.ini.php.fixed

Franky

Re: [phpesp-dev] Problem in Japanese environment

From: Hiroki N. <no...@en...> - 2008-11-27 03:56:03

Attachments: phpESP.bugfix.patch

Franky Van Liedekerke wrote:
> On Thu, 23 Oct 2008 16:13:42 +0900
> Hiroki Nose <no...@en...> wrote:
> 
>> hi all
>> 	
>> The following issue in the Japanese environment.
>>  - A browser fails in the judgment of the character-code type
>>    because there is <META> tag behind <TITLE> tag.
>>
>> The problem was fixed.
>> To send patches.
>>
>>
> 
> Hi Hiroki,
> 
> the changes have been implemented, thanks for the patch. Bishop: I
> haven't added the check for empty charset, since it gets set by
> default (admin/phpESP.ini.php.default) and if afterwards people decide
> to unset it, that will not change what was now. If anywhere, the
> emptyness could be tackled in admin/phpESP.ini.php.fixed
> 
> Franky 
> 

Hi Franky,

Thanks.
but, there is a enbug. :)

The enbug was fixed.
I send patch.

Re: [phpesp-dev] Problem in Japanese environment

From: Franky V. L. <lie...@te...> - 2008-11-27 08:55:50

On Thu, Nov 27, 2008 at 4:55 AM, Hiroki Nose <no...@en...> wrote:

> Franky Van Liedekerke wrote:
>
>> On Thu, 23 Oct 2008 16:13:42 +0900
>> Hiroki Nose <no...@en...> wrote:
>>
>>  hi all
>>>
>>> The following issue in the Japanese environment.
>>>  - A browser fails in the judgment of the character-code type
>>>   because there is <META> tag behind <TITLE> tag.
>>>
>>> The problem was fixed.
>>> To send patches.
>>>
>>>
>>>
>> Hi Hiroki,
>>
>> the changes have been implemented, thanks for the patch. Bishop: I
>> haven't added the check for empty charset, since it gets set by
>> default (admin/phpESP.ini.php.default) and if afterwards people decide
>> to unset it, that will not change what was now. If anywhere, the
>> emptyness could be tackled in admin/phpESP.ini.php.fixed
>>
>> Franky
>>
>
> Hi Franky,
>
> Thanks.
> but, there is a enbug. :)
>
> The enbug was fixed.
> I send patch.
>

Hi Hiroki ,

you're right, I'll put this is svn asap.

Franky