phpesp-devel

[James D. <ja...@jm...>]

I've been reviewing phpESP with a view to accessibility and been making
a start by looking at whether the XHTML generated is well formed or not.
I've made a few changes to the code so far, which I'd checked out from
CVS. I'm not sure what the correct procedure for submitting patches are
but the output of cvs diff follows (I'm not all that familiar with CVS
either).

The main changes have been reshuffling some <div> tags to avoid cases
where empty div was created within the pages. I also removed some spaces
which shouldn't have been in a href property and corrected minor
mistakes in the login page.

I removed blank options within select boxes. I can see what was trying
to be achieved with them but it's not valid HTML. Perhaps it would be
better to have a placeholder "please select a value" option?

James

Index: admin/include/head.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/head.inc,v
retrieving revision 1.9
diff -d -r1.9 head.inc
20d19
< 	<div>
Index: admin/include/lib/esphtml.forms.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/lib/esphtml.forms.inc,v
retrieving revision 1.16
diff -d -r1.16 esphtml.forms.inc
122d121
< 	$str .= "<option></option>\n";
160c159
<     $str .= '<link rel="stylesheet" href="'.
$GLOBALS['ESPCONFIG']['css_url'].$_css .'" type="text/css">';
---
>     $str .= '<link rel="stylesheet" href="'.
$GLOBALS['ESPCONFIG']['css_url'].$_css .'" type="text/css"/>';
172c171

<     $str .= '<form name="loginform" id="loginform"  method="post">';
---
>     $str .= '<form name="loginform" id="loginform"  method="post"
action="manage.php">';
Index: admin/include/lib/adodb/adodb-lib.inc.php
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/lib/adodb/adodb-lib.inc.php,v
retrieving revision 1.1
diff -d -r1.1 adodb-lib.inc.php
119c119
< 		} else $s .= "\n<option></option>";
---
> 		} else $s .= "\n";
675c675
< ?>
\ No newline at end of file
---
> ?>
Index: admin/include/where/access.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/access.inc,v
retrieving revision 1.17
diff -d -r1.17 access.inc
108c108
< 		$r = '<select name="realm"><option></option>';
---
> 		$r = '<select name="realm">';
143a144
> <div>
Index: admin/include/where/admdesigner.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/admdesigner.inc,v
retrieving revision 1.14
diff -d -r1.14 admdesigner.inc
230c230
< 		$r = '<select name="r"><option></option>';
---
> 		$r = '<select name="r">;
Index: admin/include/where/admrespondent.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/admrespondent.inc,v
retrieving revision 1.13
diff -d -r1.13 admrespondent.inc
205c205

< 		$r = '<select name="r"><option></option>';
---
> 		$r = '<select name="r">';
Index: admin/include/where/copy.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/copy.inc,v
retrieving revision 1.17
diff -d -r1.17 copy.inc
59a60
> <div>
Index: admin/include/where/designers.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/designers.inc,v
retrieving revision 1.10
diff -d -r1.10 designers.inc
89a90
> <div>
Index: admin/include/where/edit.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/edit.inc,v
retrieving revision 1.12
diff -d -r1.12 edit.inc
30a31
> <div>
Index: admin/include/where/export.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/export.inc,v
retrieving revision 1.20
diff -d -r1.20 export.inc
19d18
< </div>
97c96
< 			<?php echo('<a href="javascript: exportSubmit(\'export\',
document.getElementById(\'export'.$sid.'\'));" title="Save the results
for \''.$name.'\' to the survey in CSV Format (Comma Delimted File).
Column Titles are based on question text.">' . _('Save On Server') .
'</a>');
---
> 			<?php echo('<a
href="javascript:exportSubmit(\'export\',document.getElementById(\'export'.$sid.'\'));"
title="Save the results for \''.$name.'\' to the survey in CSV Format
(Comma Delimted File). Column Titles are based on question text.">' .
_('Save On Server') . '</a>');
100c99

< 			echo('<a href="javascript: exportSubmit(\'download\',
document.getElementById(\'export'.$sid.'\'));" title="Download the
results for \''.$name.'\' to your computer in CSV Format (Comma Delimted
File). Column Titles are based on the question text. Click this link and
select \'Save\' when prompted by your browser.">' . _('Download') .
'</a>'); ?>
---
> 			echo('<a
href="javascript:exportSubmit(\'download\',document.getElementById(\'export'.$sid.'\'));"
title="Download the results for \''.$name.'\' to your computer in CSV
Format (Comma Delimted File). Column Titles are based on the question
text. Click this link and select \'Save\' when prompted by your
browser.">' . _('Download') . '</a>'); ?>
Index: admin/include/where/groups.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/groups.inc,v
retrieving revision 1.10
diff -d -r1.10 groups.inc
47a48
> <div>
Index: admin/include/where/guide.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/guide.inc,v
retrieving revision 1.5
diff -d -r1.5 guide.inc
11a12
> <div>
Index: admin/include/where/help.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/help.inc,v
retrieving revision 1.18
diff -d -r1.18 help.inc
340d339
<                 <option></option>
Index: admin/include/where/manage.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/manage.inc,v
retrieving revision 1.28
diff -d -r1.28 manage.inc
13a14
> <div>
Index: admin/include/where/passwd.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/passwd.inc,v
retrieving revision 1.7
diff -d -r1.7 passwd.inc
12a13
> <div>
Index: admin/include/where/report.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/report.inc,v
retrieving revision 1.15
diff -d -r1.15 report.inc
64a65
> <div>
Index: admin/include/where/respondents.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/respondents.inc,v
retrieving revision 1.10
diff -d -r1.10 respondents.inc
88a89
> <div>
Index: admin/include/where/results.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/results.inc,v
retrieving revision 1.33
diff -d -r1.33 results.inc
147a148
>     <div>
156c157
<         echo('<h2>'. _('Cross Tabulation') ."</h2>\n");
---
>         echo('<div> <!-- this is where it should be --><h2>'. _('Cross
Tabulation') ."</h2>\n");
210d210

<             <option value=""></option>
Index: admin/include/where/status.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/status.inc,v
retrieving revision 1.24
diff -d -r1.24 status.inc
110a111
> <div>
Index: admin/include/where/tab.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/tab.inc,v
retrieving revision 1.17
diff -d -r1.17 tab.inc
141d140
< </div>
Index: admin/include/where/test.inc
===================================================================
RCS file: /cvsroot/phpesp/phpESP/admin/include/where/test.inc,v
retrieving revision 1.25
diff -d -r1.25 test.inc
0a1
> <div><!-- Something needs doing with this div -->