phpesp-devel

[phpesp-dev] another bug in CVS version

[Robert A. V. II <bo...@pi...>]

The database allows question names of up to 30 characters but the PHP
code limits it to 10.

This patch changes the PHP limit to match the database limit:

diff -ur phpESP/admin/include/function/survey_update.inc phpESP-patched/admin/include/function/survey_update.inc
--- phpESP/admin/include/function/survey_update.inc     2002-09-11 12:52:30.000000000 -0400
+++ phpESP-patched/admin/include/function/survey_update.inc 2002-10-02 01:45:54.000000000 -0400
@@ -138,7 +138,7 @@
                                $HTTP_POST_VARS['name'] = $str1;
                        }
                        $HTTP_POST_VARS['name'] = strtoupper(substr(eregi_replace(
-                               "[^A-Z0-9]+", "_", trim($HTTP_POST_VARS['name'])), 0, 10));
+                               "[^A-Z0-9]+", "_", trim($HTTP_POST_VARS['name'])), 0, 30));
                        $HTTP_POST_VARS['name'] = ereg_replace('_$',"",$HTTP_POST_VARS['name']);

                        // constraint: question type required


-- 
Robert August Vincent, II (pronounced "bob" or "bob-vee")
bo...@pi..., geek@large, com...@bo...

Re: [phpesp-dev] another bug in CVS version

[Robert A. V. II <bo...@pi...>]

On Sun, Oct 06, 2002 at 09:55:56PM -0400, Matthew Gregg wrote:
> Bob,
> I just finished applying this and the "answer carry over" patch you
> submitted.

Thanks!  That makes me feel like I've contributed something, rather
than being a "leech" off the free software community.

> Thanks again and please feel free to submit more in the future. (-:

Well, this was kind-of a one-time project for me.  Unless I get more
clients who want a survey/poll program installed, I probably won't be
very active on your list (though I'll retain the subscription just in
case).

I have made a few more changes, specific to my clients wishes:

* He wanted less whitespace around the questions.

* He wanted answers to the right of questions, not under them.

* He wanted questions to alternate between shaded and unshaded.

I created a new stylesheet, but I also had to make some code changes.
If anybody is interested, I'll post a diff.

-- 
Robert August Vincent, II (pronounced "bob" or "bob-vee")
bo...@pi..., geek@large, com...@bo...

[phpesp-dev] Use of thanks_page field?

[Gary Ashton-J. <gas...@f2...>]

One of our designers wants to nominate the URL for the 'Return' button 
at the end of the survey rather than use the 'referer' field from the 
browser.

I notice that the 'thanks_page' field in the 'survey' table seems to be 
intended for this. Has anyone written any code to let the user maintain 
this field and for the survey to actually use the field?

If not, I would like to submit some patches to do so.

Cheers

Gary