phpesp-devel

[phpesp-dev] phpESP Survey Themes

[Kon A. <ang...@ip...>]

Hi Guys,

	It's finally here.
	Attached you should find a phpThemes.tar.gz file. This file contains a 
directory called phpESP_addons which further contains the following:
	1/ A css directory and a template.css file within it.
	2/ A examples directory containing a classes.html example file
	3/ A surveyimages directory containing a sample image
	4/ A themes.patch file.

	The patch has been created against the latest cvs devel version of phpESP.
	You may wish to edit the paths and database stuff prior to applying it.
	
	After applying the patch copy the css and examples directories from the 
phpESP_addons folder to the root directory of your phpESP installation 
(default: /usr/local/lib/php/contrib/phpESP/). Also copy the surveyimages 
directory from phpESP_addons to your phpESP image directory.

You should then be right to go.
You may like to read the readme file (README_SURVEYTHEMES) and go to the help 
pages when creating a survey for an example.

Please test it, break it, comment on it .........


Kon

[phpesp-dev] Re: phpESP Survey Themes

[Matthew G. <gr...@mu...>]

I've only had time to take a quick look at the patch this weekend, but
it looks darn good!  I'll do some deeper digging next week.

What I've noticed so far:
- "/css" should probably be "/public/css" by default

- Maybe think about moving your CSS additions in phpESP.ini,
  so that they will be grouped together with the other file/http
  paths.

- Maybe include the new files and directories in the patch instead of 
  of having to manually create/copy them/ 

- When you build your patch make sure the phpESP.ini and the other
  places paths are configured(manage.php, handler.php, etc..) are
  unchanged from CVS, except for your new CSS additions of course.
 
This is gonna be cool 8)


On a side note...
Since I sit on Open Projects(http://www.openprojects.net/)
most all the time anyhow, I decided to register #phpesp and sit on
that as well.  If anyone wants to drop by and talk about devel issues,
a problem with phpESP, etc.  I'll be lurking.  



On Sat, Jun 08, 2002 at 05:37:50PM +1000, Kon Angelopoulos wrote:
> Hi Guys,
> 
> 	It's finally here.
> 	Attached you should find a phpThemes.tar.gz file. This file contains a 
> directory called phpESP_addons which further contains the following:
...Snip...
> 
> Kon


-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

Re: [phpesp-dev] Re: phpESP Survey Themes

[Kon A. <ang...@ip...>]

Thanks for the feedback Greg,

All your points are worthwhile.
Let's wait a little while (say by the end of the week) to see if there are no 
issues with the actual css stuff then it will be a quick fix to change things 
to what you've suggested and release it officially.


Kon

On Mon, 10 Jun 2002 12:28, Matthew Gregg wrote:
> I've only had time to take a quick look at the patch this weekend, but
> it looks darn good!  I'll do some deeper digging next week.
>
> What I've noticed so far:
> - "/css" should probably be "/public/css" by default
>
> - Maybe think about moving your CSS additions in phpESP.ini,
>   so that they will be grouped together with the other file/http
>   paths.
>
> - Maybe include the new files and directories in the patch instead of
>   of having to manually create/copy them/
>
> - When you build your patch make sure the phpESP.ini and the other
>   places paths are configured(manage.php, handler.php, etc..) are
>   unchanged from CVS, except for your new CSS additions of course.
>
> This is gonna be cool 8)
>
>
> On a side note...
> Since I sit on Open Projects(http://www.openprojects.net/)
> most all the time anyhow, I decided to register #phpesp and sit on
> that as well.  If anyone wants to drop by and talk about devel issues,
> a problem with phpESP, etc.  I'll be lurking.
>
> On Sat, Jun 08, 2002 at 05:37:50PM +1000, Kon Angelopoulos wrote:
> > Hi Guys,
> >
> > 	It's finally here.
> > 	Attached you should find a phpThemes.tar.gz file. This file contains a
> > directory called phpESP_addons which further contains the following:
>
> ...Snip...
>
> > Kon

Re: [phpesp-dev] Re: phpESP Survey Themes

[Matthew G. <gr...@mu...>]

After looking at the patch more thoroughly, I only see one issue.

Make sure the default(blank) theme looks as close as possible to
the old unthemed surveys on 4/5/6/7 version browsers.  I noted some
alignment problems with question numbers and question text, etc...

Otherwise I think it looks good.

On Mon, Jun 10, 2002 at 12:41:37PM +1000, Kon Angelopoulos wrote:
> Thanks for the feedback Greg,
> 
> All your points are worthwhile.
> Let's wait a little while (say by the end of the week) to see if there are no 
> issues with the actual css stuff then it will be a quick fix to change things 
> to what you've suggested and release it officially.
> 
> 
> Kon
> 
> On Mon, 10 Jun 2002 12:28, Matthew Gregg wrote:
> > I've only had time to take a quick look at the patch this weekend, but
> > it looks darn good!  I'll do some deeper digging next week.
> >
> > What I've noticed so far:
> > - "/css" should probably be "/public/css" by default
> >
> > - Maybe think about moving your CSS additions in phpESP.ini,
> >   so that they will be grouped together with the other file/http
> >   paths.
> >
> > - Maybe include the new files and directories in the patch instead of
> >   of having to manually create/copy them/
> >
> > - When you build your patch make sure the phpESP.ini and the other
> >   places paths are configured(manage.php, handler.php, etc..) are
> >   unchanged from CVS, except for your new CSS additions of course.
> >
> > This is gonna be cool 8)
> >
> >
> > On a side note...
> > Since I sit on Open Projects(http://www.openprojects.net/)
> > most all the time anyhow, I decided to register #phpesp and sit on
> > that as well.  If anyone wants to drop by and talk about devel issues,
> > a problem with phpESP, etc.  I'll be lurking.
> >
> > On Sat, Jun 08, 2002 at 05:37:50PM +1000, Kon Angelopoulos wrote:
> > > Hi Guys,
> > >
> > > 	It's finally here.
> > > 	Attached you should find a phpThemes.tar.gz file. This file contains a
> > > directory called phpESP_addons which further contains the following:
> >
> > ...Snip...
> >
> > > Kon
> 

-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

Re: [phpesp-dev] Re: phpESP Survey Themes

[Kon A. <ang...@ip...>]

Thanks for the feedback Matthew,

I'll take your suggestions on board and create a final release version.
How should this be deployed?
Should it be a patch release or shall we implement it through cvs?

Kon

On Fri, 14 Jun 2002 05:39, Matthew Gregg wrote:
> After looking at the patch more thoroughly, I only see one issue.
>
> Make sure the default(blank) theme looks as close as possible to
> the old unthemed surveys on 4/5/6/7 version browsers.  I noted some
> alignment problems with question numbers and question text, etc...
>
> Otherwise I think it looks good.
>
> On Mon, Jun 10, 2002 at 12:41:37PM +1000, Kon Angelopoulos wrote:
> > Thanks for the feedback Greg,
> >
> > All your points are worthwhile.
> > Let's wait a little while (say by the end of the week) to see if there
> > are no issues with the actual css stuff then it will be a quick fix to
> > change things to what you've suggested and release it officially.
> >
> >
> > Kon
> >
> > On Mon, 10 Jun 2002 12:28, Matthew Gregg wrote:
> > > I've only had time to take a quick look at the patch this weekend, but
> > > it looks darn good!  I'll do some deeper digging next week.
> > >
> > > What I've noticed so far:
> > > - "/css" should probably be "/public/css" by default
> > >
> > > - Maybe think about moving your CSS additions in phpESP.ini,
> > >   so that they will be grouped together with the other file/http
> > >   paths.
> > >
> > > - Maybe include the new files and directories in the patch instead of
> > >   of having to manually create/copy them/
> > >
> > > - When you build your patch make sure the phpESP.ini and the other
> > >   places paths are configured(manage.php, handler.php, etc..) are
> > >   unchanged from CVS, except for your new CSS additions of course.
> > >
> > > This is gonna be cool 8)
> > >
> > >
> > > On a side note...
> > > Since I sit on Open Projects(http://www.openprojects.net/)
> > > most all the time anyhow, I decided to register #phpesp and sit on
> > > that as well.  If anyone wants to drop by and talk about devel issues,
> > > a problem with phpESP, etc.  I'll be lurking.
> > >
> > > On Sat, Jun 08, 2002 at 05:37:50PM +1000, Kon Angelopoulos wrote:
> > > > Hi Guys,
> > > >
> > > > 	It's finally here.
> > > > 	Attached you should find a phpThemes.tar.gz file. This file contains
> > > > a directory called phpESP_addons which further contains the
> > > > following:
> > >
> > > ...Snip...
> > >
> > > > Kon

Re: [phpesp-dev] Re: phpESP Survey Themes

[James E. F. <jf...@ac...>]

On Fri, 14 Jun 2002, Kon Angelopoulos wrote:

> Thanks for the feedback Matthew,
>
> I'll take your suggestions on board and create a final release version.
> How should this be deployed?
> Should it be a patch release or shall we implement it through cvs?
>
> Kon

Sweet! Nice work. Kon, you've got cvs priv's. :-) I have to
admit I haven't had time to look at the code recently, or
see it in action. I don't want to hold you up just because
I am busy. Go ahead and use cvs when you are ready. After
all it is cvs so it makes changing things later easier (if
necessary). Matthew also has cvs priv's and has been using
them, and it looks like he is tracking your changes in a
more timely manner than I am. So I am going to leave it up
to you two. Please commit changes to HEAD (the default) so
that we can get more testers. :-) If you have any questions
feel free to contact me on or off list.

Thanks again for helping make phpESP better. :-)
Take it easy,
-James