Thread: [phpesp-dev] Bug fix for CSV export problem.

Status: Inactive

Brought to you by: bishopb, greggmc, liedekef

phpesp-devel

[phpesp-dev] Bug fix for CSV export problem.

From: Matthew G. <gr...@mu...> - 2002-05-20 18:05:44

I think this fixes bug#: 557329. 

Change line 354 in espresponse.inc
- if (isset($values[$qid]))
+ if (is_array($values[$qid]))

Comments?

-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

Re: [phpesp-dev] Bug fix for CSV export problem.

From: James E. F. <jf...@ac...> - 2002-05-21 17:10:49

Looks good, commit it. :-) Mention the Bug # in your commit
message, for how I log bug fixes, see:
 http://phpesp.sf.net/cvs/admin/include/lib/espresponse.inc

Also, I believe you have perm's to modify bug reports on
the sf site, so you can close it too ... there is a
"canned" response for "fixed in CVS".

-James

On Mon, 20 May 2002, Matthew Gregg wrote:

> I think this fixes bug#: 557329.
>
> Change line 354 in espresponse.inc
> - if (isset($values[$qid]))
> + if (is_array($values[$qid]))
>
> Comments?
>
>

Re: [phpesp-dev] Bug fix for CSV export problem.

From: Matthew G. <gr...@mu...> - 2002-05-21 17:41:35

I've committed the change to CVS, but it looks like I'm unable to
close bug reports.

On Tue, May 21, 2002 at 01:10:44PM -0400, James E. Flemer wrote:
> Looks good, commit it. :-) Mention the Bug # in your commit
> message, for how I log bug fixes, see:
>  http://phpesp.sf.net/cvs/admin/include/lib/espresponse.inc
> 
> Also, I believe you have perm's to modify bug reports on
> the sf site, so you can close it too ... there is a
> "canned" response for "fixed in CVS".
> 
> -James
> 
> On Mon, 20 May 2002, Matthew Gregg wrote:
> 
> > I think this fixes bug#: 557329.
> >
> > Change line 354 in espresponse.inc
> > - if (isset($values[$qid]))
> > + if (is_array($values[$qid]))
> >
> > Comments?
> >
> >
> 

-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

[phpesp-dev] change log

From: James E. F. <jf...@ac...> - 2002-05-21 17:55:55

Hello developers ...
  I added a change log[1] before the release of v1.4. I
will try to keep this up to date, so that people who don't
track this list or the cvs tree can see what is being done
on phpESP. I know not many of you are actively submitting
(or committing) patches, but those of you who are can help
out by adding notes to the change log when you make any
signifigant changes. Just follow a similar format as the
notes I made (or suggest a better format), and feel free to
credit yourself where you feel due.

[1] http://phpesp.sf.net/cvs/CHANGES?rev=.

-James