From: Joel P. (Volt) <a-j...@mi...> - 2008-06-18 22:43:22
|
I'm looking into helping the project's mssql (sql server) support and found that the adodb data dictionary doesn't quote reserved words. What's the chances of changing a field name for better database compatibility? CREATE TABLE phpesp_question ( id INT IDENTITY(1,1) NOT NULL, survey_id INT NOT NULL, name VARCHAR(30) NOT NULL, type_id INT NOT NULL, result_id INT NULL, length INT DEFAULT 0 NOT NULL, precise INT DEFAULT 0 NOT NULL, position INT NOT NULL, content TEXT NULL, required VARCHAR(1) DEFAULT 'N' NOT NULL, deleted VARCHAR(1) DEFAULT 'N' NOT NULL, public VARCHAR(1) DEFAULT 'Y' NOT NULL, ans_uniq VARCHAR(1) DEFAULT 'N' NOT NULL, PRIMARY KEY (id) ) SQLState: 42000 Error Code: 156 Message: [Microsoft][SQL Native Client][SQL Server]Incorrect syntax near the keyword 'public'. Joel Penner Volt Microsoft Open Source Software Lab<http://port25.technet.com/> |
From: Matthew G. <mat...@gm...> - 2008-06-19 00:55:43
|
I wouldn't be against a proper patch that made the change. On Wed, 2008-06-18 at 15:43 -0700, Joel Penner (Volt) wrote: > I’m looking into helping the project’s mssql (sql server) support and > found that the adodb data dictionary doesn’t quote reserved words. > What’s the chances of changing a field name for better database > compatibility? > > > > CREATE TABLE phpesp_question ( > > id INT IDENTITY(1,1) NOT NULL, > > survey_id INT NOT NULL, > > name VARCHAR(30) NOT NULL, > > type_id INT NOT NULL, > > result_id INT NULL, > > length INT DEFAULT 0 NOT NULL, > > precise INT DEFAULT 0 NOT NULL, > > position INT NOT NULL, > > content TEXT NULL, > > required VARCHAR(1) DEFAULT 'N' NOT NULL, > > deleted VARCHAR(1) DEFAULT 'N' NOT NULL, > > public VARCHAR(1) DEFAULT 'Y' NOT NULL, > > ans_uniq VARCHAR(1) DEFAULT 'N' NOT NULL, > > PRIMARY KEY (id) > > ) > > > > > > SQLState: 42000 Error Code: 156 Message: [Microsoft][SQL Native > Client][SQL Server]Incorrect syntax near the keyword 'public'. > > > > > > Joel Penner > > Volt > > Microsoft Open Source Software Lab > > > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ phpESP-devel mailing list php...@li... https://lists.sourceforge.net/lists/listinfo/phpesp-devel -- Matthew Gregg <mat...@gm...> |
From: Joel P. (Volt) <a-j...@mi...> - 2008-06-19 19:43:23
|
I doubt you would like it to be "icanhaspublic", I'm thinking of something like "ispublic" -----Original Message----- From: php...@li... [mailto:php...@li...] On Behalf Of Matthew Gregg Sent: Wednesday, June 18, 2008 5:56 PM To: php...@li... Subject: Re: [phpesp-dev] mssql support I wouldn't be against a proper patch that made the change. On Wed, 2008-06-18 at 15:43 -0700, Joel Penner (Volt) wrote: > I’m looking into helping the project’s mssql (sql server) support and > found that the adodb data dictionary doesn’t quote reserved words. > What’s the chances of changing a field name for better database > compatibility? > > > > CREATE TABLE phpesp_question ( > > id INT IDENTITY(1,1) NOT NULL, > > survey_id INT NOT NULL, > > name VARCHAR(30) NOT NULL, > > type_id INT NOT NULL, > > result_id INT NULL, > > length INT DEFAULT 0 NOT NULL, > > precise INT DEFAULT 0 NOT NULL, > > position INT NOT NULL, > > content TEXT NULL, > > required VARCHAR(1) DEFAULT 'N' NOT NULL, > > deleted VARCHAR(1) DEFAULT 'N' NOT NULL, > > public VARCHAR(1) DEFAULT 'Y' NOT NULL, > > ans_uniq VARCHAR(1) DEFAULT 'N' NOT NULL, > > PRIMARY KEY (id) > > ) > > > > > > SQLState: 42000 Error Code: 156 Message: [Microsoft][SQL Native > Client][SQL Server]Incorrect syntax near the keyword 'public'. > > > > > > Joel Penner > > Volt > > Microsoft Open Source Software Lab > > > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ phpESP-devel mailing list php...@li... https://lists.sourceforge.net/lists/listinfo/phpesp-devel -- Matthew Gregg <mat...@gm...> ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ phpESP-devel mailing list php...@li... https://lists.sourceforge.net/lists/listinfo/phpesp-devel |
From: Franky V. L. <lie...@te...> - 2008-06-19 21:29:52
|
A patch for this isn't too difficult, but to resolve the issue once and for all for all databases and reserved words, I would suggest a complete rename of all columns ... eg. using a prefix or so Franky On Thu, 19 Jun 2008 12:43:19 -0700 "Joel Penner (Volt)" <a-j...@mi...> wrote: > I doubt you would like it to be "icanhaspublic", I'm thinking of > something like "ispublic" > > -----Original Message----- > From: php...@li... > [mailto:php...@li...] On Behalf Of > Matthew Gregg Sent: Wednesday, June 18, 2008 5:56 PM To: > php...@li... Subject: Re: [phpesp-dev] mssql > support > > I wouldn't be against a proper patch that made the change. > > On Wed, 2008-06-18 at 15:43 -0700, Joel Penner (Volt) wrote: > > I’m looking into helping the project’s mssql (sql server) support > > and found that the adodb data dictionary doesn’t quote reserved > > words. What’s the chances of changing a field name for better > > database compatibility? > > > > > > > > CREATE TABLE phpesp_question ( > > > > id INT IDENTITY(1,1) NOT NULL, > > > > survey_id INT NOT NULL, > > > > name VARCHAR(30) NOT NULL, > > > > type_id INT NOT NULL, > > > > result_id INT NULL, > > > > length INT DEFAULT 0 NOT NULL, > > > > precise INT DEFAULT 0 NOT NULL, > > > > position INT NOT NULL, > > > > content TEXT NULL, > > > > required VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > deleted VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > public VARCHAR(1) DEFAULT 'Y' NOT NULL, > > > > ans_uniq VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > PRIMARY KEY (id) > > > > ) > > > > > > > > > > > > SQLState: 42000 Error Code: 156 Message: [Microsoft][SQL Native > > Client][SQL Server]Incorrect syntax near the keyword 'public'. > > > > > > > > > > > > Joel Penner > > > > Volt > > > > Microsoft Open Source Software Lab > > > > |
From: Matthew G. <mat...@gm...> - 2008-06-19 21:49:00
|
Yeah that would seem to be way to go. On Thu, 2008-06-19 at 23:29 +0200, Franky Van Liedekerke wrote: > A patch for this isn't too difficult, but to resolve the issue once and > for all for all databases and reserved words, I would suggest a > complete rename of all columns ... eg. using a prefix or so > > Franky > > On Thu, 19 Jun 2008 12:43:19 -0700 > "Joel Penner (Volt)" <a-j...@mi...> wrote: > > > I doubt you would like it to be "icanhaspublic", I'm thinking of > > something like "ispublic" > > > > -----Original Message----- > > From: php...@li... > > [mailto:php...@li...] On Behalf Of > > Matthew Gregg Sent: Wednesday, June 18, 2008 5:56 PM To: > > php...@li... Subject: Re: [phpesp-dev] mssql > > support > > > > I wouldn't be against a proper patch that made the change. > > > > On Wed, 2008-06-18 at 15:43 -0700, Joel Penner (Volt) wrote: > > > I’m looking into helping the project’s mssql (sql server) support > > > and found that the adodb data dictionary doesn’t quote reserved > > > words. What’s the chances of changing a field name for better > > > database compatibility? > > > > > > > > > > > > CREATE TABLE phpesp_question ( > > > > > > id INT IDENTITY(1,1) NOT NULL, > > > > > > survey_id INT NOT NULL, > > > > > > name VARCHAR(30) NOT NULL, > > > > > > type_id INT NOT NULL, > > > > > > result_id INT NULL, > > > > > > length INT DEFAULT 0 NOT NULL, > > > > > > precise INT DEFAULT 0 NOT NULL, > > > > > > position INT NOT NULL, > > > > > > content TEXT NULL, > > > > > > required VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > > > deleted VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > > > public VARCHAR(1) DEFAULT 'Y' NOT NULL, > > > > > > ans_uniq VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > > > PRIMARY KEY (id) > > > > > > ) > > > > > > > > > > > > > > > > > > SQLState: 42000 Error Code: 156 Message: [Microsoft][SQL Native > > > Client][SQL Server]Incorrect syntax near the keyword 'public'. > > > > > > > > > > > > > > > > > > Joel Penner > > > > > > Volt > > > > > > Microsoft Open Source Software Lab > > > > > > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > phpESP-devel mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpesp-devel -- Matthew Gregg <mat...@gm...> |
From: Joel P. (Volt) <a-j...@mi...> - 2008-06-19 22:15:23
|
I think for my purposes, I'm just going to rename the 4 boolean variables in the questions table and the 1 boolean variable in surveys -----Original Message----- From: php...@li... [mailto:php...@li...] On Behalf Of Matthew Gregg Sent: Thursday, June 19, 2008 2:49 PM To: php...@li... Subject: Re: [phpesp-dev] mssql support Yeah that would seem to be way to go. On Thu, 2008-06-19 at 23:29 +0200, Franky Van Liedekerke wrote: > A patch for this isn't too difficult, but to resolve the issue once and > for all for all databases and reserved words, I would suggest a > complete rename of all columns ... eg. using a prefix or so > > Franky > > On Thu, 19 Jun 2008 12:43:19 -0700 > "Joel Penner (Volt)" <a-j...@mi...> wrote: > > > I doubt you would like it to be "icanhaspublic", I'm thinking of > > something like "ispublic" > > > > -----Original Message----- > > From: php...@li... > > [mailto:php...@li...] On Behalf Of > > Matthew Gregg Sent: Wednesday, June 18, 2008 5:56 PM To: > > php...@li... Subject: Re: [phpesp-dev] mssql > > support > > > > I wouldn't be against a proper patch that made the change. > > > > On Wed, 2008-06-18 at 15:43 -0700, Joel Penner (Volt) wrote: > > > I’m looking into helping the project’s mssql (sql server) support > > > and found that the adodb data dictionary doesn’t quote reserved > > > words. What’s the chances of changing a field name for better > > > database compatibility? > > > > > > > > > > > > CREATE TABLE phpesp_question ( > > > > > > id INT IDENTITY(1,1) NOT NULL, > > > > > > survey_id INT NOT NULL, > > > > > > name VARCHAR(30) NOT NULL, > > > > > > type_id INT NOT NULL, > > > > > > result_id INT NULL, > > > > > > length INT DEFAULT 0 NOT NULL, > > > > > > precise INT DEFAULT 0 NOT NULL, > > > > > > position INT NOT NULL, > > > > > > content TEXT NULL, > > > > > > required VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > > > deleted VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > > > public VARCHAR(1) DEFAULT 'Y' NOT NULL, > > > > > > ans_uniq VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > > > PRIMARY KEY (id) > > > > > > ) > > > > > > > > > > > > > > > > > > SQLState: 42000 Error Code: 156 Message: [Microsoft][SQL Native > > > Client][SQL Server]Incorrect syntax near the keyword 'public'. > > > > > > > > > > > > > > > > > > Joel Penner > > > > > > Volt > > > > > > Microsoft Open Source Software Lab > > > > > > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > phpESP-devel mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpesp-devel -- Matthew Gregg <mat...@gm...> ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ phpESP-devel mailing list php...@li... https://lists.sourceforge.net/lists/listinfo/phpesp-devel |