From: Franky V. L. <lie...@te...> - 2008-01-16 22:27:06
|
Hi Bishop, this statement: ALTER TABLE response ADD COLUMN ip CHAR(64); was already in the mysql_update-1.5-1.6.sql file ... I wonder if your install really was 1.8.2? Or maybe the create script didn't include this column for 1.8.2 and decided not to use it then, but I can't say that for sure, that's way too long in the past for me and before I started changing it. It somebody can confirm this, I'll add this line to the upgrade file. Franky |
From: Matthew G. <mat...@gm...> - 2008-01-16 22:43:35
|
Yup it is, but if he was running a 1.8 version created using a 1.8 mysql_populate script he would have never ran mysql_update-1.5-1.6.sql. The IP field was added in mysql_populate in revision 918, but not added to the 1.8.2.x upgrade scripts. So he would have missed getting an IP field added. I have added the IP field to the update scripts in SVN. On Wed, 2008-01-16 at 23:23 +0100, Franky Van Liedekerke wrote: > Hi Bishop, > > this statement: > > ALTER TABLE response ADD COLUMN ip CHAR(64); > > was already in the mysql_update-1.5-1.6.sql file ... I wonder if your > install really was 1.8.2? > Or maybe the create script didn't include this column for 1.8.2 and > decided not to use it then, but I can't say that for sure, that's way > too long in the past for me and before I started changing it. It > somebody can confirm this, I'll add this line to the upgrade file. > > Franky > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > phpESP-devel mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpesp-devel |
From: Bishop B. <ph...@id...> - 2008-01-16 22:46:53
|
Hi Franky, Indeed it was a 1.8.2 install, created from the tarball on butterfat =20 and after running the mysql create and populate scripts. In that installation, there is no reference to ip column: $ ls -l scripts/db/ total 44 -rw-r--r-- 1 ideacode.com apache 148 Mar 8 2005 mysql4.x_upgrade.sql -rw-r--r-- 1 ideacode.com apache 1398 Feb 27 2003 mysql_create.sql -rw-r--r-- 1 ideacode.com apache 8246 Mar 29 2006 mysql_populate.sql -rw-r--r-- 1 ideacode.com apache 1073 Feb 27 2003 mysql_update-1.5-1.6.sql -rw-r--r-- 1 ideacode.com apache 9870 Apr 30 2004 postgres_populate.sql -rw-r--r-- 1 ideacode.com apache 6852 Apr 30 2004 sqlite_populate.sql $ grep -i 'ip.*char' scripts/db/*sql $ But in the latest code, the ip column is mentioned three times: # ls -l scripts/db/*sql -rw-r--r-- 1 root root 272 Jan 9 14:43 scripts/db/mysql4.x_upgrade.sql -rw-r--r-- 1 root root 1398 Jan 9 12:57 scripts/db/mysql_create.sql -rw-r--r-- 1 root root 8596 Jan 9 14:43 scripts/db/mysql_populate.sql -rw-r--r-- 1 root root 1119 Jan 9 14:43 scripts/db/mysql_update-1.5-1.6.sql -rw-r--r-- 1 root root 610 Jan 9 14:43 =20 scripts/db/mysql_update-1.8.2h-1.8.2i.sql -rw-r--r-- 1 root root 983 Jan 9 14:43 =20 scripts/db/mysql_update-1.8.2k-2.0.0.sql -rw-r--r-- 1 root root 1050 Jan 16 11:02 =20 scripts/db/mysql_update-2.0.2-2.0.3.sql -rw-r--r-- 1 root root 9870 Jan 9 14:43 scripts/db/postgres_populate.sql -rw-r--r-- 1 root root 6852 Jan 9 14:43 scripts/db/sqlite_populate.sql # grep -i 'ip.*char' scripts/db/*sql scripts/db/mysql4.x_upgrade.sql:ALTER TABLE `response` ADD COLUMN ip CHAR(64= ); scripts/db/mysql_populate.sql: ip CHAR(64), scripts/db/mysql_update-1.5-1.6.sql:ALTER TABLE response ADD COLUMN =20 ip CHAR(64); # So... that tells me the ip column was added to the 1.5-1.6 file AFTER =20 releasing the 1.8.2 tarball on butterfat. bishop Quoting Franky Van Liedekerke <lie...@te...>: > Hi Bishop, > > this statement: > > ALTER TABLE response ADD COLUMN ip CHAR(64); > > was already in the mysql_update-1.5-1.6.sql file ... I wonder if your > install really was 1.8.2? > Or maybe the create script didn't include this column for 1.8.2 and > decided not to use it then, but I can't say that for sure, that's way > too long in the past for me and before I started changing it. It > somebody can confirm this, I'll add this line to the upgrade file. > > Franky > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > phpESP-devel mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpesp-devel > --=20 Bishop Bettini ideacode, Inc. (main) +1 919 341 5170 / (fax) +1 919 521 4100 Visit us on the web at: ideacode.com Professional software research and development reviewmysoftware.com Improve sales! Review your software before you release bytejar.com Solutions to those annoying development problems |