phpesp-devel

[phpesp-dev] Small Bug and Fix

[Matthew G. <gr...@mu...>]

In test.inc, current cvs, it looks like ['ESPCONFIG']['ME'] is not being 
restored correctly here:
$tmp = $ESPCONFIG['ME'];
$HTTP_SERVER_VARS['PHP_SELF'] = $ESPCONFIG['ME'].'?where=test';
include($ESPCONFIG['handler']);
/* restore stuff after the handler does it's job */
$ESPCONFIG['ME'] = $tmp;

Something strange happens to $tmp.  I tried renaming $tmp to $tmptest and 
it seemed to fix the problem.

To see this bug, test a survey and click on the "View Results" or the "Go 
back to Management Interface" link.

one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

Re: [phpesp-dev] Small Bug and Fix

[James E. F. <jf...@ac...>]

Doh! Yeah, I know what I did that broke that too. That
should teach me to use a variable called "tmp" in a global
scope. I wish PHP had block-level scoping. I just fixed it
in CVS. Files affected:
  phpESP/admin/phpESP.ini
  phpESP/admin/include/where/test.inc

Thanks for cathing that.
-James

On Wed, 27 Mar 2002, Matthew Gregg wrote:

> In test.inc, current cvs, it looks like ['ESPCONFIG']['ME'] is not being
> restored correctly here:
> $tmp = $ESPCONFIG['ME'];
> $HTTP_SERVER_VARS['PHP_SELF'] = $ESPCONFIG['ME'].'?where=test';
> include($ESPCONFIG['handler']);
> /* restore stuff after the handler does it's job */
> $ESPCONFIG['ME'] = $tmp;
>
> Something strange happens to $tmp.  I tried renaming $tmp to $tmptest and
> it seemed to fix the problem.
>
> To see this bug, test a survey and click on the "View Results" or the "Go
> back to Management Interface" link.

RE: [phpesp-dev] Small Bug and Fix

[Kon A. <an...@cp...>]

Matthew,

I've also reported the same thing to the devel list and suggested the same
fix.
James, have you had a chance to look at this yet?

Kon

> -----Original Message-----
> From: php...@li...
> [mailto:php...@li...]On Behalf Of Matthew
> Gregg
> Sent: Thursday, March 28, 2002 2:00 PM
> To: php...@li...
> Subject: [phpesp-dev] Small Bug and Fix
>
>
> In test.inc, current cvs, it looks like ['ESPCONFIG']['ME'] is not being
> restored correctly here:
> $tmp = $ESPCONFIG['ME'];
> $HTTP_SERVER_VARS['PHP_SELF'] = $ESPCONFIG['ME'].'?where=test';
> include($ESPCONFIG['handler']);
> /* restore stuff after the handler does it's job */
> $ESPCONFIG['ME'] = $tmp;
>
> Something strange happens to $tmp.  I tried renaming $tmp to $tmptest and
> it seemed to fix the problem.
>
> To see this bug, test a survey and click on the "View Results" or the "Go
> back to Management Interface" link.
>
> one of the friendly folks in the IT Lab.
> --------------------------------------\
> The IT Lab (http://www.itlab.musc.edu) \____________________
> Probably the world's premier software development center.
> Serving: Programming, Tools, Ice Cream, Seminars
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel
>