[phpesp-general] signup.php

[<br...@it...>]

Hi, somebody a work is using phpesp and ran into some problems with it asked me
to help out, I haven't done a lot of php before, so this is basically just a
solve the problem type of task for me, and not a solve the problem well.

The problem initially had to do with signup.php not having any display at all. 
Going through the code I changed the following things, considering them to be
errors (if they aren't errors please explain)

/* process form values */
  do if (isset($post['submit'])) .....

if there's a do shouldn't it be in the form of 
do{stuff I'm gonna do}while(while this remains true);

some of the various things getting concatenated seemed to have problems due to
line breaks. Maybe caused by zip file, windows text?  

and iirc(I'm at home now so I can't refer to original scripts) there was an
array_push on $sqlv that had an extra ) somewhere.

finally the if (isset($msg))
      break; seemed also to cause problems, I put the rest of the code into
that
if and got my display.

Note also that I set  $embed  to be false, although given my preferences I would
probably just remove $embed and the checks to see if it was false, and have the
markup without the check. Unless there is some other requirement for $embed that
I am unaware of. 

After which there were some problems as follows:

I managed to use signup at some points, receiving messages back that I was
signed up. However this was not a continuing success, I also failed a number of
times to signup using different usernames, people names etc.

Is there a cookie being set somewhere by the application as a whole that I am
unaware of? 

anyway I was wondering about the logic of if(isset($msg)) at that point in the
code, what is $msg supposed to be set as? or given that there is unset($msg);
earlier in the code, what is it supposed to unset from?

Sorry if I'm being annoying with the questions, but basically this is far from
being a requirement of any of our jobs, and as such it's difficult to give to it
all the time necessary to understand it well.