[phpesp-dev] [ phpesp-Bugs-1274102 ] No protection against activating an active survey

[SourceForge.net <no...@so...>]

Bugs item #1274102, was opened at 2005-08-26 17:14
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=1274102&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Admin
Group: v1.7
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jeff Bearer (jeffbearer)
Assigned to: Kon Angelopoulos (angek)
Summary: No protection against activating an active survey

Initial Comment:
If a user goes to the query string url that activates a
survey for a survey that is already active it purges
all of the response data.

This fix would be just to protect stupid people (like
me) from themselves.

This can happen easily by mistake like in my instance.
 I wanted to view the results so I started typing in
the url in firefox.  Ever Helpful Firefox populated the
url for me and I hit enter.  But this time firefox
choose the url to activate the survey, whoops.

A few lines of code that would keep you from accidently
activating already active survey's would keep people
from losing lots of data, like I had the unfortunate
experience of having.  Thankfully I have the email to
recreate the responses.



----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2007-11-27 14:16

Message:
Logged In: YES 
user_id=109671
Originator: NO

agreed and changed in CVS (also for some other states)

----------------------------------------------------------------------

Comment By: Leonard Chan (wotg)
Date: 2006-12-29 20:29

Message:
Logged In: YES 
user_id=645294
Originator: NO

I happened to look at this today. 

All that's needed is to change line 70 of the most recent status.inc file
in CVS (revision 1.24):
http://phpesp.cvs.sourceforge.net/phpesp/phpESP/admin/include/where/status.inc?revision=1.24&view=markup

From:
70: if($old_status & ( STATUS_DELETED | STATUS_DONE ) )

To:
70: if($old_status & ( STATUS_DELETED | STATUS_DONE | STATUS_ACTIVE) )

Sorry, I'm too lazy to learn how to make a proper diff.

----------------------------------------------------------------------

Comment By: Kon Angelopoulos (angek)
Date: 2005-08-30 02:47

Message:
Logged In: YES 
user_id=198398

I'll take a look at it in the next couple of days and see
what I can come up with.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=1274102&group_id=8956