Re: [phpesp-dev] CVS forking patch ?

[Matthew G. <gr...@mu...>]

You are correct...
I've been working on making the patch CVS'able, in my enormous amounts
of free time, for that very reason.  I had the patch as was submitted
by Kon working and appeared stable with a minimal amount of testing.
However, a large portion of the patch, relating to text for rate
questions, still needed to be "backed out".   I am currently working
on this.

I'll paste my TODO below:

- (fixed) in Questions tab, moving between questions, an extra
question "nav/button" bar is shown.
                                  
- (fixed) rename table ratetext to rate_text

- (fixed) copied survey's don't skip anymore. Looks like skips are
copied to the new survey before question_choices are, which skips
depend on.  So, the skips in the new survey point to question_choices
from the original.  In survey_copy.inc, it's the "precise" column not
getting updated to the new(copied). That column should match the new
intended_response variable.
                                                                              
- (fixed) missing an entry in question_type for skip questions.

- (fixed) question_choice table isn't properly purged when ?where=purge is issued.

- remove all instances of rate_text code.  Don't forget to remove
rate_text stuff from mysql update scripts. Should commit to SF CVS
at this point.

- move functions out of order.inc to where they should be

- more "style" cleanups

- test private surveys with a fork.

- even more testing.

On Sat, May 31, 2003 at 11:43:57AM +0200, Eric Bont wrote:
> Hi,
> 
> Maybe it's a good idea to place Kon's 'forking' patch to the CVS tree ?
> Then we can all try to test/bugfix it.
> 
> Eric
> 
> _________________________________________________________________
> MSN Zoeken, voor duidelijke zoekresultaten! http://search.msn.nl
> 
> 
> 
> This SF.net email is sponsored by: eBay
> Get office equipment for less on eBay!
> http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel
> 

-- 
mcg
-------------------------------------
The IT Lab (http://www.itlab.musc.edu)