Re: [phpesp-dev] Bulk upload patch

[Kon A. <ang...@ip...>]

Hey Matthew,

A job well done.
I've tested it again and it worked fine for me.
I'd be pushing it up to cvs.

Kon

On Sat, 20 Jul 2002 04:31, Matthew Gregg wrote:
> I've update the patch(see attached) so that it now does validation on
> email addresses and expiration dates.  It should also correctly set
> the defaults for "pdesign, pstatus, pdata, pall, pgroup, puser,
> disabled", if they aren't correctly specified in the uploaded data.
>
> I'd like to push this up to CVS if you guys feel comfortable enough
> with it.  James?
>
> ON Fri, Jul 19, 2002 at 08:35:47PM +1000, Kon Angelopoulos wrote:
> > Hey Matthew,
> >
> > If the required fields are taken care of then the basic requirements have
> > been met. There is one thing that needs to be taken care of and that is
> > with the single Add forms a default value is always entered into the
> > database table whereas the bulk upload facility will only enter info
> > found in the file. There's no capacity to prevent fields not specified in
> > the uploadfile from showing up as empty fields in the database.
> >
> > eg. If I use the designer add form and only enter values for the required
> > fields: username, password and group then when I click the update button
> > it will enter the username, password and group into the designer table
> > and enter the default values for pdesign,
> > pstatus,pdata,pall,pgroup,puser,disabled etc...
> >
> > If I created a designer file with only a username, password and group
> > then when I upload it, all other fields will be blank in the designer
> > table.
> >
> > Does this affect the functionality of phpESP? Probably Not. empty fields
> > should be interpreted as 'N'. I guess I'm a little fussy when it comes to
> > data stored in databases. I prefer that fields contain some default value
> > rather that being empty. It provides clarity and prevents
> > misinterpretation.
> >
> > In conclusion, I guess what ever the majority decide I'd be happy with.
> > James' thoughts on the subject would also be greatly appreciated.
> >
> > Kon
> >
> > On Thu, 18 Jul 2002 23:25, Matthew Gregg wrote:
> > > The only fields I set as required are the fields that are currently
> > > required in the single Respondent/Designer Add forms.
> > > Which are:
> > > Username, Password and Group.
> > >
> > > Whoops...I neglected to do any validation on the Expiration field, but
> > > it should at least validate as much as the single Add forms.  I'll fix
> > > that.
> > >
> > > As for the other fields, do we want to be more strict with validation
> > > than the single Add forms?
> > >
> > > And thanks again for taking the time to look at this stuff.  The more
> > > eyes the better.
> > >
> > > On Thu, Jul 18, 2002 at 10:08:07AM +1000, Kon Angelopoulos wrote:
> > > > Matthew,
> > > >
> > > > I've finished testing your patch and I've found the following bugs:
> > > > 1. Bulk Importing Respondent Details:
> > > > 	I tested this functionality with a correct list of respondents and
> > > > it worked well. I then changed the realm to a non existent one and as
> > > > expected, it displayed the table with the failed uploaded rows. I
> > > > then removed the email address from some of the respondents and it
> > > > accepted them without a problem. (should this be the case?). I them
> > > > also removed the disabled field from some of the respondents and it
> > > > also accepted them without reporting any errors ( i don't think that
> > > > this should be the case).
> > > > I then changed the formatting of the exipration date from
> > > > year/month/day to year/day/month. It accepted all these without any
> > > > errors ( placing 000000000 into the database). I don't think this
> > > > should happen.
> > > >
> > > > 2. Bulk upload of Designers:
> > > > 	I tested this with a correct list of designers and it worked well.
> > > > I then tried uploading the respondents tab delimited file in place of
> > > > the designers tab delimited file and it accepted it without any
> > > > errors. This
> > >
> > > ...snip...
> >
> > This sf.net email is sponsored by:ThinkGeek
> > Welcome to geek heaven.
> > http://thinkgeek.com/sf
> > _______________________________________________
> > phpESP-devel mailing list
> > php...@li...
> > https://lists.sourceforge.net/lists/listinfo/phpesp-devel