Re: [phpesp-dev] Bulk upload patch

[Kon A. <ang...@ip...>]

Matthew,

I've finished testing your patch and I've found the following bugs:
1. Bulk Importing Respondent Details:
	I tested this functionality with a correct list of respondents and it worked 
well. I then changed the realm to a non existent one and as expected, it 
displayed the table with the failed uploaded rows.
I then removed the email address from some of the respondents and it accepted 
them without a problem. (should this be the case?).
I them also removed the disabled field from some of the respondents and it 
also accepted them without reporting any errors ( i don't think that this 
should be the case).
I then changed the formatting of the exipration date from year/month/day to 
year/day/month. It accepted all these without any errors ( placing 000000000 
into the database). I don't think this should happen.

2. Bulk upload of Designers:
	I tested this with a correct list of designers and it worked well.
I then tried uploading the respondents tab delimited file in place of the 
designers tab delimited file and it accepted it without any errors. This 
meant that the fields: pdesign, pall, pgroup, puser etc were all blank in the 
database.

I guess we need to decide which fields are required and validate accordingly.

Hope this helps.
Let me know if I can be of any further assistance.

Kon


On Thu, 18 Jul 2002 09:27, Kon Angelopoulos wrote:
> Hey Matthew,
>
> 	Had a quick look at your patch and it looks really good.
> 	Excellent Job.
> 	I've just finished patching my version of phpESP and will start testing it
> asap.
> 	I'll get back to you soon.
>
>
> Kon
>
> On Thu, 18 Jul 2002 08:07, Matthew Gregg wrote:
> > Attached is a tar containing a patch that implements bulk uploading
> > of Respondent/Designer accounts and a readme that explains it's
> > usage/limitations
> >
> > Please try it out and report any bugs or general code lameness you
> > find.
> >
> > Thanks.