Re: [phpesp-dev] Re: phpESP Survey Themes

[Kon A. <ang...@ip...>]

Thanks for the feedback Matthew,

I'll take your suggestions on board and create a final release version.
How should this be deployed?
Should it be a patch release or shall we implement it through cvs?

Kon

On Fri, 14 Jun 2002 05:39, Matthew Gregg wrote:
> After looking at the patch more thoroughly, I only see one issue.
>
> Make sure the default(blank) theme looks as close as possible to
> the old unthemed surveys on 4/5/6/7 version browsers.  I noted some
> alignment problems with question numbers and question text, etc...
>
> Otherwise I think it looks good.
>
> On Mon, Jun 10, 2002 at 12:41:37PM +1000, Kon Angelopoulos wrote:
> > Thanks for the feedback Greg,
> >
> > All your points are worthwhile.
> > Let's wait a little while (say by the end of the week) to see if there
> > are no issues with the actual css stuff then it will be a quick fix to
> > change things to what you've suggested and release it officially.
> >
> >
> > Kon
> >
> > On Mon, 10 Jun 2002 12:28, Matthew Gregg wrote:
> > > I've only had time to take a quick look at the patch this weekend, but
> > > it looks darn good!  I'll do some deeper digging next week.
> > >
> > > What I've noticed so far:
> > > - "/css" should probably be "/public/css" by default
> > >
> > > - Maybe think about moving your CSS additions in phpESP.ini,
> > >   so that they will be grouped together with the other file/http
> > >   paths.
> > >
> > > - Maybe include the new files and directories in the patch instead of
> > >   of having to manually create/copy them/
> > >
> > > - When you build your patch make sure the phpESP.ini and the other
> > >   places paths are configured(manage.php, handler.php, etc..) are
> > >   unchanged from CVS, except for your new CSS additions of course.
> > >
> > > This is gonna be cool 8)
> > >
> > >
> > > On a side note...
> > > Since I sit on Open Projects(http://www.openprojects.net/)
> > > most all the time anyhow, I decided to register #phpesp and sit on
> > > that as well.  If anyone wants to drop by and talk about devel issues,
> > > a problem with phpESP, etc.  I'll be lurking.
> > >
> > > On Sat, Jun 08, 2002 at 05:37:50PM +1000, Kon Angelopoulos wrote:
> > > > Hi Guys,
> > > >
> > > > 	It's finally here.
> > > > 	Attached you should find a phpThemes.tar.gz file. This file contains
> > > > a directory called phpESP_addons which further contains the
> > > > following:
> > >
> > > ...Snip...
> > >
> > > > Kon