Re: [phpesp-dev] Patch for Auto-publishing

[Kon A. <ang...@ip...>]

Hi Guys,

Just downloaded the latest version to have a look at Matthews patch and was 
looking at the code for handler.php


     75         $action = $HTTP_SERVER_VARS['PHP_SELF'];
     76         if (!empty($HTTP_SERVER_VARS['QUERY_STRING']))
     77                 $action .= "?" . $HTTP_SERVER_VARS['QUERY_STRING'];

should line 77 read $action = "?" .$HTTP_SERVER_VARS['QUERY_STRING']; instead?

otherwise couldn't we  have the following scenario when, for example we test 
surveys?

..../.../manage.php?where=test&sid=xx - then clicking the submit button would 
generate:
../../manage.php?where=test?where=test&sid=xx


Regards


Kon



On Mon, 15 Apr 2002 05:05, James E. Flemer wrote:
> On Wed, 10 Apr 2002, Matthew Gregg wrote:
> > Attached is first run at a patch to allow publishing of surveys
> > without needing to manually create a php "include" file.
>
> I made a few slight changes, nothing effecting use, and
> committed this patch. Thanks.
>
> > Take a look in handler-prefix.php where the remote user id is found.
> > I commented the QUERY_STRING case because it would grab the
> > query string for survey selection every time.   Can we live without
> > that case?
>
> I changed this so that survey.php removes "name=xxx" from
> the query string, so no mods to handler-prefix were needed.
>
> Thanks for the patch.
>
> -James
>
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel