RE: [phpesp-dev] Re: Re: Export Download

[Matthew G. <gr...@mu...>]

Comments below...
>
> I've tested your patch (on windows box using IE and Netscape plus on
> Linux box using Netscape and Konqueror) and it looks pretty good.
> The only minor issue I found was with Konqueror. It was not capable of
> displaying the $filename.csv name in the save as dialog box but rather
> It showed the file name "manage.php". It's contents however were that of
> the csv file.
>
I'm running Konq. 2.2.2 and other than "'s around the filename, it worked 
just fine.  I'll fix the " problem.


> I've also had a quick look at the code and it also seems very good.
>
> I do however have a few suggestions:
> 	I don't believe that the download cvs facility should be
> replacing the exporting of the cvs file to the /tmp dir (or any other
> dir) but
> complement it. By this I mean that the saving of the csv file to a dir
> on the server should also occur when the csv file is being downloaded.
> I can think of quite a few scenarios where a central repository of
> result files might come in very handy.
Ok will do this.


> 	I also don't think that a survey with no results should be
> downloadable. If a survey has no results it should return an error
> statement
> as the current phpesp version does.
Whoops... yeah will fix this.


> 	My final comment is a challenge. Assuming that others feel the
> same way as I with regard to leaving a copy of the csv file on the
> server
> I'd like to see this process check to see if the csv file exists and if
> it does, not to overwrite it - as is the current case- but rather check
> the files size
How about this...
Always create a new file and append the current date or date/time to the 
filename then do the export.





one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars