RE: [phpesp-dev] Re: Re: Export Download

[angek p. <ang...@ip...>]

Matthew,

I've also sent this email to the list so that others may contribute
their thoughts.

I've tested your patch (on windows box using IE and Netscape plus on
Linux box using Netscape and Konqueror) and it looks pretty good.
The only minor issue I found was with Konqueror. It was not capable of
displaying the $filename.csv name in the save as dialog box but rather
It showed the file name "manage.php". It's contents however were that of
the csv file.

I've also had a quick look at the code and it also seems very good.

I do however have a few suggestions:
	I don't believe that the download cvs facility should be
replacing the exporting of the cvs file to the /tmp dir (or any other
dir) but
complement it. By this I mean that the saving of the csv file to a dir
on the server should also occur when the csv file is being downloaded.
I can think of quite a few scenarios where a central repository of
result files might come in very handy.
	I also don't think that a survey with no results should be
downloadable. If a survey has no results it should return an error
statement
as the current phpesp version does.
	My final comment is a challenge. Assuming that others feel the
same way as I with regard to leaving a copy of the csv file on the
server
I'd like to see this process check to see if the csv file exists and if
it does, not to overwrite it - as is the current case- but rather check
the files size
And if different create another copy of it with the current date
appended to the end of the filename (or any other way where the csv
files from a particular
Survey can be distinquished from one another).
	So for example, assume that many of the surveys I create for my
company run for a year.
Each quarter the results are downloaded and analysed / compared to the
previous
Quarter's results. In this instance I would have 4 csv files on the
server belonging to the same survey named quartely_survey_310302,
quartely_survey_300602,
Quartely_survey_300902 and quartely_survey_311202.

Guys your thoughts please.


Kon

-----Original Message-----
From: Matthew Gregg [mailto:gr...@co...] On Behalf Of
Matthew Gregg
Sent: Tuesday, 26 March 2002 2:34 PM
To: Kon Angelopoulos
Subject: Re: [phpesp-dev] Re: Re: Export Download


Strange, just guessing but...
It's a UNIX text file.  Are you on Windows?  Could be line ending
differences.

I converted it to DOS line endings and attached it again.

On Tue, Mar 26, 2002 at 01:42:45PM +1100, Kon Angelopoulos wrote:
> Thanks Matthew,
> 
> When I viewed it, it was literally all over the place.
> 
> Talk soon
> 
> Kon Angelopoulos
> Emerging Technologies Developer, Education
> Spherion Group Ltd.


-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________ Probably
the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars