Re: [phpesp-general] errors in my public/handler

[Franky V. L. <lie...@te...>]

On Fri, 26 Mar 2010 21:00:14 -0000
"Nick Coleman" <ni...@ni...> wrote:

> Hi, I appear to have created some bugs:
> 
> I have updated phpESP to the latest version but, 
> 
> 1.Survey form has two error notices at top: there are undefined
> variables in /public/handler, lines 465,466.
> <input type="hidden" name="referer" value="" />
> <input type="hidden" name="direct"  value="" />
> 
> 2. I have filled in box on General page for email notification, but
> am not getting any. 
> 
> 3. on submitting, get Thanks page of errors, all on line 386
> Notice: Undefined offset: 3 in
> /home/bridlew1/public_html/survey/public/handler.php on line 386
> Notice: Undefined offset: 4 in
> /home/bridlew1/public_html/survey/public/handler.php on line 386
> And these two lines repeat themselves all the way down the page.
> Return
> 
> Thanks for helping
> Nick

Hi,

it seems you have your error level in php.ini way too high. Remember
that showing php notices to the public is a security risk, showing eg.
the path to the script (as in your case). The recommended settings in
php.ini are:

display_errors = Off
log_errors = On

I added a check in admin/test.php for the display_errors variable.
But anyway, these php notices (which are NOT errors btw) should not
occur. I've uploaded a new version of public/handler.php to svn. For the
differences:
http://phpesp.svn.sourceforge.net/viewvc/phpesp/trunk/phpESP/public/handler.php?r1=1147&r2=1144

About the mail: check your maillogs for errors, maybe they get blocked.
Make sure the php mail() function works. Maybe I'll add the option to
directly contact a smtp server via php mail(), but for now you'll need
to check/correct your php.ini file for that (on unix it works via
sendmail, on windows it uses a specified smtp server). And also check
the values of:

$ESPCONFIG['email_from_address']
$ESPCONFIG['email_return_path']

it might be they are incorrect and your mailserver blocks the mails
because of this.

Franky