[phpesp-dev] [ phpesp-Feature Requests-2933959 ] duplicate survey name

[SourceForge.net <no...@so...>]

Feature Requests item #2933959, was opened at 2010-01-17 21:32
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2933959&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Gurdeep Singh (gurdeep22)
Assigned to: Nobody/Anonymous (nobody)
Summary: duplicate survey name 

Initial Comment:
multiple surveys cannot be created with a single name. > Now if multiple users  access the tool then it is hard to create a new survey everytime with a unique name.   It is an important usability aspect and it require solution. 

Possible solution:  If  survey ID is appended to the newly created survey name automatically than it will give you a unique survey name itself. 
or username can also be appended to keep the survey name unique. 

----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2010-01-18 10:18

Message:
Hi Bishop,

the thing is that people can access a survey by doing "?name=SURVEYNAME"
in the URL, therefore the survey name needs to be unique. It was like this
before I took over the project, so I didn't want to break that
functionality. So for now the name needs to be always unique.
But it shouldn't impact existing surveys in any way, only surveys that you
can edit are impacted, and these are never online. Could you give an
example of such a use case?

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2010-01-18 01:14

Message:
Automatically adding a number, in all cases, will probably break some
existing use cases.  Perhaps:

1. Make this a configuration option: "Do you want to generate a unique
survey name if creating a new one with an existing name?"  Boolean. 
Default = No.
2. If so configured, atomically test for existence and, if already exists,
append the survey ID as in the patch.  If not so configured, fail.

This would keep existing behavior while allowing the new functionality.

Of course, survey ID is already unique, so having the survey name act as a
natural key is redundant.  Moving into the next major version, we might
want to consider whether we need both the surrogate ID and the natural name
keys.

----------------------------------------------------------------------

Comment By: Gurdeep Singh (gurdeep22)
Date: 2010-01-17 22:57

Message:
Yeah its working. i just checked it , it prepends the survey id to the
survey name and  thus generating unique name every time. 

But  survey Id get prepends to every survey name and not only to those
that have duplicate name . 

 this is a good solution for me. I can move ahead now. 

Thank You very much. 

Gurdeep

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2010-01-17 22:31

Message:
Ok, I made some changed to admin/include/function/survey_update.inc that
prepends the survey ID if not present, and readding it every time it gets
removed, so the chance of getting a double name is next to zero now. Try
out the updated version (see attachment in this feature request) and see if
it solves the problem for you. If it does, I'll include it in the code with
an extra line explaining where the ID comes from.
Unless some other people don't agree with this?
I didn't want to do it based on the username or userID because that would
disclose user information to the outside world, not a wanted effect.

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2933959&group_id=8956