[phpesp-dev] [ phpesp-Bugs-2119492 ] open/close date not quoted when saved, causing db save fail

[SourceForge.net <no...@so...>]

Bugs item #2119492, was opened at 2008-09-19 11:16
Message generated for change (Settings changed) made by bishopb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2119492&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Admin
Group: None
Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: bishop (bishopb)
>Summary: open/close date not quoted when saved, causing db save fail

Initial Comment:
The opening and closing date are not allowed to left empty. (At least my mysql did not accept an empty string).  I changed some code in \admin\include\function\survey_update.inc to handle this. 

At the moment it's not clear how to enter the opening and closing dates. Maybe it's nice to have a calendar interface for these dates.

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2009-04-13 13:09

Message:
This isn't a bug, at least insofar as the survey_update.inc provided
doesn't include the open_date and close_date fields in the $files array on
line 41.  Because those fields are absent, they are not quoted.  Because
they are not quoted, your database complains.

When these fields are included (as they are in trunk and should be in all
versions post 2.1.1) in the $fields array, they are properly quoted and
your submitted patch is not necessary.

So, thank you for submitting this patch, but I do not think the issue is
valid; just get the latest survey_update.inc from trunk and use that.

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2008-09-25 10:02

Message:
What versions of MySQL and PHPESP are you running?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2119492&group_id=8956