From: Franky V. L. <lie...@te...> - 2008-06-19 21:29:52
|
A patch for this isn't too difficult, but to resolve the issue once and for all for all databases and reserved words, I would suggest a complete rename of all columns ... eg. using a prefix or so Franky On Thu, 19 Jun 2008 12:43:19 -0700 "Joel Penner (Volt)" <a-j...@mi...> wrote: > I doubt you would like it to be "icanhaspublic", I'm thinking of > something like "ispublic" > > -----Original Message----- > From: php...@li... > [mailto:php...@li...] On Behalf Of > Matthew Gregg Sent: Wednesday, June 18, 2008 5:56 PM To: > php...@li... Subject: Re: [phpesp-dev] mssql > support > > I wouldn't be against a proper patch that made the change. > > On Wed, 2008-06-18 at 15:43 -0700, Joel Penner (Volt) wrote: > > I’m looking into helping the project’s mssql (sql server) support > > and found that the adodb data dictionary doesn’t quote reserved > > words. What’s the chances of changing a field name for better > > database compatibility? > > > > > > > > CREATE TABLE phpesp_question ( > > > > id INT IDENTITY(1,1) NOT NULL, > > > > survey_id INT NOT NULL, > > > > name VARCHAR(30) NOT NULL, > > > > type_id INT NOT NULL, > > > > result_id INT NULL, > > > > length INT DEFAULT 0 NOT NULL, > > > > precise INT DEFAULT 0 NOT NULL, > > > > position INT NOT NULL, > > > > content TEXT NULL, > > > > required VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > deleted VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > public VARCHAR(1) DEFAULT 'Y' NOT NULL, > > > > ans_uniq VARCHAR(1) DEFAULT 'N' NOT NULL, > > > > PRIMARY KEY (id) > > > > ) > > > > > > > > > > > > SQLState: 42000 Error Code: 156 Message: [Microsoft][SQL Native > > Client][SQL Server]Incorrect syntax near the keyword 'public'. > > > > > > > > > > > > Joel Penner > > > > Volt > > > > Microsoft Open Source Software Lab > > > > |