From: Bishop B. <ph...@id...> - 2008-01-13 00:32:22
|
All, Attached are my finalized patches to support collecting, viewing, and =20 managing per-survey statistics in phpESP. Since the patch I sent last =20 night I: * initialized statistics at survey creation time * purged statistics at survey purge time * tightened the security on the view statistics page, so that you only =20 see statistics for your active & done surveys * added the help documentation, and linked to it * added the language catalog msgid values * added a new statistic -- attempted -- which represents the total =20 number of attempts, regardless of outcome (abandon, suspend, commit) * added a statistics view refresh button on management page * consolidated some code (see admin/include/lib/espsurvey.inc) * cleaned up code with some abnormal spacing There are three patches in the the attached tgz (tar'd & gzip'd to get =20 through the 40k list wall). Please patch in 1, 2, 3 order. These =20 should patch cleanly against 2.0.2. Please let me know if this patch =20 is acceptable or not -- if not, what do I need to change? Also, I added one hopefully handy method. This: esp_require_once('/lib/espcross'); Replaces this: require_once($ESPCONFIG['include_path']."/lib/espcross".$ESPCONFIG['extensio= n']); bishop PS: I didn't see an official coding standard, so I tried to stick with =20 the coding style of files I was modifying, but I used our (ideacode) =20 standard style for new files. The style seen throughout much of the =20 code is very similar to our standard, but ours just seems to be more =20 formalized. You shouldn't see anything weird. FYI, our standard is =20 documented at: https://mail.ideacode.com/wicked/display.php?page=3DCodingStandard PPS: If anyone is bored, there are todo items listed in =20 admin/include/where/statistic.inc :) --=20 Bishop Bettini ideacode, Inc. (main) +1 919 341 5170 / (fax) +1 919 521 4100 Visit us on the web at: ideacode.com Professional software research and development reviewmysoftware.com Improve sales! Review your software before you release bytejar.com Solutions to those annoying development problems |