Re: [Phpeselgui-developer] Patch to easy download

[Sven W. <eM...@Sv...>]

OK, i think this search is good enough to go into CVS, but it isn't 
finished.

Some issues i found:
- Something has crashed the output of the status (first letter is missing)
- The view result button should work ;-)
- I would be glad to have some more informations in the results list (so 
i can see, that an AVI with 12 KB won't be the correct one...)
- every "TEST" is a thing i want(ed) to build later (as seen, when no 
search is done...)
- Localizer-entries
- and c) of Roman's wishes

And, of course, the buildListTable has to be put in functions.inc...

Good work so far :-)

P.S. wanted one, too
P.P.S. Have a look at the new codingConventions.txt in the Repository...

Roman Kreisel schrieb:
>>Thanks Manu, for submitting your work. I'll create a patch-file against
>>the current cvs-version and post it to this list, tomorrow (quite late
>>now ;]), then the others (and me of course, too) will test it for a day
>>or two and if it works fine and the code is usable (the others have to
>>rate this, since my php-knowledges are very bad 'till now), i'm going to
>>upload it to cvs
> 
> 
> Well, as promised i just build the patch-file, so here it comes
> 
> 
> It can be applied against the current CVS-Version (status: February 15th 2003/ 2:20PM CET) without problems.
> 
> I already had a short look on it: 
> a) it works!
> b) you have to click on the searched terms instead of the button "view result"
> c) Could we maybe put all the files with the same MD4SUM in 1 result and display in a new row, how often it was found? And then sort it the way how many sources are available for this file (== how often it was found)
> 
> Well anyway, all developers: Have a look at it! ;)
> 
> regards
> Roman
> 
> P.S.: To apply the patch, copy your CVS-Directory and change to the new directory, then execute:
> patch -p1 < /path/to/search-patch.diff
> 
> P.P.S.: If you want to have a look at the changes only, not the whole phpEselGui-Code, open the search-patch.diff file with your favorite text-editor
> 
> P.P.P.S.: I just wanted a P.P.P.S. here ;)
> 
> P.P.P.P.S.: Ok, i'll stop this for now ;)
> 
> 
>