I use plus-tagged addresses (user+tag@example.com) when registering for sites so I tend to get bitten by simple email validation routines that don't accept '+'.
It's usually easy to fix - in the case of phpDiplomacy, I added a third-party function and changed two lines in objects/security.php, tested it and posted a patch.
This may interfere with limiting the number of concurrent games someone can play in (someone can register with user+a, user+b, user+c, etc. You'll have to balance that against the benefits of accepting more legal email addresses.
hth,
-- Bob
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I have integrated your change into the CVS tree, but I can't remember if I've synced with phpdiplomacy.net. Either way it'll be up there in the next sync.
Thanks,
Kestas
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I use plus-tagged addresses (user+tag@example.com) when registering for sites so I tend to get bitten by simple email validation routines that don't accept '+'.
It's usually easy to fix - in the case of phpDiplomacy, I added a third-party function and changed two lines in objects/security.php, tested it and posted a patch.
This may interfere with limiting the number of concurrent games someone can play in (someone can register with user+a, user+b, user+c, etc. You'll have to balance that against the benefits of accepting more legal email addresses.
hth,
-- Bob
Thank you for this patch, I didn't realize you could have + characters in e-mail addresses. I'll include it in the next release.
Regards,
Kestas
I have integrated your change into the CVS tree, but I can't remember if I've synced with phpdiplomacy.net. Either way it'll be up there in the next sync.
Thanks,
Kestas