phpbt-dev — Developer's mailing list and cvs commits

Re: [phpBT-dev] CVS: phpbt include.php,1.89,1.90

[Javier S. <js...@si...>]

OK =2E=2E=2Ei have enable TAB char on this poor editor, and it works fine no=
w ;-)

Javier Sixto wrote:

> Anybody know why this diff is not correct, i have just changed a few sql=
=20
> words !
> on ViewCVS diffs are ok :
> http://cvs=2Esourceforge=2Enet/cgi-bin/viewcvs=2Ecgi/phpbt/phpbt/include=
=2Ephp=2Ediff?r1=3D1=2E89&r2=3D1=2E90=20
>=20
> is that because of my poor editor ?


--=20
Javier
-----------------------
Javier SIXTO
Sismoplay (http://www=2Esismoplay=2Ecom)
83 rue Mass=E9na
69003 Lyon France
Voice:+33 4 72 83 75 11
Fax:+33 4 72 83 75 12
Mail: jsixto@sismoplay=2Ecom
--------------------------

[phpBT-dev] CVS: phpbt report.php,1.17,1.18

[Javier S. <ja...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv30195

Modified Files:
	report.php 
Log Message:
css problems 

Index: report.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/report.php,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- report.php	2001/11/13 03:53:04	1.17
+++ report.php	2002/01/16 11:12:33	1.18
@@ -20,6 +20,7 @@
 // along with phpBugTracker; if not, write to the Free Software Foundation,
 // Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 // ------------------------------------------------------------------------
+// $Id$  
 
 include 'include.php';
 
@@ -76,9 +77,12 @@
 					));
 				$t->parse('cols', 'col', true);
 			}
-			$t->set_var('bgcolor', (++$i % 2 == 0) ? '#dddddd' : '#ffffff');
+			$t->set_var('trclass', $i % 2 ? 'alt' : '');
+			$i++;
 			$t->parse('rows', 'row', true);
 			$t->set_var('cols', '');
+			//for header default
+			$t->set_var('trclass','alt');
 		}
 	}
 }

[phpBT-dev] CVS: phpbt/templates/default report.html,1.3,1.4

[Javier S. <ja...@us...>]

Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv30127

Modified Files:
	report.html 
Log Message:
css problems 

Index: report.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/report.html,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- report.html	2001/08/04 03:38:58	1.3
+++ report.html	2002/01/16 11:12:16	1.4
@@ -15,7 +15,7 @@
 <h3>{reporttitle}</h3>
 <table border="0" cellpadding="4">
 	<!-- BEGIN row -->
-	<tr bgcolor="{bgcolor}">
+	<tr class="{trclass}">
 		<!-- BEGIN col -->
 		<td class="{colclass}">
 			{coldata}

[phpBT-dev] about header("Location: blah");

[Alessandro P. (T. / J578) <al...@ti...>]

As I experienced in the project I'm mainly working on (phpWebSite), the
header("Location: blah"); directive is not understood fine by some
version of M$ Internet Exploder (should be: IE 5.x and 6). I suggest
this solution (this is what we used):

create a function:

function html_header_location($url) {
 $agent = (phpversion() > "4.1.0") ? $_SERVER[HTTP_USER_AGENT] :
$HTTP_SERVER_VARS[HTTP_USER_AGENT];

 if (stristr($agent, 'msie'))
  Header("Refresh: 0;url=$url");
 else
  Header("Location: $url");
 }

then replace all calls to header("Location: blah") with
html_header_location("blah");

HTH
Bye,
Alessadro

-- 
Alessandro "TXM" Pisani - al...@ti... - ICQ #2209087
phpWebSite Development Team http://phpwebsite.appstate.edu
INWO Project coordinator http://inwoproject.sourceforge.net

"I will carry you through, hicking and screaming,
 and in the end you will thank me"
 - Tyler Durden [from "Fight Club"]

Re: [phpBT-dev] CVS: phpbt include.php,1.89,1.90

[Javier S. <js...@si...>]

Anybody know why this diff is not correct, i have just changed a few sql=20
words !
on ViewCVS diffs are ok :
http://cvs=2Esourceforge=2Enet/cgi-bin/viewcvs=2Ecgi/phpbt/phpbt/include=2Ep=
hp=2Ediff?r1=3D1=2E89&r2=3D1=2E90
is that because of my poor editor ?


Javier Sixto wrote:

> Update of /cvsroot/phpbt/phpbt
> In directory usw-pr-cvs1:/tmp/cvs-serv7681
>=20
> Modified Files:
> 	include=2Ephp=20
> Log Message:
> Lastest version must be selected by default
>=20
> Index: include=2Ephp
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/phpbt/phpbt/include=2Ephp,v
> retrieving revision 1=2E89
> retrieving revision 1=2E90
> diff -u -r1=2E89 -r1=2E90
> --- include=2Ephp	2002/01/05 20:34:50	1=2E89
> +++ include=2Ephp	2002/01/16 09:43:17	1=2E90
> @@ -24,23 +24,23 @@
> =20
>  // Where are we?
>  if (!empty($HTTP_SERVER_VARS['SCRIPT_FILENAME'])) {
> -	define ('INSTALL_PATH', dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']));
> +  define ('INSTALL_PATH', dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']));
>  } else {
> -	define ('INSTALL_PATH', '=2E');
> +  define ('INSTALL_PATH', '=2E');
>  }
> =20
>  // Handle being included from admin files
>  if (!defined('INCLUDE_PATH')) {
> -	define('INCLUDE_PATH', '');
 =2E=2E=2E=2E


--=20
Javier
-----------------------
Javier SIXTO
Sismoplay (http://www=2Esismoplay=2Ecom)
83 rue Mass=E9na
69003 Lyon France
Voice:+33 4 72 83 75 11
Fax:+33 4 72 83 75 12
Mail: jsixto@sismoplay=2Ecom
--------------------------

[phpBT-dev] CVS: phpbt include.php,1.89,1.90

[Javier S. <ja...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv7681

Modified Files:
	include.php 
Log Message:
Lastest version must be selected by default

Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.89
retrieving revision 1.90
diff -u -r1.89 -r1.90
--- include.php	2002/01/05 20:34:50	1.89
+++ include.php	2002/01/16 09:43:17	1.90
@@ -24,23 +24,23 @@
 
 // Where are we?
 if (!empty($HTTP_SERVER_VARS['SCRIPT_FILENAME'])) {
-	define ('INSTALL_PATH', dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']));
+  define ('INSTALL_PATH', dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']));
 } else {
-	define ('INSTALL_PATH', '.');
+  define ('INSTALL_PATH', '.');
 }
 
 // Handle being included from admin files
 if (!defined('INCLUDE_PATH')) {
-	define('INCLUDE_PATH', '');
+  define('INCLUDE_PATH', '');
 }
 
 if (!@include (INSTALL_PATH.'/'.INCLUDE_PATH.'config.php')) {
-	header("Location: install.php");
-	exit();
+  header("Location: install.php");
+  exit();
 }
 if (!defined('DB_HOST')) { // Installation hasn't been completed
-	header("Location: install.php");
-	exit();
+  header("Location: install.php");
+  exit();
 }
 
 class dbclass extends DB_Sql {
@@ -49,33 +49,33 @@
   var $Database = DB_DATABASE;
   var $User = DB_USER;
   var $Password = DB_PASSWORD;
-	var $Seq_Table = TBL_DB_SEQUENCE;
-  var $Seq_ID_Col    = "nextid";    
-  var $Seq_Name_Col  = "seq_name";  
-	
-	// Attempt to handle different limit syntax
-	function limit_query($q_string, $limit, $offset = 0) {
-		if ($offset) {
-			if (DB_TYPE == 'pgsql') {
-				$this->query("$q_string limit $limit offset $offset");
-			} else {
-				$this->query("$q_string limit $offset, $limit");
-			}
-		} else {
-			$this->query("$q_string limit $limit");
-		}
-	}		
-
-	// Handle the different types of concats
-	function concat() {
-		$pieces = func_get_args();
-		if (DB_TYPE == 'pgsql') {
-			return delimit_list(' || ', $pieces);
-		} else {
-			return 'concat('. delimit_list(', ', $pieces).')';
-		}
-	}
-	
+  var $Seq_Table = TBL_DB_SEQUENCE;
+  var $Seq_ID_Col    = "nextid";
+  var $Seq_Name_Col  = "seq_name";
+
+  // Attempt to handle different limit syntax
+  function limit_query($q_string, $limit, $offset = 0) {
+    if ($offset) {
+      if (DB_TYPE == 'pgsql') {
+        $this->query("$q_string limit $limit offset $offset");
+      } else {
+        $this->query("$q_string limit $offset, $limit");
+      }
+    } else {
+      $this->query("$q_string limit $limit");
+    }
+  }
+
+  // Handle the different types of concats
+  function concat() {
+    $pieces = func_get_args();
+    if (DB_TYPE == 'pgsql') {
+      return delimit_list(' || ', $pieces);
+    } else {
+      return 'concat('. delimit_list(', ', $pieces).')';
+    }
+  }
+
   function grab($q_string = '') {
     if ($q_string) $this->query($q_string);
     $this->next_record();
@@ -85,34 +85,34 @@
   function grab_field($q_string = '') {
     list($retval) = $this->grab($q_string);
     return $retval;
+  }
+
+  function grab_set($q_string = '') {
+    $retary = array();
+    if ($q_string) $this->query($q_string);
+    while ($row = $this->grab()) { $retary[] = $row; }
+    return $retary;
   }
-	
-	function grab_set($q_string = '') {
-		$retary = array();
-		if ($q_string) $this->query($q_string);
-		while ($row = $this->grab()) { $retary[] = $row; }
-		return $retary;
-	}
-
-	function grab_field_set($q_string = '') {
-		$retary = array();
-		if ($q_string) $this->query($q_string);
-		while ($item = $this->grab_field()) { $retary[] = $item; }
-		return $retary;
-	}
-	function nextid($seq_name) {
-		global $auth;
-		
-		if ($seq_name == TBL_SAVED_QUERY) {
-			if ($id = $this->grab_field("select max(saved_query_id)+1 from ".TBL_SAVED_QUERY." where user_id = ".$auth->auth['uid'])) {
-				return $id;
-			} else {
-				return 1;
-			}
-		} else {
-			return DB_Sql::nextid($seq_name);
-		}
-	}
+
+  function grab_field_set($q_string = '') {
+    $retary = array();
+    if ($q_string) $this->query($q_string);
+    while ($item = $this->grab_field()) { $retary[] = $item; }
+    return $retary;
+  }
+  function nextid($seq_name) {
+    global $auth;
+
+    if ($seq_name == TBL_SAVED_QUERY) {
+      if ($id = $this->grab_field("select max(saved_query_id)+1 from ".TBL_SAVED_QUERY." where user_id = ".$auth->auth['uid'])) {
+        return $id;
+      } else {
+        return 1;
+      }
+    } else {
+      return DB_Sql::nextid($seq_name);
+    }
+  }
 }
 
 $q = new dbclass;
@@ -124,7 +124,7 @@
 // Set up the configuration variables
 $q->query('select varname, varvalue from '.TBL_CONFIGURATION);
 while (list($k, $v) = $q->grab()) {
-	define($k, $v);
+  define($k, $v);
 }
 
 // Localization - include the file with the desired language
@@ -172,11 +172,11 @@
     $this->set_block('wrap', 'adminnavblock', 'anblock');
     if ($u) {
       list($owner_open, $owner_closed) = $q->grab("SELECT sum(CASE WHEN status_name in ('Unconfirmed','New','Assigned','Reopened') THEN 1 ELSE 0 END ) ,"
-				."sum(CASE WHEN status_name not in ('Unconfirmed','New','Assigned','Reopened') THEN 1 ELSE 0 END )"
-				."from ".TBL_BUG." b left join ".TBL_STATUS." s using(status_id) where assigned_to = $u");
+        ."sum(CASE WHEN status_name not in ('Unconfirmed','New','Assigned','Reopened') THEN 1 ELSE 0 END )"
+        ."from ".TBL_BUG." b left join ".TBL_STATUS." s using(status_id) where assigned_to = $u");
       list($reporter_open, $reporter_closed) = $q->grab("SELECT sum(CASE WHEN status_name in ('Unconfirmed','New','Assigned','Reopened') THEN 1 ELSE 0 END ) ,"
-				."sum(CASE WHEN status_name not in ('Unconfirmed','New','Assigned','Reopened') THEN 1 ELSE 0 END )"
-				."from ".TBL_BUG." b left join ".TBL_STATUS." s using(status_id) where created_by = $u");
+        ."sum(CASE WHEN status_name not in ('Unconfirmed','New','Assigned','Reopened') THEN 1 ELSE 0 END )"
+        ."from ".TBL_BUG." b left join ".TBL_STATUS." s using(status_id) where created_by = $u");
       $this->set_var(array(
         'loggedinas' => $auth->auth['uname'],
         'liblock' => '',
@@ -190,7 +190,7 @@
       $this->set_var(array(
         'loggedinas' => '',
         'loblock' => '',
-				'loginlabel' => EMAIL_IS_LOGIN ? 'Email' : 'Login'
+        'loginlabel' => EMAIL_IS_LOGIN ? 'Email' : 'Login'
         ));
       $this->parse('liblock', 'loginblock', true);
     }
@@ -205,9 +205,9 @@
 }
 
 if (INCLUDE_PATH == '../') {
-	$t = new templateclass(INCLUDE_PATH.'templates/'.THEME.'/admin', 'keep');
+  $t = new templateclass(INCLUDE_PATH.'templates/'.THEME.'/admin', 'keep');
 } else {
-	$t = new templateclass('templates/'.THEME.'/', 'keep');
+  $t = new templateclass('templates/'.THEME.'/', 'keep');
 }
 
 $t->set_var(array(
@@ -216,7 +216,7 @@
   'me2' => $me2,
   'error' => '',
   'loginerror' => '',
-	'template_path' => INCLUDE_PATH.'templates/'.THEME));
+  'template_path' => INCLUDE_PATH.'templates/'.THEME));
 
 // End classes -- Begin helper functions
 
@@ -255,35 +255,35 @@
   );
 
   $text = '';
-	if (isset($cfgDatabase[$box])) {
-  	$querystart = "select {$box}_id, {$box}_name from $cfgDatabase[$box]";
-  	$queries = array(
-    	'group' => $querystart.' where group_name <> \'User\' order by group_name',
-    	'severity' => $querystart.' where sort_order > 0 order by sort_order',
-    	'status' => $querystart.' where sort_order > 0 order by sort_order',
-    	'resolution' => $querystart.' where sort_order > 0 order by sort_order',
-    	'project' => $perm->have_perm('Admin') 
-				? $querystart." where active > 0 order by {$box}_name"
-				: "select p.{$box}_id, {$box}_name from $cfgDatabase[$box] p left join ".
-					TBL_PROJECT_GROUP.' pg using(project_id) where active > 0 
-					and (pg.project_id is null or pg.group_id in ('.
-					delimit_list(',', $auth->auth['group_ids']).')) group by 
-					p.project_id, p.project_name order by project_name',
-    	'component' => $querystart." where project_id = $project order by {$box}_name",
-    	'version' => $querystart." where project_id = $project order by {$box}_name"
-    	);
-	}
+  if (isset($cfgDatabase[$box])) {
+    $querystart = "select {$box}_id, {$box}_name from $cfgDatabase[$box]";
+    $queries = array(
+      'group' => $querystart.' where group_name <> \'User\' order by group_name',
+      'severity' => $querystart.' where sort_order > 0 order by sort_order',
+      'status' => $querystart.' where sort_order > 0 order by sort_order',
+      'resolution' => $querystart.' where sort_order > 0 order by sort_order',
+      'project' => $perm->have_perm('Admin')
+        ? $querystart." where active > 0 order by {$box}_name"
+        : "select p.{$box}_id, {$box}_name from $cfgDatabase[$box] p left join ".
+          TBL_PROJECT_GROUP.' pg using(project_id) where active > 0
+          and (pg.project_id is null or pg.group_id in ('.
+          delimit_list(',', $auth->auth['group_ids']).')) group by
+          p.project_id, p.project_name order by project_name',
+      'component' => $querystart." where project_id = $project order by {$box}_name",
+      'version' => $querystart." where project_id = $project order by {$box}_id desc"
+      );
+  }
 
   switch($box) {
     case 'group' :
-			if ($project) { // If we are building for project admin page
-				if (!count($value) or (count($value) && in_array(0, $value))) {
-					$sel = ' selected';
-				} else {
-					$sel = '';
-				}
-				$text = "<option value=\"all\"$sel>All Groups</option>";
-			}
+      if ($project) { // If we are building for project admin page
+        if (!count($value) or (count($value) && in_array(0, $value))) {
+          $sel = ' selected';
+        } else {
+          $sel = '';
+        }
+        $text = "<option value=\"all\"$sel>All Groups</option>";
+      }
       $q->query($queries[$box]);
       while ($row = $q->grab()) {
         if (count($value) && in_array($row[$box.'_id'], $value)) $sel = ' selected';
@@ -325,48 +325,48 @@
         $text .= "<option value=\"{$row['user_id']}\"$sel>{$row['login']}</option>";
       }
       break;
-		case 'bug_cc' :
-			$q->query('select b.user_id, login from '.TBL_BUG_CC.' b left join '.
-				TBL_AUTH_USER." using(user_id) where bug_id = $value");
-			while (list($uid, $user) = $q->grab()) {
-				$text .= "<option value=\"$uid\">".maskemail($user).'</option>';
-			}
-			
-			// Pad the sucker
-			$text .= '<option value="" disabled>';
-			for ($i = 0; $i < 30; $i++) {
-				$text .= '&nbsp;';
-			}
-			$text .= '</option>';
-			break;
-		case 'LANGUAGE' :
-			$dir = opendir(INSTALL_PATH.'/'.INCLUDE_PATH.'languages');
-			while (false !== ($file = readdir($dir))) {
-				if ($file != '.' && $file != '..' && $file != 'CVS') {
-					$file = str_replace('.php', '', $file);
-					if ($file == $value) {
-						$sel = ' selected';
-					} else {
-						$sel = '';
-					}
-					$text .= "<option value=\"$file\"$sel>$file</option>";
-				}
-			}
-			break;
-		case 'THEME' :
-			$dir = opendir(INSTALL_PATH.'/'.INCLUDE_PATH.'templates');
-			while (false !== ($file = readdir($dir))) {
-				if ($file != '.' && $file != '..' && $file != 'CVS') {
-					$file = str_replace('.php', '', $file);
-					if ($file == $value) {
-						$sel = ' selected';
-					} else {
-						$sel = '';
-					}
-					$text .= "<option value=\"$file\"$sel>$file</option>";
-				}
-			}
-			break;
+    case 'bug_cc' :
+      $q->query('select b.user_id, login from '.TBL_BUG_CC.' b left join '.
+        TBL_AUTH_USER." using(user_id) where bug_id = $value");
+      while (list($uid, $user) = $q->grab()) {
+        $text .= "<option value=\"$uid\">".maskemail($user).'</option>';
+      }
+
+      // Pad the sucker
+      $text .= '<option value="" disabled>';
+      for ($i = 0; $i < 30; $i++) {
+        $text .= '&nbsp;';
+      }
+      $text .= '</option>';
+      break;
+    case 'LANGUAGE' :
+      $dir = opendir(INSTALL_PATH.'/'.INCLUDE_PATH.'languages');
+      while (false !== ($file = readdir($dir))) {
+        if ($file != '.' && $file != '..' && $file != 'CVS') {
+          $file = str_replace('.php', '', $file);
+          if ($file == $value) {
+            $sel = ' selected';
+          } else {
+            $sel = '';
+          }
+          $text .= "<option value=\"$file\"$sel>$file</option>";
+        }
+      }
+      break;
+    case 'THEME' :
+      $dir = opendir(INSTALL_PATH.'/'.INCLUDE_PATH.'templates');
+      while (false !== ($file = readdir($dir))) {
+        if ($file != '.' && $file != '..' && $file != 'CVS') {
+          $file = str_replace('.php', '', $file);
+          if ($file == $value) {
+            $sel = ' selected';
+          } else {
+            $sel = '';
+          }
+          $text .= "<option value=\"$file\"$sel>$file</option>";
+        }
+      }
+      break;
     default :
       $deadarray = $select[$box];
       while(list($val,$item) = each($deadarray)) {
@@ -384,7 +384,7 @@
 function multipages($nr, $page, $urlstr) {
   global $me, $selrange;
 
-	$pages = '';
+  $pages = '';
   if (!$page) $page = 1;
   if ($page == 'all') {
     $selrange = $nr;
@@ -429,7 +429,7 @@
 
     $vowels = array("a", "e", "i", "o", "u");
     $cons = array("b", "c", "d", "g", "h", "j", "k", "l", "m", "n", "p", "r", "s", "t", "u", "v", "w", "tr", "cr", "br", "fr", "th", "dr", "ch", "ph", "wr", "st", "sp", "sw", "pr", "sl", "cl");
-		$password = '';
+    $password = '';
 
     $num_vowels = count($vowels);
     $num_cons = count($cons);
@@ -501,9 +501,9 @@
 // Begin every page with a page_open
 if (!defined('NO_AUTH')) {
   session_start();
-	$_sv =& $HTTP_SESSION_VARS;
+  $_sv =& $HTTP_SESSION_VARS;
   $auth = new uauth;
-	$perm = new uperm;
+  $perm = new uperm;
   $u = isset($auth->auth['uid']) ? $auth->auth['uid'] : 0;
 }
 
@@ -521,16 +521,16 @@
       }
       mail($email, $STRING['newacctsubject'], sprintf($STRING['newacctmessage'],
         $password),  sprintf("From: %s\nContent-Type: text/plain; charset=%s\nContent-Transfer-Encoding: 8bit\n",ADMIN_EMAIL, $STRING['lang_charset']));
-      $t->set_var('loginerror', 
-				'<div class="result">Your password has been emailed to you</div>');
+      $t->set_var('loginerror',
+        '<div class="result">Your password has been emailed to you</div>');
     }
   } else {
     if (!$u = $auth->auth_validatelogin()) {
       $t->set_var('loginerror', '<div class="error">Invalid login</div>');
-		}
+    }
   }
 }
 
 $op = isset($_gv['op']) ? $_gv['op'] : (isset($_pv['op']) ? $_pv['op'] : '');
 
-?>
+?>
\ No newline at end of file

[phpBT-dev] CVS: phpbt bug.php,1.71,1.72 include.php,1.88,1.89

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv11084

Modified Files:
	bug.php include.php 
Log Message:
register_globals

Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.71
retrieving revision 1.72
diff -u -r1.71 -r1.72
--- bug.php	2002/01/05 19:49:35	1.71
+++ bug.php	2002/01/05 20:34:49	1.72
@@ -223,14 +223,14 @@
 }
 
 function update_bug($bugid = 0) {
-  global $q, $t, $u, $STRING, $perm, $now;
+  global $q, $t, $u, $STRING, $perm, $now, $_pv;
 
   // Pull bug from database to determine changed fields and for user validation
   $buginfo = $q->grab("select * from ".TBL_BUG." where bug_id = $bugid");
 	$changedfields = array();
 	
-  if (isset($GLOBALS['HTTP_POST_VARS'])) {
-    foreach ($GLOBALS['HTTP_POST_VARS'] as $k => $v) {
+  if (isset($_pv)) {
+    foreach ($_pv as $k => $v) {
       $$k = $v;
       if ($k == 'url') {
         if ($v == 'http://') $v = '';
@@ -366,18 +366,17 @@
 }
 
 function do_form($bugid = 0) {
-  global $q, $me, $title, $u, $another, $STRING, $now;
+  global $q, $me, $u, $_pv, $STRING, $now, $HTTP_SERVER_VARS;
 
-  $pv = $GLOBALS['HTTP_POST_VARS'];
 	$error = '';
   // Validation
-  if (!$pv['title'] = htmlspecialchars(trim($pv['title'])))
+  if (!$_pv['title'] = htmlspecialchars(trim($_pv['title'])))
     $error = $STRING['givesummary'];
-  elseif (!$pv['description'] = htmlspecialchars(trim($pv['description'])))
+  elseif (!$_pv['description'] = htmlspecialchars(trim($_pv['description'])))
     $error = $STRING['givedesc'];
   if ($error) { show_form($bugid, $error); return; }
 
-  while (list($k,$v) = each($pv)) $$k = $v;
+  while (list($k,$v) = each($_pv)) $$k = $v;
 
   if ($url == 'http://') $url = '';
 
@@ -403,18 +402,18 @@
 			component_id, os_id, browser_string) values ($bugid, '$title', 
 			'$description', '$url', $severity, $priority, $status, $owner, $u, 
 			$now, $u, $now, $project, $version, $component, '$os', 
-			'{$GLOBALS['HTTP_USER_AGENT']}')");
+			'{$HTTP_SERVER_VARS['HTTP_USER_AGENT']}')");
 		$buginfo = $q->grab('select * from '.TBL_BUG." where bug_id = $bugid");
 		do_changedfields($u, $buginfo);
   } else {
     $q->query("update ".TBL_BUG." set title = '$title', description = '$description', url = '$url', severity_id = '$severity', priority = '$priority', status_id = $status, assigned_to = '$assignedto', project_id = $project, version_id = $version, component_id = $component, os_id = '$os', browser_string = '{$GLOBALS['HTTP_USER_AGENT']}' last_modified_by = $u, last_modified_date = $time where bug_id = '$bugid'");
   }
-  if ($another) header("Location: $me?op=add&project=$project");
+  if (isset($another)) header("Location: $me?op=add&project=$project");
   else header("Location: query.php");
 }
 
 function show_form($bugid = 0, $error = '') {
-  global $q, $me, $t, $_gv, $TITLE;
+  global $q, $me, $t, $_gv, $_pv, $TITLE;
 
 	if (isset($_gv['project'])) {
 		$project = $_gv['project'];
@@ -596,7 +595,7 @@
 }
 
 function show_bug($bugid = 0, $error = array()) {
-  global $q, $me, $t, $project, $STRING, $TITLE, $u, $perm, $_gv;
+  global $q, $me, $t, $STRING, $TITLE, $u, $perm, $_gv;
 
   if (!ereg('^[0-9]+$',$bugid) or
     !$row = $q->grab('select b.*, reporter.login as reporter, owner.login as owner, status_name, resolution_name 
@@ -740,7 +739,7 @@
 }
 
 function show_projects() {
-  global $me, $q, $t, $project, $STRING, $TITLE, $perm, $auth;
+  global $me, $q, $t, $STRING, $TITLE, $perm, $auth;
 
   // Show only active projects with at least one component
 	if ($perm->have_perm('Admin')) { // Show admins all projects
@@ -786,10 +785,9 @@
 }
 
 $t->set_file('wrap','wrap.html');
-
 
-if (isset($_gv['op'])) {
-  switch($_gv['op']) {
+if ($op) {
+  switch($op) {
     case 'history' : show_history($bugid); break;
     case 'add' :
       $perm->check('Editbug');
@@ -797,8 +795,8 @@
       else show_projects();
       break;
     case 'show' : show_bug($_gv['bugid']); break;
-    case 'update' : update_bug($_gv['bugid']); break;
-    case 'do' : do_form($_gv['bugid']); break;
+    case 'update' : update_bug($_pv['bugid']); break;
+    case 'do' : do_form($_pv['bugid']); break;
     case 'print' : show_bug_printable($_gv['bugid']); break;
   }
 } else header("Location: query.php");

Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.88
retrieving revision 1.89
diff -u -r1.88 -r1.89
--- include.php	2002/01/05 20:01:17	1.88
+++ include.php	2002/01/05 20:34:50	1.89
@@ -531,4 +531,6 @@
   }
 }
 
+$op = isset($_gv['op']) ? $_gv['op'] : (isset($_pv['op']) ? $_pv['op'] : '');
+
 ?>

[phpBT-dev] CVS: phpbt/templates/default bugdisplay.html,1.13,1.14

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv11084/templates/default

Modified Files:
	bugdisplay.html 
Log Message:
register_globals

Index: bugdisplay.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay.html,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- bugdisplay.html	2001/11/24 21:03:38	1.13
+++ bugdisplay.html	2002/01/05 20:34:52	1.14
@@ -1,4 +1,6 @@
-<form action="bug.php?op=update&bugid={bugid}" method="post">
+<form action="bug.php" method="post">
+<input type="hidden" name="op" value="update">
+<input type="hidden" name="bugid" value="{bugid}">
 <input type="hidden" name="projectid" value="{projectid}">
 <input type="hidden" name="last_modified_date" value="{lastmodifieddate}">
 <input type="hidden" name="pos" value="{pos}">

[phpBT-dev] CVS: phpbt/templates/default wrap.html,1.11,1.12

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv2562/templates/default

Modified Files:
	wrap.html 
Log Message:
A little bit of css tweaking

Index: wrap.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/wrap.html,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- wrap.html	2001/12/14 15:11:22	1.11
+++ wrap.html	2002/01/05 20:01:17	1.12
@@ -45,7 +45,7 @@
 		<!-- BEGIN loginblock -->
 		<td class="login-box" nowrap>
 			<form method="post" action="{me2}">
-				<font color="{loginerrorcolor}"><b>{loginerror}<b></font> 
+				{loginerror}
 				{loginlabel}: <input type="text" name="username" class="login-box"> 
 				Password: <input type="password" name="password" class="login-box"> 
 				<input type="hidden" name="dologin" value="1">

[phpBT-dev] CVS: phpbt/templates/default/admin wrap.html,1.5,1.6

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv2562/templates/default/admin

Modified Files:
	wrap.html 
Log Message:
A little bit of css tweaking

Index: wrap.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/wrap.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- wrap.html	2001/12/14 15:08:01	1.5
+++ wrap.html	2002/01/05 20:01:17	1.6
@@ -46,7 +46,7 @@
     <!-- BEGIN loginblock -->
     <td class="login-box">
       <form method="post" action="{me2}">
-        <font color="{loginerrorcolor}"><b>{loginerror}<b></font>
+        {loginerror}
         {loginlabel}: <input type="text" name="username" class="login-box">
         Password: <input type="password" name="password" class="login-box">
         <!--<input type="image" border="0" name="login" value="doit" src="go.gif" width="30" height="20" align="middle" class="login-button">-->

[phpBT-dev] CVS: phpbt include.php,1.87,1.88 css.php,1.3,1.4

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv2562

Modified Files:
	include.php css.php 
Log Message:
A little bit of css tweaking

Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.87
retrieving revision 1.88
diff -u -r1.87 -r1.88
--- include.php	2002/01/05 19:49:35	1.87
+++ include.php	2002/01/05 20:01:17	1.88
@@ -510,12 +510,9 @@
 // Check to see if the user is trying to login
 if (isset($_pv['dologin'])) {
   if (isset($_pv['sendpass'])) {
-    list($email, $password) = $q->grab("select email, password from ".TBL_AUTH_USER." where login = '$username' and active > 0");
+    list($email, $password) = $q->grab("select email, password from ".TBL_AUTH_USER." where login = '{$_pv['username']}' and active > 0");
     if (!$q->num_rows()) {
-      $t->set_var(array(
-        'loginerrorcolor' => '#ff0000',
-        'loginerror' => 'Invalid login<br>'
-        ));
+      $t->set_var('loginerror', '<div class="error">Invalid login</div>');
     } else {
       if (ENCRYPT_PASS) {
         $password = genpassword(10);
@@ -524,17 +521,12 @@
       }
       mail($email, $STRING['newacctsubject'], sprintf($STRING['newacctmessage'],
         $password),  sprintf("From: %s\nContent-Type: text/plain; charset=%s\nContent-Transfer-Encoding: 8bit\n",ADMIN_EMAIL, $STRING['lang_charset']));
-      $t->set_var(array(
-        'loginerrorcolor' => '#0000ff',
-        'loginerror' => 'Your password has been emailed to you<br>'
-        ));
+      $t->set_var('loginerror', 
+				'<div class="result">Your password has been emailed to you</div>');
     }
   } else {
     if (!$u = $auth->auth_validatelogin()) {
-      $t->set_var(array(
-        'loginerrorcolor' => '#ff0000',
-        'loginerror' => 'Invalid login<br>'
-        ));
+      $t->set_var('loginerror', '<div class="error">Invalid login</div>');
 		}
   }
 }

Index: css.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/css.php,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- css.php	2001/10/30 04:04:38	1.3
+++ css.php	2002/01/05 20:01:17	1.4
@@ -151,3 +151,10 @@
 	color: #ff0000;
 	padding-bottom: 0.1em;
 	}
+
+.result {
+	text-align: center;
+	font-weight: bold;
+	color: #0000ff;
+	padding-bottom: 0.1em;
+	}

[phpBT-dev] CVS: phpbt bug.php,1.70,1.71 include.php,1.86,1.87 query.php,1.51,1.52

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv32569

Modified Files:
	bug.php include.php query.php 
Log Message:
Working towards removing the dependency on register_globals = on

Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.70
retrieving revision 1.71
diff -u -r1.70 -r1.71
--- bug.php	2001/12/19 13:52:03	1.70
+++ bug.php	2002/01/05 19:49:35	1.71
@@ -414,10 +414,15 @@
 }
 
 function show_form($bugid = 0, $error = '') {
-  global $q, $me, $t, $project, $TITLE;
+  global $q, $me, $t, $_gv, $TITLE;
 
-  if ($GLOBALS['HTTP_POST_VARS'])
-    while (list($k,$v) = each($GLOBALS['HTTP_POST_VARS'])) $$k = $v;
+	if (isset($_gv['project'])) {
+		$project = $_gv['project'];
+	}
+	
+  if (isset($_pv)) {
+    foreach ($_pv as $k => $v) $$k = $v;
+	}
 
   $t->set_file('content','bugform.html');
   $projectname = $q->grab_field("select project_name from ".TBL_PROJECT." where project_id = $project");
@@ -540,9 +545,9 @@
 ///
 /// Grab the links for the previous and next bugs in the list
 function prev_next_links($bugid, $pos) {
-	global $q, $queryinfo, $STRING;
+	global $q, $_sv, $STRING;
 	
-	if (!isset($queryinfo['query']) || !$queryinfo['query']) {
+	if (!isset($_sv['queryinfo']['query']) || !$_sv['queryinfo']['query']) {
 		return array('', '');
 	}
 	
@@ -565,8 +570,8 @@
 		where b.severity_id = severity.severity_id and b.status_id = status.status_id 
 		and b.os_id = os.os_id and b.version_id = version.version_id 
 		and b.component_id = component.component_id and b.project_id = project.project_id '.
-		"and {$queryinfo['query']} and bug_id <> $bugid 
-		order by {$queryinfo['order']} {$queryinfo['sort']}, bug_id asc", $limit, $offset);
+		"and {$_sv['queryinfo']['query']} and bug_id <> $bugid 
+		order by {$_sv['queryinfo']['order']} {$_sv['queryinfo']['sort']}, bug_id asc", $limit, $offset);
 		
 	$firstid = $q->grab_field();
 	$secondid = $q->grab_field();
@@ -783,18 +788,18 @@
 $t->set_file('wrap','wrap.html');
 
 
-if ($op) {
-  switch($op) {
+if (isset($_gv['op'])) {
+  switch($_gv['op']) {
     case 'history' : show_history($bugid); break;
     case 'add' :
       $perm->check('Editbug');
       if (isset($_gv['project'])) show_form();
       else show_projects();
       break;
-    case 'show' : show_bug($bugid); break;
-    case 'update' : update_bug($bugid); break;
-    case 'do' : do_form($bugid); break;
-    case 'print' : show_bug_printable($bugid); break;
+    case 'show' : show_bug($_gv['bugid']); break;
+    case 'update' : update_bug($_gv['bugid']); break;
+    case 'do' : do_form($_gv['bugid']); break;
+    case 'print' : show_bug_printable($_gv['bugid']); break;
   }
 } else header("Location: query.php");
 

Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.86
retrieving revision 1.87
diff -u -r1.86 -r1.87
--- include.php	2001/12/24 20:52:50	1.86
+++ include.php	2002/01/05 19:49:35	1.87
@@ -162,12 +162,6 @@
 $default_db_fields = array('bug_id', 'title', 'reporter', 'owner',
   'severity_name', 'priority', 'status_name', 'resolution_name');
 
-class usess extends Session {
-  var $classname = 'usess';
-  var $lifetime = 0;
-  var $allowcache = '';
-}
-
 class templateclass extends Template {
   function pparse($target, $handle, $append = false) {
     global $auth, $perm, $q;
@@ -506,13 +500,16 @@
 
 // Begin every page with a page_open
 if (!defined('NO_AUTH')) {
-  page_open(array('sess' => 'usess', 'auth' => 'uauth', 'perm' => 'uperm'));
+  session_start();
+	$_sv =& $HTTP_SESSION_VARS;
+  $auth = new uauth;
+	$perm = new uperm;
   $u = isset($auth->auth['uid']) ? $auth->auth['uid'] : 0;
 }
 
 // Check to see if the user is trying to login
-if (isset($HTTP_POST_VARS['dologin'])) {
-  if (isset($HTTP_POST_VARS['sendpass'])) {
+if (isset($_pv['dologin'])) {
+  if (isset($_pv['sendpass'])) {
     list($email, $password) = $q->grab("select email, password from ".TBL_AUTH_USER." where login = '$username' and active > 0");
     if (!$q->num_rows()) {
       $t->set_var(array(
@@ -533,15 +530,11 @@
         ));
     }
   } else {
-    $auth->auth['uid'] = $auth->auth_validatelogin();
-    if (!$auth->auth['uid']) {
+    if (!$u = $auth->auth_validatelogin()) {
       $t->set_var(array(
         'loginerrorcolor' => '#ff0000',
         'loginerror' => 'Invalid login<br>'
         ));
-    } else {
-			// Now that login is complete update the userid variable
-			$u = $auth->auth['uid'];
 		}
   }
 }

Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -r1.51 -r1.52
--- query.php	2002/01/05 12:57:34	1.51
+++ query.php	2002/01/05 19:49:35	1.52
@@ -195,9 +195,9 @@
 }
 
 function list_items($assignedto = 0, $reportedby = 0, $open = 0) {
-	global $queryinfo, $me, $q, $t, $selrange, $order, $sort, $query, 
+	global $me, $q, $t, $selrange, $order, $sort, $query, 
 		$page, $op, $select, $TITLE, $STRING, $savedqueryname, $u, $auth, 
-		$default_db_fields, $all_db_fields, $sess;
+		$default_db_fields, $all_db_fields, $_sv;
 
 	$t->set_file('content','buglist.html');
 	$t->set_block('content','row','rows');
@@ -211,31 +211,32 @@
 			values (".$q->nextid(TBL_SAVED_QUERY).", $u, '$savedqueryname', '$savedquerystring')");
 	}
 	if (!$order) { 
-		if (isset($queryinfo['order'])) {
-			$order = $queryinfo['order'];
-			$sort = $queryinfo['sort'];
+		if (isset($_sv['queryinfo']['order'])) {
+			$order = $_sv['queryinfo']['order'];
+			$sort = $_sv['queryinfo']['sort'];
 		} else {
 			$order = 'bug_id'; 
 			$sort = 'asc'; 
 		}
 	}
-	$queryinfo['order'] = $order;
-	$queryinfo['sort'] = $sort;
+	$_sv['queryinfo']['order'] = $order;
+	$_sv['queryinfo']['sort'] = $sort;
 	
-	if (empty($queryinfo['query']) or $op) {
-		$queryinfo['query'] = build_query($assignedto, $reportedby, $open);
+	if (empty($_sv['queryinfo']['query']) or $op) {
+		$_sv['queryinfo']['query'] = build_query($assignedto, $reportedby, $open);
 	}
 	
-	if (!$sess->is_registered('queryinfo')) {
-		$sess->register('queryinfo');
+	if (!session_is_registered('queryinfo')) {
+		session_register('queryinfo');
+		$_sv['queryinfo'] = array();
 	}
 	
 	$nr = $q->grab_field('select count(*) from '.TBL_BUG.' b 
 		left join '.TBL_AUTH_USER.' owner on b.assigned_to = owner.user_id
 		left join '.TBL_AUTH_USER.' reporter on b.created_by = reporter.user_id '.
-		($queryinfo['query'] != '' ? "where {$queryinfo['query']}": ''));
+		($_sv['queryinfo']['query'] != '' ? "where {$_sv['queryinfo']['query']}": ''));
 
-	$queryinfo['numrows'] = $nr;
+	$_sv['queryinfo']['numrows'] = $nr;
 	list($selrange, $llimit, $npages, $pages) = multipages($nr,$page,
 		"order=$order&sort=$sort");
 								
@@ -259,7 +260,7 @@
 		where b.severity_id = severity.severity_id and b.status_id = status.status_id 
 		and b.os_id = os.os_id and b.version_id = version.version_id 
 		and b.component_id = component.component_id and b.project_id = project.project_id '.
-		($queryinfo['query'] != '' ? "and {$queryinfo['query']} " : '').
+		($_sv['queryinfo']['query'] != '' ? "and {$_sv['queryinfo']['query']} " : '').
 		"order by $order $sort, bug_id asc", $selrange, $llimit);
 				
 	$headers = array(
@@ -366,7 +367,7 @@
 
 if (isset($_gv['op'])) switch($_gv['op']) {
 	case 'query' : show_query(); break;
-	case 'doquery' : $queryinfo['query'] = ''; list_items(); break;
+	case 'doquery' : $_sv['queryinfo'] = array(); list_items(); break;
 	case 'delquery' : delete_saved_query($queryid); break;
 	case 'mybugs' : list_items($assignedto, $reportedby, $open); break;
 	default : show_query(); break;

[phpBT-dev] CVS: phpbt/inc auth.php,1.4,1.5 session.php,1.2,NONE

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt/inc
In directory usw-pr-cvs1:/tmp/cvs-serv32569/inc

Modified Files:
	auth.php 
Removed Files:
	session.php 
Log Message:
Working towards removing the dependency on register_globals = on

Index: auth.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/auth.php,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- auth.php	2001/12/10 13:43:46	1.4
+++ auth.php	2002/01/05 19:49:35	1.5
@@ -1,6 +1,6 @@
 <?php
 
-// auth.php - Page control, authentication object, and permission object
+// auth.php - Authentication and permission objects
 // ------------------------------------------------------------------------
 // Copyright (c) 2001 The phpBugTracker Group
 // ------------------------------------------------------------------------
@@ -28,11 +28,17 @@
 	var $classname = 'uauth';
 	var $auth = array();
 	
-	function start() {
-		global $sess;
+	function uauth() {
+		global $HTTP_SESSION_VARS;
 		
-		if (!$sess->is_registered('auth')) {
-			$sess->register('auth');
+		if (!session_is_registered('auth')) {
+			session_register('auth');
+			$HTTP_SESSION_VARS['auth'] = array();
+		}
+		
+		$this->auth =& $HTTP_SESSION_VARS['auth'];
+		
+		if (!isset($this->auth['group_ids'])) {
 			$this->auth['group_ids'] = array(0);
 		}
 		
@@ -53,8 +59,9 @@
 	}
 	
 	function auth_validatelogin() {
-    global $username, $password, $q, $select, $emailpass, $emailsuccess, $STRING;
+    global $_pv, $q, $select, $emailpass, $emailsuccess, $STRING;
 
+		extract($_pv);
     if (!$username) return 0;
     $this->auth['uname'] = $username;
     if (ENCRYPT_PASS) {
@@ -73,6 +80,7 @@
       	."  and ag.group_id = ug.group_id and ug.user_id = {$u['user_id']}");
       while (list($groupid, $group, $perm) = $q->grab()) {
         $this->auth['perm'][$perm] = true;
+        $this->auth['uid'] = $u['user_id'];
         $this->auth['group'][$group] = true;
         $this->auth['group_ids'][] = $groupid;
       }
@@ -97,8 +105,8 @@
   function check($p) {
     global $auth;
 
-    if (! $this->have_perm($p)) {    
-      if (! isset($auth->auth['perm']) ) {
+    if (!$this->have_perm($p)) {    
+      if (!isset($auth->auth['perm']) ) {
         $auth->auth['perm'] = '';
       }
       $this->perm_invalid($auth->auth['perm'], $p);
@@ -159,34 +167,5 @@
 		}
 	}
 }
-
-function page_open($feature) {
-
-  # enable sess and all dependent features.
-  if (isset($feature["sess"])) {
-    global $sess;
-    $sess = new $feature["sess"];
-    $sess->start();
-    
-    # the auth feature depends on sess
-    if (isset($feature["auth"])) {
-      global $auth;
-      
-      if (!isset($auth)) {
-        $auth = new $feature["auth"];
-      }
-      $auth->start();
-  
-      
-      # the perm feature depends on auth and sess
-      if (isset($feature["perm"])) {
-        global $perm;
-        
-        if (!isset($perm)) {
-          $perm = new $feature["perm"];
-        }
-      }
-    }
-  }
-}
 
+?>

--- session.php DELETED ---

[phpBT-dev] CVS: phpbt page.inc.patch,1.1,NONE

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv31989

Removed Files:
	page.inc.patch 
Log Message:
No longer needed

--- page.inc.patch DELETED ---

[phpBT-dev] CVS: phpbt query.php,1.50,1.51

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv15885

Modified Files:
	query.php 
Log Message:
Fixes bug #498187 -- needed to addslashes to entries in the project, component, and version select boxes

Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.50
retrieving revision 1.51
diff -u -r1.50 -r1.51
--- query.php	2001/12/24 21:23:50	1.50
+++ query.php	2002/01/05 12:57:34	1.51
@@ -55,11 +55,13 @@
 			p.project_id, p.project_name order by project_name');
 	}
 	while (list($pid, $pname) = $q->grab()) {
+		$pname = addslashes($pname);
 		// Version array
 		$js .= "versions['$pname'] = new Array(new Array('','All'),";
 		$nq->query("select version_name, version_id from ".TBL_VERSION.
 			" where project_id = $pid and active = 1");
 		while (list($version,$vid) = $nq->grab()) {
+			$version = addslashes($version);
 			$js .= "new Array($vid,'$version'),";
 		}
 		if (substr($js,-1) == ',') $js = substr($js,0,-1);
@@ -70,6 +72,7 @@
 		$nq->query("select component_name, component_id from ".TBL_COMPONENT.
 			" where project_id = $pid and active = 1");
 		while (list($comp,$cid) = $nq->grab()) {
+			$comp = addslashes($comp);
 			$js .= "new Array($cid,'$comp'),";
 		}
 		if (substr($js,-1) == ',') $js = substr($js,0,-1);

[phpBT-dev] some little bugs

[Javier S. <ja...@us...>]

Hi ben,
i was testing last phpbt ,  i have found  some little bugs :

- My provider run php with CGI apache API,  when 'install.php' script 
search for INSTALL_PATH, it got CGI path.
So i have changed to an other HTTP_SERVER_VARS called PATH_TRANSLATED 
instead of SCRIPT_FILENAME.
it works ... but i don't know if it works for all apache configs ... i 
think phpbt must try some variables and found which is working good.

- I have installed phpbt with postgresql 7.1 
(http://phpbt.dyndns.org/phpbt-pg/),  php won't connect to postgresql 
until DB_HOST set to empty string. i don't know if it's a common 
problem, but i report it  ;-)

[phpBT-dev] CVS: phpbt CHANGELOG,1.39,1.40

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv28820

Modified Files:
	CHANGELOG 
Log Message:
Readying for 0.6.2

Index: CHANGELOG
===================================================================
RCS file: /cvsroot/phpbt/phpbt/CHANGELOG,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -r1.39 -r1.40
--- CHANGELOG	2001/12/20 14:47:25	1.39
+++ CHANGELOG	2001/12/27 14:49:42	1.40
@@ -1,3 +1,7 @@
+-- 0.6.2 -- 27 Dec 2001
+: Improved compatibility with Opera and IIS.
+: Fixed a bug with logging in.
+
 -- 0.6.1 -- 20 Dec 2001
 : Fixed bugs with the admin tools and buq query.
 

[phpBT-dev] CVS: phpbt/admin user.php,1.34,1.35

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt/admin
In directory usw-pr-cvs1:/tmp/cvs-serv26257/admin

Modified Files:
	user.php 
Log Message:
Cleanup and workaround for Opera

Index: user.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/user.php,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- user.php	2001/12/13 14:06:45	1.34
+++ user.php	2001/12/24 21:30:33	1.35
@@ -30,7 +30,7 @@
 
 	$error = '';
   // Validation
-  if (!LOGIN_IS_EMAIL && !$_pv['flogin'] = trim($_pv['flogin'])) {
+  if (!EMAIL_IS_LOGIN && !$_pv['flogin'] = trim($_pv['flogin'])) {
     $error = $STRING['givelogin'];
   } elseif (!valid_email($_pv['femail'])) {
     $error = $STRING['giveemail'];
@@ -96,10 +96,10 @@
       $user_groups[] = $group_id;
     }
     // Compute differences between old and new
-    if (!is_array($user_groups)) {
+    if (!isset($user_groups) or !is_array($user_groups)) {
       $user_groups = array();
     }
-    if (!is_array($_pv['fusergroup'])) {
+    if (!is_array($_pv['fusergroup']) or !$_pv['fusergroup'][0]) {
       $_pv['fusergroup'] = array();
     }
 

[phpBT-dev] CVS: phpbt query.php,1.49,1.50

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv25407

Modified Files:
	query.php 
Log Message:
Opera workaround

Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -r1.49 -r1.50
--- query.php	2001/12/21 14:19:45	1.49
+++ query.php	2001/12/24 21:23:50	1.50
@@ -127,12 +127,21 @@
 		}
 	} else {
 		// Select boxes
-		if (!empty($status)) $flags[] = 'b.status_id in ('.delimit_list(',',$status).')';
-		if (!empty($resolution)) $flags[] = 'b.resolution_id in ('.delimit_list(',',$resolution).')';
-		if (!empty($os)) $flags[] = 'b.os_id in ('.delimit_list(',',$os).')';
-		if (!empty($priority)) $flags[] = 'b.priority in ('.delimit_list(',',$priority).')';
-		if (!empty($severity)) $flags[] = 'b.severity_id in ('.delimit_list(',',$severity).')';
-		if (!empty($flags)) $query[] = '('.delimit_list(' or ',$flags).')';
+		$flags = array();
+		// Need to check $array[0] for Opera -- 
+		// it passes non-empty arrays for every multi-choice select box
+		if (!empty($status) and $status[0])
+			$flags[] = 'b.status_id in ('.delimit_list(',',$status).')';
+		if (!empty($resolution) and $resolution[0]) 
+			$flags[] = 'b.resolution_id in ('.delimit_list(',',$resolution).')';
+		if (!empty($os) and $os[0]) 
+			$flags[] = 'b.os_id in ('.delimit_list(',',$os).')';
+		if (!empty($priority) and $priority[0]) 
+			$flags[] = 'b.priority in ('.delimit_list(',',$priority).')';
+		if (!empty($severity) and $severity[0]) 
+			$flags[] = 'b.severity_id in ('.delimit_list(',',$severity).')';
+		if (!empty($flags)) 
+			$query[] = '('.delimit_list(' or ',$flags).')';
 
 		// Email field(s)
 		if (!empty($email1)) {
@@ -281,7 +290,7 @@
 	}
 	
 	// Header row 
-	$db_fields = $auth->auth['db_fields'] ? $auth->auth['db_fields'] :
+	$db_fields = !empty($auth->auth['db_fields']) ? $auth->auth['db_fields'] :
 		$default_db_fields;
 	foreach ($db_fields as $field) {
 		$t->set_var(array(

[phpBT-dev] CVS: phpbt include.php,1.85,1.86

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv21643

Modified Files:
	include.php 
Log Message:
Fixes bug #496121 -- not all web servers provide SCRIPT_FILENAME :)

Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.85
retrieving revision 1.86
diff -u -r1.85 -r1.86
--- include.php	2001/12/24 20:08:39	1.85
+++ include.php	2001/12/24 20:52:50	1.86
@@ -22,7 +22,14 @@
 // ------------------------------------------------------------------------
 // $Id$
 
-define ('INSTALL_PATH', dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']));
+// Where are we?
+if (!empty($HTTP_SERVER_VARS['SCRIPT_FILENAME'])) {
+	define ('INSTALL_PATH', dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']));
+} else {
+	define ('INSTALL_PATH', '.');
+}
+
+// Handle being included from admin files
 if (!defined('INCLUDE_PATH')) {
 	define('INCLUDE_PATH', '');
 }

[phpBT-dev] CVS: phpbt include.php,1.84,1.85

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv15591

Modified Files:
	include.php 
Log Message:
Fixes bug $495905 -- $u needs to be updated after a successful login or the page being viewed after login submission still sees the user as "nobody"

Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.84
retrieving revision 1.85
diff -u -r1.84 -r1.85
--- include.php	2001/12/14 15:04:14	1.84
+++ include.php	2001/12/24 20:08:39	1.85
@@ -532,7 +532,10 @@
         'loginerrorcolor' => '#ff0000',
         'loginerror' => 'Invalid login<br>'
         ));
-    }
+    } else {
+			// Now that login is complete update the userid variable
+			$u = $auth->auth['uid'];
+		}
   }
 }
 

[phpBT-dev] CVS: phpbt/schemas mysql.in,1.12,1.13 pgsql.in,1.13,1.14

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt/schemas
In directory usw-pr-cvs1:/tmp/cvs-serv14579

Modified Files:
	mysql.in pgsql.in 
Log Message:
Lengthen bug_list_fields

Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- mysql.in	2001/12/06 14:35:08	1.12
+++ mysql.in	2001/12/24 20:00:49	1.13
@@ -53,7 +53,7 @@
   email char(60) NOT NULL default '',
   password char(40) NOT NULL default '',
   active tinyint(3) unsigned NOT NULL default '1',
-  bug_list_fields char(255) NOT NULL default '',
+  bug_list_fields text NOT NULL default '',
   created_by int(10) unsigned NOT NULL default '0',
   created_date bigint(20) unsigned NOT NULL default '0',
   last_modified_by int(10) unsigned NOT NULL default '0',

Index: pgsql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/pgsql.in,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- pgsql.in	2001/12/06 14:28:31	1.13
+++ pgsql.in	2001/12/24 20:00:49	1.14
@@ -59,7 +59,7 @@
   email varchar(60) NOT NULL DEFAULT '',
   password varchar(40) NOT NULL DEFAULT '',
   active INT2  NOT NULL DEFAULT '1',
-  bug_list_fields varchar(255) NOT NULL DEFAULT '',
+  bug_list_fields TEXT NOT NULL DEFAULT '',
   created_by INT4  NOT NULL DEFAULT '0',
   created_date INT8  NOT NULL DEFAULT '0',
   last_modified_by INT4  NOT NULL DEFAULT '0',

[phpBT-dev] CVS: phpbt query.php,1.48,1.49

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv18533

Modified Files:
	query.php 
Log Message:
Fixes bug #495786 -- ambiguous component_id in query

Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.48
retrieving revision 1.49
diff -u -r1.48 -r1.49
--- query.php	2001/12/19 13:52:03	1.48
+++ query.php	2001/12/21 14:19:45	1.49
@@ -163,7 +163,7 @@
 		if (!empty($projects)) {
 			$proj[] = "b.project_id = $projects";
 			if ($versions) $proj[] = "b.version_id = $versions";
-			if ($components) $proj[] = "component_id = $components";
+			if ($components) $proj[] = "b.component_id = $components";
 			$query[] = '('.delimit_list(' and ',$proj).')';
 		} elseif (!$perm->have_perm('Admin')) { // Filter results from hidden projects
 			$query[] = 'b.project_id in ('.

[phpBT-dev] CVS: phpbt CHANGELOG,1.38,1.39

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv11621

Modified Files:
	CHANGELOG 
Log Message:


Index: CHANGELOG
===================================================================
RCS file: /cvsroot/phpbt/phpbt/CHANGELOG,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- CHANGELOG	2001/12/15 19:27:12	1.38
+++ CHANGELOG	2001/12/20 14:47:25	1.39
@@ -1,3 +1,6 @@
+-- 0.6.1 -- 20 Dec 2001
+: Fixed bugs with the admin tools and buq query.
+
 -- 0.6.0 -- 15 Dec 2001
 : Fixed a bug with old queries being retained when submitting a new query.
 : Moved session, auth, and database classes into the package.

[phpBT-dev] CVS: phpbt INSTALL,1.12,1.13

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv10993

Modified Files:
	INSTALL 
Log Message:
Make a note about register_globals

Index: INSTALL
===================================================================
RCS file: /cvsroot/phpbt/phpbt/INSTALL,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- INSTALL	2001/12/15 19:14:35	1.12
+++ INSTALL	2001/12/20 14:45:06	1.13
@@ -11,3 +11,5 @@
 
 3. After completing the installation, login and start reporting bugs.
 
+* Note: You must have register_globals set to On either in php.ini or in 
+.htaccess.  This requirement will be removed in an upcoming version.