phpbddb-dev1

[phpBddb-dev1] comments

[Janis P. <jan...@on...>]

Hi!
I thought that I should probably comment the code I wrote because I introduced some new things.
1) global $conf array. I thought this could be better because "global $conf" is much easier than to include every variable.

2) global $msg_codes array. This array has the numeric value for messages that would be passed between files. It would be easier to send plain text but it is not "secure" because someone could put HTML in it.

3) global $lang array. This is very alpha. This is just an idea how languages could be managed. In the very end of all that list there is line where global array $text is set the value of current language. This is because it is shorter to write $text['back'] than $text[$conf['language']]['back'].

4) Single quotes (') vs. double quotes ("). PHP parses all text that is enclosed w double quotes and looks for any variables that could be in there. Of course if it is short text it doesn't matter. I just like to get myself used to them. For SQL it is probably easier to use double quotes.

5) This is for the future.. :) I don't like the default session system built in the PHP. If the site is published on the server farm it would not work. The /tmp folder (if not customized) has to have the right permissions for some users not to hijack the sessions. I would like to rewrite the sessions for MySQL but I thought we need to release the beta by 9th and there may be some more to do. We can't just change php session handler because it requires php.ini editing and that's not good.

Any comments or critics would be great.
Janis


--> http://www.one.lv - your number one mobile email service!

Re: [phpBddb-dev1] multilanguage support

[Brian <br...@br...>]

Well this is a good idea for now, but i think we should move language 
support out of the config file. Maybe we can use one file per language.
I've added some more strings to config.inc and fixed the register form.
Also i will make the register form more comfortable.

Brian


>3) global $lang array. This is very alpha. This is just an idea how 
>languages could be managed. In the very end of all that list there is line 
>where global array $text is set the value of current language. This is 
>because it is shorter to write $text['back'] than 
>$text[$conf['language']]['back'].

Re: [phpBddb-dev1] multilanguage support

[Brian <br...@br...>]

Hi,

i moved the language array to external files in new folder 'lang'

Regards Brian.

At 16:37 06.08.2002 +0200, you wrote:

>Well this is a good idea for now, but i think we should move language 
>support out of the config file. Maybe we can use one file per language.
>I've added some more strings to config.inc and fixed the register form.
>Also i will make the register form more comfortable.
>
>Brian
>
>
>>3) global $lang array. This is very alpha. This is just an idea how 
>>languages could be managed. In the very end of all that list there is 
>>line where global array $text is set the value of current language. This 
>>is because it is shorter to write $text['back'] than 
>>$text[$conf['language']]['back'].
>
>
>
>-------------------------------------------------------
>This sf.net email is sponsored by:ThinkGeek
>Welcome to geek heaven.
>http://thinkgeek.com/sf
>_______________________________________________
>Phpbddb-dev1 mailing list
>Php...@li...
>https://lists.sourceforge.net/lists/listinfo/phpbddb-dev1

Re: [phpBddb-dev1] comments

[Brian <br...@br...>]

Hi,

i don`t really like to exchange error messages via the URL, if it is 
numeric or not. Best thing is to keep the URI clean. For the future i want 
to exchange even the 'cmd' parameter via post method only.
Also adding new error codes is not very comfortable.

So what to do with error messages!?

- we want them to be displayed above the content
- we want them to be configurable (color etc.)
- we want multilanguage support
- we want no more parameters in URI
- we want it to be secure, so that no one could place html-code
- we want to be able to display more than one error message
- maybe we want to log errors with IP, username and error message

Solution?
We should have a function, that is called with an error code. It should 
handel translation, displaying and logging.

I don't have a perfect idea right now, any suggestions??

Brian


At 01:37 06.08.2002 +0300, you wrote:
>2) global $msg_codes array. This array has the numeric value for messages 
>that would be passed between files. It would be easier to send plain text 
>but it is not "secure" because someone could put HTML in it.