Revision: 22
http://svn.sourceforge.net/phpbbkb/?rev=22&view=rev
Author: markthedaemon
Date: 2006-11-23 19:21:02 -0800 (Thu, 23 Nov 2006)
Log Message:
-----------
Couple of cleanup points:
- Replaced & with &
- Changed ("kb.$phpEx"); to ('kb'.$phpEx); (the proper syntax.
TODO:
- Need to check SQL injection in the ucp_class.php page.
- Need to finish cleaning up the & and $phpEx.
- Anything else i can think of...
Modified Paths:
--------------
root/kb/functions.php
root/kb/ucp_class.php
Modified: root/kb/functions.php
===================================================================
--- root/kb/functions.php 2006-11-24 00:27:20 UTC (rev 21)
+++ root/kb/functions.php 2006-11-24 03:21:02 UTC (rev 22)
@@ -37,7 +37,7 @@
case "viewcat":
// View category
// id = $cat_id::$cat_name
- $navigation = '<span class="nav"> <a href="' . append_sid("kb.$phpEx") . '" class="nav">' . $lang['kb_main'] . '</a> -> <a class="nav" href="' . append_sid("kb.$phpEx?pid=view_cat&id=" . $id_ary[0]) . '">' . $id_ary[1] .'</a></span>';
+ $navigation = '<span class="nav"> <a href="' . append_sid('kb.'.$phpEx) . '" class="nav">' . $lang['kb_main'] . '</a> -> <a class="nav" href="' . append_sid('kb.'.$phpEx.'?pid=view_cat&id='. $id_ary[0]) . '">' . $id_ary[1] .'</a></span>';
break;
case "viewsubcat":
@@ -51,7 +51,7 @@
message_die(GENERAL_ERROR, 'Could not query cat name.', '', __LINE__, __FILE__, $sql);
}
$maincat = $db->sql_fetchrow($result);
- $navigation = '<span class="nav"> <a href="' . append_sid("kb.$phpEx") . '" class="nav">' . $lang['kb_main'] . '</a> -> <a class="nav" href="' . append_sid("kb.$phpEx?pid=view_cat&id=" . $id_ary[2]) . '">' . $maincat['cat_title'] .'</a> -> <a class="nav" href="' . append_sid("kb.$phpEx?pid=view_cat&id=" . $id_ary[0]) . '">' . $id_ary[1] .'</a></span>';
+ $navigation = '<span class="nav"> <a href="' . append_sid('kb.'$phpEx) . '" class="nav">' . $lang['kb_main'] . '</a> -> <a class="nav" href="' . append_sid('kb.'$phpEx.'?pid=view_cat&id=' . $id_ary[2]) . '">' . $maincat['cat_title'] .'</a> -> <a class="nav" href="' . append_sid('kb.'.$phpEx.'?pid=view_cat&id=' . $id_ary[0]) . '">' . $id_ary[1] .'</a></span>';
break;
case "viewarticle":
@@ -64,7 +64,7 @@
case "main":
default:
- $navigation = '<span class="nav"> <a href="' . append_sid("kb.$phpEx") . '" class="nav">' . $lang['kb_main'] . '</a></span>';
+ $navigation = '<span class="nav"> <a href="' . append_sid('kb.'.$phpEx) . '" class="nav">' . $lang['kb_main'] . '</a></span>';
break;
}
@@ -154,7 +154,7 @@
else
{
$error_msg .= (!empty($error_msg)) ? '<br />' . $lang['kb_empty_cats'] : $lang['kb_empty_cats'];
-
+ }
return;
}
Modified: root/kb/ucp_class.php
===================================================================
--- root/kb/ucp_class.php 2006-11-24 00:27:20 UTC (rev 21)
+++ root/kb/ucp_class.php 2006-11-24 03:21:02 UTC (rev 22)
@@ -169,8 +169,8 @@
$article_id = $db->sql_nextid();
- $meta = '<meta http-equiv="refresh" content="3;url=' . append_sid("kb.$phpEx?pid=view_article&id=" . $article_id) . '>"';
- $message = $lang['kb_added'] . '<br /><br />' . sprintf($lang['kb_click_view_article'], '<a href="' . append_sid("kb.$phpEx?pid=view_article&id=" . $article_id) . '">', '</a>') . '<br /><br />' . sprintf($lang['kb_click_return_ucp'], '<a href="' . append_sid("kb.$phpEx?pid=ucp") . '">', '</a>');
+ $meta = '<meta http-equiv="refresh" content="3;url=' . append_sid('kb.'.$phpEx.'?pid=view_article&id=' . $article_id) . '>"';
+ $message = $lang['kb_added'] . '<br /><br />' . sprintf($lang['kb_click_view_article'], '<a href="' . append_sid('kb.'.$phpEx.'?pid=view_article&id=' . $article_id) . '">', '</a>') . '<br /><br />' . sprintf($lang['kb_click_return_ucp'], '<a href="' . append_sid('kb.'.$phpEx.'?pid=ucp') . '">', '</a>');
}
}
@@ -181,7 +181,7 @@
$article_text = '';
$article_desc = '';
$authorname = $userdata['username'];
- $form_action = append_sid("kb.php?pid=ucp&action=post_article");
+ $form_action = append_sid('kb.'.$phpEx.'?pid=ucp&action=post_article');
$hidden_form_fields = "";
$attach_sig = ( $userdata['user_id'] == ANONYMOUS ) ? 0 : $userdata['user_attachsig'];
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
