[Phpbbkb-checkins] SF.net SVN: phpbbkb: [27] root

[<mar...@us...>]

Revision: 27
          http://svn.sourceforge.net/phpbbkb/?rev=27&view=rev
Author:   markthedaemon
Date:     2006-12-11 19:04:25 -0800 (Mon, 11 Dec 2006)

Log Message:
-----------
Few changes, nothing major. Added some notes to kb.php as i was reading through it with possible changes. Code looks good thus far, Alpha 1 here we come :-D

Modified Paths:
--------------
    root/kb/constants.php
    root/kb.php
    root/language/lang_english/lang_kb.php

Modified: root/kb/constants.php
===================================================================
--- root/kb/constants.php	2006-11-29 23:28:36 UTC (rev 26)
+++ root/kb/constants.php	2006-12-12 03:04:25 UTC (rev 27)
@@ -1,6 +1,6 @@
 <?php
 /***************************************************************************
- *                               lang_kb.php
+ *                               constants.php
  *                            -------------------
  *
  *   copyright: 		phpBB KB Group

Modified: root/kb.php
===================================================================
--- root/kb.php	2006-11-29 23:28:36 UTC (rev 26)
+++ root/kb.php	2006-12-12 03:04:25 UTC (rev 27)
@@ -150,7 +150,7 @@
 		$cat_id = ( isset( $HTTP_GET_VARS['id'] ) ) ? $HTTP_GET_VARS['id'] : false;
 		if(!$cat_id)
 		{
-			message_die(GENERAL_MESSAGE, "The chosen category doesn't exist.");
+			message_die(GENERAL_MESSAGE, "The chosen category doesn't exist."); // this needs to be in a $lang entry
 		}
 		
 		// Store the main cat in a variable
@@ -314,7 +314,7 @@
 				{
 					$authorname = $articles[$i]['article_authorname'];
 				}
-				$author = "<a href=\"profile.php?mode=viewprofile&amp;u=" . $articles[$i]['article_author'] . "\">$authorname</a>";
+				$author = "<a href=\"profile.php?mode=viewprofile&amp;u=" . $articles[$i]['article_author'] . "\">$authorname</a>"; //hardcoded PHP extension.
 				
 				$sql = "SELECT username
 						FROM " . USERS_TABLE . "
@@ -325,7 +325,7 @@
 				}
 				
 				$user = $db->sql_fetchrow($result);
-				$last_action = sprintf($lang['kb_last_action_row'], "<a href=\"profile.php?mode=viewprofile&amp;u=" . $articles[$i]['article_editby'] . "\">" . $user['username'] . "</a>", create_date($board_config['default_dateformat'], $articles[$i]['article_edittime'], $board_config['board_timezone']));
+				$last_action = sprintf($lang['kb_last_action_row'], "<a href=\"profile.php?mode=viewprofile&amp;u=" . $articles[$i]['article_editby'] . "\">" . $user['username'] . "</a>", create_date($board_config['default_dateformat'], $articles[$i]['article_edittime'], $board_config['board_timezone'])); // hardcoded PHP extension.
 				
 				$template->assign_block_vars('switch_articles.articlerow', array(
 					'TOPIC_FOLDER_IMG' => $images['folder'],
@@ -358,7 +358,7 @@
 		
 		if(!$cid || !$id)
 		{
-			message_die(GENERAL_ERROR, 'Not enough arguments defined. Please make sure both id and cat id is defined.');
+			message_die(GENERAL_ERROR, 'Not enough arguments defined. Please make sure both id and cat id is defined.'); // Hmm, is this a error that is worthy of being a hardcoded one?
 		}
 		
 		$sql = "SELECT a.*, u.*

Modified: root/language/lang_english/lang_kb.php
===================================================================
--- root/language/lang_english/lang_kb.php	2006-11-29 23:28:36 UTC (rev 26)
+++ root/language/lang_english/lang_kb.php	2006-12-12 03:04:25 UTC (rev 27)
@@ -19,7 +19,7 @@
  ***************************************************************************/
 
 // Page titles
-$lang['kb_main'] = "KnowledgeBase Home";
+$lang['kb_main'] = "Knowledge Base Home";
 $lang['kb_viewcat'] = "Viewing Category";
 $lang['kb_viewarticle'] = "Viewing Article";
 $lang['kb_ucp'] = "KB User Control Panel"; 
@@ -27,11 +27,11 @@
 $lang['kb_ucp_articleedit'] = "Edit article";
 
 // Normal Page
-$lang['kb_categories'] = "KnowledgeBase Categories";
+$lang['kb_categories'] = "Knowledge Base Categories";
 $lang['kb_articles'] = "Articles";
-$lang['kb_subcats'] = "Subcategories";
-$lang['kb_remove_installfile'] = "Please ensure that you remove the kb_install.php file located in your phpBB root folder. KnowledgeBase won't work before that has been done!";
-$lang['No_kb_cats'] = "No knowledgebase categories has been added.";
+$lang['kb_subcats'] = "Sub categories";
+$lang['kb_remove_installfile'] = "Please ensure that you remove the kb_install.php file located in your phpBB root folder. Knowledge Base won't work before that has been done!";
+$lang['No_kb_cats'] = "No knowledge base categories has been added.";
 
 $lang['kb_viewcat_subcats'] = "Subcategories in %s";
 $lang['kb_last_action'] = "Last action";
@@ -46,7 +46,7 @@
 $lang['kb_articlecats'] = "Article Categories";
 $lang['kb_articletext'] = "Article Content";
 $lang['kb_articledesc_desc'] = "Description of your article, max. 255 characters.";
-$lang['kb_articlecats_desc'] = "Choose what categories your article will appear in, use ctrl + click for multiple.";
+$lang['kb_articlecats_desc'] = "Choose what categories your article will appear in, use Ctrl & Click for multiple.";
 $lang['kb_empty_article'] = "The article content you have submitted was empty.";
 $lang['kb_empty_article_title'] = "The article title you submitted was empty.";
 $lang['kb_empty_cats'] = "The article you submitted had no category defined.";


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.