You can subscribe to this list here.
2001 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(193) |
Nov
(393) |
Dec
(347) |
---|---|---|---|---|---|---|---|---|---|---|---|---|
2002 |
Jan
(401) |
Feb
(232) |
Mar
(343) |
Apr
(129) |
May
(129) |
Jun
(116) |
Jul
(189) |
Aug
(129) |
Sep
(68) |
Oct
(172) |
Nov
(298) |
Dec
(148) |
2003 |
Jan
(264) |
Feb
(210) |
Mar
(322) |
Apr
(309) |
May
(234) |
Jun
(188) |
Jul
(215) |
Aug
(161) |
Sep
(234) |
Oct
(163) |
Nov
(110) |
Dec
(7) |
2004 |
Jan
(95) |
Feb
(107) |
Mar
(55) |
Apr
(3) |
May
(49) |
Jun
(35) |
Jul
(57) |
Aug
(43) |
Sep
(56) |
Oct
(40) |
Nov
(25) |
Dec
(21) |
2005 |
Jan
(93) |
Feb
(25) |
Mar
(22) |
Apr
(72) |
May
(45) |
Jun
(24) |
Jul
(29) |
Aug
(20) |
Sep
(50) |
Oct
(93) |
Nov
(69) |
Dec
(183) |
2006 |
Jan
(185) |
Feb
(143) |
Mar
(402) |
Apr
(260) |
May
(322) |
Jun
(367) |
Jul
(234) |
Aug
(299) |
Sep
(206) |
Oct
(288) |
Nov
(338) |
Dec
(307) |
2007 |
Jan
(296) |
Feb
(250) |
Mar
(261) |
Apr
(434) |
May
(539) |
Jun
(274) |
Jul
(440) |
Aug
(190) |
Sep
(128) |
Oct
(249) |
Nov
(86) |
Dec
(51) |
2008 |
Jan
(177) |
Feb
(67) |
Mar
(61) |
Apr
(48) |
May
(56) |
Jun
(97) |
Jul
(60) |
Aug
(64) |
Sep
(151) |
Oct
(79) |
Nov
(109) |
Dec
(123) |
2009 |
Jan
(70) |
Feb
(70) |
Mar
(73) |
Apr
(80) |
May
(22) |
Jun
(193) |
Jul
(191) |
Aug
(181) |
Sep
(120) |
Oct
(48) |
Nov
(24) |
Dec
|
From: Meik S. <acy...@ph...> - 2009-10-30 17:21:40
|
Author: acydburn Date: Fri Oct 30 17:21:20 2009 New Revision: 10247 Log: Fix another bug in WHERE statement rewrite for oracle. The bug(s) actually consist of not detecting correct parameters and then resulting in partial WHERE statements, where non-detected strings are simply removed. grrrrrr Modified: branches/phpBB-3_0_0/phpBB/includes/db/oracle.php Modified: branches/phpBB-3_0_0/phpBB/includes/db/oracle.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/db/oracle.php (original) --- branches/phpBB-3_0_0/phpBB/includes/db/oracle.php Fri Oct 30 17:21:20 2009 *************** *** 136,142 **** */ function _rewrite_where($where_clause) { ! preg_match_all('/\s*(AND|OR)?\s*([\w_.()]++)\s*(?:(=|<[=>]?|>=?)\s*((?>\'(?>[^\']++|\'\')*+\'|[\d-.()]+))|((NOT )?IN\s*\((?>\'(?>[^\']++|\'\')*+\',? ?|[\d-.]+,? ?)*+\)))/', $where_clause, $result, PREG_SET_ORDER); $out = ''; foreach ($result as $val) { --- 136,142 ---- */ function _rewrite_where($where_clause) { ! preg_match_all('/\s*(AND|OR)?\s*([\w_.()]++)\s*(?:(=|<[=>]?|>=?|LIKE)\s*((?>\'(?>[^\']++|\'\')*+\'|[\d-.()]+))|((NOT )?IN\s*\((?>\'(?>[^\']++|\'\')*+\',? ?|[\d-.]+,? ?)*+\)))/', $where_clause, $result, PREG_SET_ORDER); $out = ''; foreach ($result as $val) { |
From: Meik S. <acy...@ph...> - 2009-10-30 17:00:40
|
Author: acydburn Date: Fri Oct 30 16:59:48 2009 New Revision: 10246 Log: saw this bug while debugging... we really really need another layer in 3.1.x (better sooner than later), but retaining backwards compatibility. Modified: branches/phpBB-3_0_0/phpBB/includes/db/oracle.php Modified: branches/phpBB-3_0_0/phpBB/includes/db/oracle.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/db/oracle.php (original) --- branches/phpBB-3_0_0/phpBB/includes/db/oracle.php Fri Oct 30 16:59:48 2009 *************** *** 136,142 **** */ function _rewrite_where($where_clause) { ! preg_match_all('/\s*(AND|OR)?\s*([\w_.]++)\s*(?:(=|<[=>]?|>=?)\s*((?>\'(?>[^\']++|\'\')*+\'|[\d-.]+))|((NOT )?IN\s*\((?>\'(?>[^\']++|\'\')*+\',? ?|[\d-.]+,? ?)*+\)))/', $where_clause, $result, PREG_SET_ORDER); $out = ''; foreach ($result as $val) { --- 136,142 ---- */ function _rewrite_where($where_clause) { ! preg_match_all('/\s*(AND|OR)?\s*([\w_.()]++)\s*(?:(=|<[=>]?|>=?)\s*((?>\'(?>[^\']++|\'\')*+\'|[\d-.()]+))|((NOT )?IN\s*\((?>\'(?>[^\']++|\'\')*+\',? ?|[\d-.]+,? ?)*+\)))/', $where_clause, $result, PREG_SET_ORDER); $out = ''; foreach ($result as $val) { |
From: Meik S. <acy...@ph...> - 2009-10-29 15:05:03
|
Author: acydburn Date: Thu Oct 29 15:04:19 2009 New Revision: 10245 Log: Fix Jabber SASL PLAIN authentication failures. (Bug #52995) Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html branches/phpBB-3_0_0/phpBB/includes/functions_jabber.php Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html ============================================================================== *** branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html (original) --- branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html Thu Oct 29 15:04:19 2009 *************** *** 211,216 **** --- 211,217 ---- <li>[Fix] Correctly display underlined links placed in last line in viewtopic. (Bug #14811 - Patch by primehalo)</li> <li>[Fix] Only check whether forum image exists if forum image is specified. (Bug #51905)</li> <li>[Fix] Fixed database updater for changes to columns having default value in MSSQL (adding/dropping constraints).</li> + <li>[Fix] Jabber SASL PLAIN authentication failures. (Bug #52995)</li> <li>[Change] Database updater now supports checking for existing/missing indexes.</li> <li>[Change] submit_post() now accepts force_approved_state key passed to $data to indicate new posts being approved (true) or unapproved (false).</li> <li>[Change] Change the data format of the default file ACM to be more secure from tampering and have better performance.</li> Modified: branches/phpBB-3_0_0/phpBB/includes/functions_jabber.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/functions_jabber.php (original) --- branches/phpBB-3_0_0/phpBB/includes/functions_jabber.php Thu Oct 29 15:04:19 2009 *************** *** 476,483 **** } else if (in_array('PLAIN', $methods) && ($this->session['ssl'] || !empty($this->session['tls']))) { $this->send("<auth xmlns='urn:ietf:params:xml:ns:xmpp-sasl' mechanism='PLAIN'>" ! . base64_encode(chr(0) . $this->username . '@' . $this->server . chr(0) . $this->password) . '</auth>'); } else if (in_array('ANONYMOUS', $methods)) --- 476,484 ---- } else if (in_array('PLAIN', $methods) && ($this->session['ssl'] || !empty($this->session['tls']))) { + // http://www.ietf.org/rfc/rfc4616.txt (PLAIN SASL Mechanism) $this->send("<auth xmlns='urn:ietf:params:xml:ns:xmpp-sasl' mechanism='PLAIN'>" ! . base64_encode($this->username . '@' . $this->server . chr(0) . $this->username . chr(0) . $this->password) . '</auth>'); } else if (in_array('ANONYMOUS', $methods)) |
From: Meik S. <acy...@ph...> - 2009-10-29 14:00:55
|
Author: acydburn Date: Thu Oct 29 14:00:43 2009 New Revision: 10244 Log: Implement suggestion in ticket #52155 - Better way to generate SID-free links in feed.php Modified: branches/phpBB-3_0_0/phpBB/feed.php Modified: branches/phpBB-3_0_0/phpBB/feed.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/feed.php (original) --- branches/phpBB-3_0_0/phpBB/feed.php Thu Oct 29 14:00:43 2009 *************** *** 212,228 **** { global $board_url; ! $link = append_sid($board_url . $url, $params); ! ! // Remove added sid - not as easy as it sounds. ;) ! $link = (strpos($link, 'sid=') !== false) ? trim(preg_replace('/(&|&|\?)sid=[a-z0-9]+(&|&)?/', '\1', $link), '?& ') : $link; ! ! // Now the only thing remaining could be an empty & ! $link = (substr($link, -5) === '&') ? substr($link, 0, -5) : $link; ! // And &#xxx ! $link = str_replace('&#', '#', $link); ! ! return $link; } /** --- 212,218 ---- { global $board_url; ! return append_sid($board_url . $url, $params, true, ''); } /** |
From: Ruslan U. <rx...@ph...> - 2009-10-28 16:50:10
|
Author: rxu Date: Wed Oct 28 16:49:23 2009 New Revision: 10243 Log: Fix Bug #53285 introduced in r10018 - Mark the first visible forum on index as unread if there's any unread global announcement Authorised by: Bantu Modified: branches/phpBB-3_0_0/phpBB/includes/functions_display.php Modified: branches/phpBB-3_0_0/phpBB/includes/functions_display.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/functions_display.php (original) --- branches/phpBB-3_0_0/phpBB/includes/functions_display.php Wed Oct 28 16:49:23 2009 *************** *** 323,329 **** $forum_unread = (isset($forum_tracking_info[$forum_id]) && $row['orig_forum_last_post_time'] > $forum_tracking_info[$forum_id]) ? true : false; // Mark the first visible forum on index as unread if there's any unread global announcement ! if (($forum_id == $forum_ids_moderator[0]) && ($root_data['forum_id'] == 0) && $ga_unread) { $forum_unread = true; } --- 323,329 ---- $forum_unread = (isset($forum_tracking_info[$forum_id]) && $row['orig_forum_last_post_time'] > $forum_tracking_info[$forum_id]) ? true : false; // Mark the first visible forum on index as unread if there's any unread global announcement ! if ($ga_unread && !empty($forum_ids_moderator) && $forum_id == $forum_ids_moderator[0]) { $forum_unread = true; } |
From: Meik S. <acy...@ph...> - 2009-10-28 16:18:23
|
Author: acydburn Date: Wed Oct 28 16:18:02 2009 New Revision: 10242 Log: now we will have an RC4 we can adjust this one email file to act like all other email files Modified: branches/phpBB-3_0_0/phpBB/language/en/email/admin_welcome_activated.txt Modified: branches/phpBB-3_0_0/phpBB/language/en/email/admin_welcome_activated.txt ============================================================================== *** branches/phpBB-3_0_0/phpBB/language/en/email/admin_welcome_activated.txt (original) --- branches/phpBB-3_0_0/phpBB/language/en/email/admin_welcome_activated.txt Wed Oct 28 16:18:02 2009 *************** *** 2,7 **** Hello {USERNAME}, ! Your account on "{SITENAME}" has now been activated, you may login using the username and password you received in a previous e-mail. {EMAIL_SIG} \ No newline at end of file --- 2,9 ---- Hello {USERNAME}, ! Your account on "{SITENAME}" has now been activated, you may login using the username you received in a previous e-mail. ! ! Your password has been securely stored in our database and cannot be retrieved. In the event that it is forgotten, you will be able to reset it using the email address associated with your account. {EMAIL_SIG} \ No newline at end of file |
From: Meik S. <acy...@ph...> - 2009-10-28 16:06:00
|
Author: acydburn Date: Wed Oct 28 16:05:17 2009 New Revision: 10241 Log: I am very sorry... but the changes require (a hopefully very short) RC4 phase Modified: branches/phpBB-3_0_0/phpBB/includes/constants.php branches/phpBB-3_0_0/phpBB/install/database_update.php branches/phpBB-3_0_0/phpBB/install/schemas/schema_data.sql Modified: branches/phpBB-3_0_0/phpBB/includes/constants.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/constants.php (original) --- branches/phpBB-3_0_0/phpBB/includes/constants.php Wed Oct 28 16:05:17 2009 *************** *** 25,31 **** */ // phpBB Version ! define('PHPBB_VERSION', '3.0.6'); // QA-related // define('PHPBB_QA', 1); --- 25,31 ---- */ // phpBB Version ! define('PHPBB_VERSION', '3.0.6-RC4'); // QA-related // define('PHPBB_QA', 1); Modified: branches/phpBB-3_0_0/phpBB/install/database_update.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/install/database_update.php (original) --- branches/phpBB-3_0_0/phpBB/install/database_update.php Wed Oct 28 16:05:17 2009 *************** *** 8,14 **** * */ ! $updates_to_version = '3.0.6'; // Enter any version to update from to test updates. The version within the db will not be updated. $debug_from_version = false; --- 8,14 ---- * */ ! $updates_to_version = '3.0.6-RC4'; // Enter any version to update from to test updates. The version within the db will not be updated. $debug_from_version = false; *************** *** 885,891 **** ), // No changes from 3.0.6-RC2 to 3.0.6-RC3 '3.0.6-RC2' => array(), ! // No changes from 3.0.6-RC3 to 3.0.6 '3.0.6-RC3' => array(), ); } --- 885,891 ---- ), // No changes from 3.0.6-RC2 to 3.0.6-RC3 '3.0.6-RC2' => array(), ! // No changes from 3.0.6-RC3 to 3.0.6-RC4 '3.0.6-RC3' => array(), ); } *************** *** 1531,1537 **** break; ! // No changes from 3.0.6-RC3 to 3.0.6 case '3.0.6-RC3': break; } --- 1531,1537 ---- break; ! // No changes from 3.0.6-RC3 to 3.0.6-RC4 case '3.0.6-RC3': break; } Modified: branches/phpBB-3_0_0/phpBB/install/schemas/schema_data.sql ============================================================================== *** branches/phpBB-3_0_0/phpBB/install/schemas/schema_data.sql (original) --- branches/phpBB-3_0_0/phpBB/install/schemas/schema_data.sql Wed Oct 28 16:05:17 2009 *************** *** 239,245 **** INSERT INTO phpbb_config (config_name, config_value) VALUES ('tpl_allow_php', '0'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_icons_path', 'images/upload_icons'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_path', 'files'); ! INSERT INTO phpbb_config (config_name, config_value) VALUES ('version', '3.0.6'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_expire_days', '90'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_gc', '14400'); --- 239,245 ---- INSERT INTO phpbb_config (config_name, config_value) VALUES ('tpl_allow_php', '0'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_icons_path', 'images/upload_icons'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_path', 'files'); ! INSERT INTO phpbb_config (config_name, config_value) VALUES ('version', '3.0.6-RC4'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_expire_days', '90'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_gc', '14400'); |
From: Meik S. <acy...@ph...> - 2009-10-28 15:11:18
|
Author: acydburn Date: Wed Oct 28 15:10:32 2009 New Revision: 10240 Log: Fix Bug #53245 - Correct regular expression escaping and only splitting keywords on space and "|" Modified: branches/phpBB-3_0_0/phpBB/includes/functions_admin.php Modified: branches/phpBB-3_0_0/phpBB/includes/functions_admin.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/functions_admin.php (original) --- branches/phpBB-3_0_0/phpBB/includes/functions_admin.php Wed Oct 28 15:10:32 2009 *************** *** 2549,2565 **** return; } ! $keywords = preg_split('#[\s+\-|*()]+#u', utf8_strtolower(preg_quote($keywords, '#')), 0, PREG_SPLIT_NO_EMPTY); $sql_keywords = ''; if (!empty($keywords)) { ! $keywords_pattern = '#' . implode('|', $keywords) . '#ui'; for ($i = 0, $num_keywords = sizeof($keywords); $i < $num_keywords; $i++) { $keywords[$i] = $db->sql_like_expression($db->any_char . $keywords[$i] . $db->any_char); } $operations = array(); foreach ($user->lang as $key => $value) { --- 2549,2572 ---- return; } ! // Use no preg_quote for $keywords because this would lead to sole backslashes being added ! // We also use an OR connection here for spaces and the | string. Currently, regex is not supported for searching (but may come later). ! $keywords = preg_split('#[\s|]+#u', utf8_strtolower($keywords), 0, PREG_SPLIT_NO_EMPTY); $sql_keywords = ''; if (!empty($keywords)) { ! $keywords_pattern = array(); ! ! // Build pattern and keywords... for ($i = 0, $num_keywords = sizeof($keywords); $i < $num_keywords; $i++) { + $keywords_pattern[] = preg_quote($keywords[$i], '#'); $keywords[$i] = $db->sql_like_expression($db->any_char . $keywords[$i] . $db->any_char); } + $keywords_pattern = '#' . implode('|', $keywords_pattern) . '#ui'; + $operations = array(); foreach ($user->lang as $key => $value) { |
From: Henry S. <kel...@ph...> - 2009-10-27 13:54:17
|
Author: Kellanved Date: Tue Oct 27 13:54:03 2009 New Revision: 10239 Log: ... and finally Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php (original) --- branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Tue Oct 27 13:54:03 2009 *************** *** 794,800 **** 'question_text' => request_var('question_text', '', true), 'strict' => request_var('strict', false), 'lang_iso' => request_var('lang_iso', ''), ! 'answers' => (strlen($answers)) ? explode("\n", request_var('answers', '', true)) : '', ); return $question; --- 794,800 ---- 'question_text' => request_var('question_text', '', true), 'strict' => request_var('strict', false), 'lang_iso' => request_var('lang_iso', ''), ! 'answers' => (strlen($answers)) ? explode("\n", $answers) : '', ); return $question; |
From: Henry S. <kel...@ph...> - 2009-10-27 12:37:41
|
Author: Kellanved Date: Tue Oct 27 12:36:55 2009 New Revision: 10238 Log: adding normalization - shouldn't change anything Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php (original) --- branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Tue Oct 27 12:36:55 2009 *************** *** 502,508 **** { global $db; ! $answer = ($this->question_strict) ? request_var('qa_answer', '', true) : utf8_clean_string(request_var('qa_answer', '', true)); $sql = 'SELECT answer_text FROM ' . CAPTCHA_ANSWERS_TABLE . ' --- 502,508 ---- { global $db; ! $answer = ($this->question_strict) ? utf8_normalize_nfc(request_var('qa_answer', '', true)) : utf8_clean_string(utf8_normalize_nfc(request_var('qa_answer', '', true))); $sql = 'SELECT answer_text FROM ' . CAPTCHA_ANSWERS_TABLE . ' *************** *** 789,795 **** */ function acp_get_question_input() { ! $answers = request_var('answers', '', true); $question = array( 'question_text' => request_var('question_text', '', true), 'strict' => request_var('strict', false), --- 789,795 ---- */ function acp_get_question_input() { ! $answers = utf8_normalize_nfc(request_var('answers', '', true)); $question = array( 'question_text' => request_var('question_text', '', true), 'strict' => request_var('strict', false), |
From: Henry S. <kel...@ph...> - 2009-10-27 12:33:36
|
Author: Kellanved Date: Tue Oct 27 12:27:46 2009 New Revision: 10237 Log: #53235 - removing accidental commits Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php (original) --- branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Tue Oct 27 12:27:46 2009 *************** *** 53,59 **** // read input $this->confirm_id = request_var('qa_confirm_id', ''); ! $this->answer = request_var('qa_answer', '', true); $this->type = (int) $type; $this->question_lang = $user->lang_name; --- 53,59 ---- // read input $this->confirm_id = request_var('qa_confirm_id', ''); ! $this->answer = utf8_normalize_nfc(request_var('qa_answer', '', true)); $this->type = (int) $type; $this->question_lang = $user->lang_name; *************** *** 349,360 **** global $config, $db, $user; $error = ''; ! if (!sizeof($this->question_ids)) { return false; } ! if (!$this->confirm_id) { $error = $user->lang['CONFIRM_QUESTION_WRONG']; --- 349,360 ---- global $config, $db, $user; $error = ''; ! if (!sizeof($this->question_ids)) { return false; } ! if (!$this->confirm_id) { $error = $user->lang['CONFIRM_QUESTION_WRONG']; *************** *** 419,425 **** function reselect_question() { global $db, $user; ! if (!sizeof($this->question_ids)) { return false; --- 419,425 ---- function reselect_question() { global $db, $user; ! if (!sizeof($this->question_ids)) { return false; *************** *** 464,470 **** function load_answer() { global $db, $user; ! if (!sizeof($this->question_ids)) { return false; --- 464,470 ---- function load_answer() { global $db, $user; ! if (!sizeof($this->question_ids)) { return false; *************** *** 617,644 **** } else if ($question_id && $action == 'delete') { ! if ($this->get_class_name() !== $config['captcha_plugin'] || !$this->acp_is_last($question_id)) { ! if (confirm_box(true)) ! { ! $this->acp_delete_question($question_id); ! trigger_error($user->lang['QUESTION_DELETED'] . adm_back_link($list_url)); ! } ! else ! { ! confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields(array( ! 'question_id' => $question_id, ! 'action' => $action, ! 'configure' => 1, ! 'select_captcha' => $this->get_class_name(), ! )) ! ); ! } } else { ! trigger_error($user->lang['QA_ERROR_MSG'] . adm_back_link($list_url), E_USER_WARNING); } } else --- 617,637 ---- } else if ($question_id && $action == 'delete') { ! if (confirm_box(true)) { ! $this->acp_delete_question($question_id); ! trigger_error($user->lang['QUESTION_DELETED'] . adm_back_link($list_url)); } else { ! confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields(array( ! 'question_id' => $question_id, ! 'action' => $action, ! 'configure' => 1, ! 'select_captcha' => $this->get_class_name(), ! )) ! ); } } else *************** *** 718,724 **** } else if ($submit) { ! trigger_error($user->lang['FORM_INVALID'] . adm_back_link($list_url), E_USER_WARNING); } } } --- 711,717 ---- } else if ($submit) { ! trigger_error($user->lang['FORM_INVALID'] . adm_back_link($list_url)); } } } *************** *** 801,807 **** 'question_text' => request_var('question_text', '', true), 'strict' => request_var('strict', false), 'lang_iso' => request_var('lang_iso', ''), ! 'answers' => (strlen($answers)) ? explode("\n", $answers) : '', ); return $question; --- 794,800 ---- 'question_text' => request_var('question_text', '', true), 'strict' => request_var('strict', false), 'lang_iso' => request_var('lang_iso', ''), ! 'answers' => (strlen($answers)) ? explode("\n", request_var('answers', '', true)) : '', ); return $question; *************** *** 922,927 **** --- 915,921 ---- { return false; } + return true; } *************** *** 948,978 **** return $langs; } - - /** - * Grab a question and bring it into a format the editor understands - */ - function acp_is_last($question_id) - { - global $config, $db; - - if ($question_id) - { - $sql = 'SELECT question_id - FROM ' . CAPTCHA_QUESTIONS_TABLE . " - WHERE lang_iso = '" . $db->sql_escape($config['default_lang']) . "' - AND question_id <> " . (int) $question_id; - $result = $db->sql_query_limit($sql, 1); - $question = $db->sql_fetchrow($result); - $db->sql_freeresult($result); - - if (!$question) - { - return true; - } - return false; - } - } } ?> \ No newline at end of file --- 942,947 ---- |
From: Meik S. <acy...@ph...> - 2009-10-27 11:18:40
|
Author: acydburn Date: Tue Oct 27 11:17:53 2009 New Revision: 10236 Log: fix spaces/tabs Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php (original) --- branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Tue Oct 27 11:17:53 2009 *************** *** 349,360 **** global $config, $db, $user; $error = ''; ! if (!sizeof($this->question_ids)) { return false; } ! if (!$this->confirm_id) { $error = $user->lang['CONFIRM_QUESTION_WRONG']; --- 349,360 ---- global $config, $db, $user; $error = ''; ! if (!sizeof($this->question_ids)) { return false; } ! if (!$this->confirm_id) { $error = $user->lang['CONFIRM_QUESTION_WRONG']; *************** *** 419,425 **** function reselect_question() { global $db, $user; ! if (!sizeof($this->question_ids)) { return false; --- 419,425 ---- function reselect_question() { global $db, $user; ! if (!sizeof($this->question_ids)) { return false; *************** *** 464,470 **** function load_answer() { global $db, $user; ! if (!sizeof($this->question_ids)) { return false; --- 464,470 ---- function load_answer() { global $db, $user; ! if (!sizeof($this->question_ids)) { return false; *************** *** 948,957 **** return $langs; } ! ! ! ! /** * Grab a question and bring it into a format the editor understands */ function acp_is_last($question_id) --- 948,955 ---- return $langs; } ! ! /** * Grab a question and bring it into a format the editor understands */ function acp_is_last($question_id) *************** *** 963,969 **** $sql = 'SELECT question_id FROM ' . CAPTCHA_QUESTIONS_TABLE . " WHERE lang_iso = '" . $db->sql_escape($config['default_lang']) . "' ! AND question_id <> " . (int) $question_id; $result = $db->sql_query_limit($sql, 1); $question = $db->sql_fetchrow($result); $db->sql_freeresult($result); --- 961,967 ---- $sql = 'SELECT question_id FROM ' . CAPTCHA_QUESTIONS_TABLE . " WHERE lang_iso = '" . $db->sql_escape($config['default_lang']) . "' ! AND question_id <> " . (int) $question_id; $result = $db->sql_query_limit($sql, 1); $question = $db->sql_fetchrow($result); $db->sql_freeresult($result); |
From: Henry S. <kel...@ph...> - 2009-10-27 08:43:51
|
Author: Kellanved Date: Tue Oct 27 08:43:00 2009 New Revision: 10235 Log: #53235 Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php (original) --- branches/phpBB-3_0_0/phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php Tue Oct 27 08:43:00 2009 *************** *** 617,637 **** } else if ($question_id && $action == 'delete') { ! if (confirm_box(true)) { ! $this->acp_delete_question($question_id); ! trigger_error($user->lang['QUESTION_DELETED'] . adm_back_link($list_url)); } else { ! confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields(array( ! 'question_id' => $question_id, ! 'action' => $action, ! 'configure' => 1, ! 'select_captcha' => $this->get_class_name(), ! )) ! ); } } else --- 617,644 ---- } else if ($question_id && $action == 'delete') { ! if ($this->get_class_name() !== $config['captcha_plugin'] || !$this->acp_is_last($question_id)) { ! if (confirm_box(true)) ! { ! $this->acp_delete_question($question_id); ! trigger_error($user->lang['QUESTION_DELETED'] . adm_back_link($list_url)); ! } ! else ! { ! confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields(array( ! 'question_id' => $question_id, ! 'action' => $action, ! 'configure' => 1, ! 'select_captcha' => $this->get_class_name(), ! )) ! ); ! } } else { ! trigger_error($user->lang['QA_ERROR_MSG'] . adm_back_link($list_url), E_USER_WARNING); } } else *************** *** 711,717 **** } else if ($submit) { ! trigger_error($user->lang['FORM_INVALID'] . adm_back_link($list_url)); } } } --- 718,724 ---- } else if ($submit) { ! trigger_error($user->lang['FORM_INVALID'] . adm_back_link($list_url), E_USER_WARNING); } } } *************** *** 789,799 **** */ function acp_get_question_input() { $question = array( 'question_text' => request_var('question_text', '', true), 'strict' => request_var('strict', false), 'lang_iso' => request_var('lang_iso', ''), ! 'answers' => explode("\n", request_var('answers', '', true)), ); return $question; --- 796,807 ---- */ function acp_get_question_input() { + $answers = request_var('answers', '', true); $question = array( 'question_text' => request_var('question_text', '', true), 'strict' => request_var('strict', false), 'lang_iso' => request_var('lang_iso', ''), ! 'answers' => (strlen($answers)) ? explode("\n", $answers) : '', ); return $question; *************** *** 908,919 **** } if (!isset($langs[$question_data['lang_iso']]) || ! !$question_data['question_text'] || ! !sizeof($question_data['answers'])) { return false; } - return true; } --- 916,927 ---- } if (!isset($langs[$question_data['lang_iso']]) || ! !strlen($question_data['question_text']) || ! !sizeof($question_data['answers']) || ! !is_array($question_data['answers'])) { return false; } return true; } *************** *** 940,945 **** --- 948,980 ---- return $langs; } + + + + /** + * Grab a question and bring it into a format the editor understands + */ + function acp_is_last($question_id) + { + global $config, $db; + + if ($question_id) + { + $sql = 'SELECT question_id + FROM ' . CAPTCHA_QUESTIONS_TABLE . " + WHERE lang_iso = '" . $db->sql_escape($config['default_lang']) . "' + AND question_id <> " . (int) $question_id; + $result = $db->sql_query_limit($sql, 1); + $question = $db->sql_fetchrow($result); + $db->sql_freeresult($result); + + if (!$question) + { + return true; + } + return false; + } + } } ?> \ No newline at end of file |
From: Meik S. <acy...@ph...> - 2009-10-26 13:59:48
|
Author: acydburn Date: Mon Oct 26 13:59:02 2009 New Revision: 10234 Log: Fix Bug #53185 (icon width/height adjustement for icons > 127px also applied on smilies) - related to r10088 Modified: branches/phpBB-3_0_0/phpBB/includes/acp/acp_icons.php Modified: branches/phpBB-3_0_0/phpBB/includes/acp/acp_icons.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/acp/acp_icons.php (original) --- branches/phpBB-3_0_0/phpBB/includes/acp/acp_icons.php Mon Oct 26 13:59:02 2009 *************** *** 89,104 **** continue; } ! // adjust the width and height to be lower than 128px while perserving the aspect ratio ! if ($img_size[0] > 127 && $img_size[0] > $img_size[1]) ! { ! $img_size[1] = (int) ($img_size[1] * (127 / $img_size[0])); ! $img_size[0] = 127; ! } ! else if ($img_size[1] > 127) { ! $img_size[0] = (int) ($img_size[0] * (127 / $img_size[1])); ! $img_size[1] = 127; } $_images[$path . $img]['file'] = $path . $img; --- 89,107 ---- continue; } ! // adjust the width and height to be lower than 128px while perserving the aspect ratio (for icons) ! if ($mode == 'icons') { ! if ($img_size[0] > 127 && $img_size[0] > $img_size[1]) ! { ! $img_size[1] = (int) ($img_size[1] * (127 / $img_size[0])); ! $img_size[0] = 127; ! } ! else if ($img_size[1] > 127) ! { ! $img_size[0] = (int) ($img_size[0] * (127 / $img_size[1])); ! $img_size[1] = 127; ! } } $_images[$path . $img]['file'] = $path . $img; *************** *** 363,369 **** if ($mode == 'smilies' && $action == 'create') { $smiley_count = $this->item_count($table); ! $addable_smileys_count = sizeof($images); foreach ($images as $image) { --- 366,372 ---- if ($mode == 'smilies' && $action == 'create') { $smiley_count = $this->item_count($table); ! $addable_smileys_count = sizeof($images); foreach ($images as $image) { *************** *** 372,378 **** --$addable_smileys_count; } } ! if ($smiley_count + $addable_smileys_count > SMILEY_LIMIT) { trigger_error(sprintf($user->lang['TOO_MANY_SMILIES'], SMILEY_LIMIT) . adm_back_link($this->u_action), E_USER_WARNING); --- 375,381 ---- --$addable_smileys_count; } } ! if ($smiley_count + $addable_smileys_count > SMILEY_LIMIT) { trigger_error(sprintf($user->lang['TOO_MANY_SMILIES'], SMILEY_LIMIT) . adm_back_link($this->u_action), E_USER_WARNING); *************** *** 400,414 **** $image_height[$image] = $img_size[1]; } ! if ($image_width[$image] > 127 && $image_width[$image] > $image_height[$image]) ! { ! $image_height[$image] = (int) ($image_height[$image] * (127 / $image_width[$image])); ! $image_width[$image] = 127; ! } ! else if ($image_height[$image] > 127) { ! $image_width[$image] = (int) ($image_width[$image] * (127 / $image_height[$image])); ! $image_height[$image] = 127; } $img_sql = array( --- 403,421 ---- $image_height[$image] = $img_size[1]; } ! // Adjust image width/height for icons ! if ($mode == 'icons') { ! if ($image_width[$image] > 127 && $image_width[$image] > $image_height[$image]) ! { ! $image_height[$image] = (int) ($image_height[$image] * (127 / $image_width[$image])); ! $image_width[$image] = 127; ! } ! else if ($image_height[$image] > 127) ! { ! $image_width[$image] = (int) ($image_width[$image] * (127 / $image_height[$image])); ! $image_height[$image] = 127; ! } } $img_sql = array( *************** *** 923,929 **** generate_pagination($this->u_action, $item_count, $config['smilies_per_page'], $pagination_start, true) ); } ! /** * Returns the count of smilies or icons in the database * --- 930,936 ---- generate_pagination($this->u_action, $item_count, $config['smilies_per_page'], $pagination_start, true) ); } ! /** * Returns the count of smilies or icons in the database * |
From: Meik S. <acy...@ph...> - 2009-10-25 09:03:22
|
Author: acydburn Date: Sun Oct 25 09:03:05 2009 New Revision: 10233 Log: Fix Bug #53175 (forum_options cleared if editing forum) - regression from r10024 Modified: branches/phpBB-3_0_0/phpBB/includes/acp/acp_forums.php Modified: branches/phpBB-3_0_0/phpBB/includes/acp/acp_forums.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/acp/acp_forums.php (original) --- branches/phpBB-3_0_0/phpBB/includes/acp/acp_forums.php Sun Oct 25 09:03:05 2009 *************** *** 125,131 **** 'type_action' => request_var('type_action', ''), 'forum_status' => request_var('forum_status', ITEM_UNLOCKED), 'forum_parents' => '', - 'forum_options' => 0, 'forum_name' => utf8_normalize_nfc(request_var('forum_name', '', true)), 'forum_link' => request_var('forum_link', ''), 'forum_link_track' => request_var('forum_link_track', false), --- 125,130 ---- *************** *** 159,164 **** --- 158,169 ---- 'forum_password_unset' => request_var('forum_password_unset', false), ); + // On add, add empty forum_options... else do not consider it (not updating it) + if ($action == 'add') + { + $forum_data['forum_options'] = 0; + } + // Use link_display_on_index setting if forum type is link if ($forum_data['forum_type'] == FORUM_LINK) { |
From: Chris S. <too...@ph...> - 2009-10-24 23:15:59
|
Author: toonarmy Date: Sun Oct 25 00:15:10 2009 New Revision: 10232 Log: changelog more descriptive for #45805 r9633 Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html ============================================================================== *** branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html (original) --- branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html Sun Oct 25 00:15:10 2009 *************** *** 221,227 **** <li>[Change] Ability to define column split in FAQ/BBCode help. (Bug #31405)</li> <li>[Change] Changed behaviour of group_create() function to support specifying additional group columns.</li> <li>[Change] Hide avatar when avatar-type is not allowed. (Bug #46785 - Patch by cYbercOsmOnauT and nickvergessen)</li> ! <li>[Change] INCLUDEPHP no longer depends on $phpbb_root_path. (Bug #45805)</li> <li>[Change] Ability to fetch moderators with get_moderators() even if load_moderators setting is off. (Bug #35955)</li> <li>[Change] "Post details" links with image in MCP. (Bug #39845 - Patch by leviatan21)</li> <li>[Change] PM history now only shows PMs of users you currently reply to. (Bug #39505)</li> --- 221,227 ---- <li>[Change] Ability to define column split in FAQ/BBCode help. (Bug #31405)</li> <li>[Change] Changed behaviour of group_create() function to support specifying additional group columns.</li> <li>[Change] Hide avatar when avatar-type is not allowed. (Bug #46785 - Patch by cYbercOsmOnauT and nickvergessen)</li> ! <li>[Change] INCLUDEPHP paths are now relative to $phpbb_root_path. (Bug #45805)</li> <li>[Change] Ability to fetch moderators with get_moderators() even if load_moderators setting is off. (Bug #35955)</li> <li>[Change] "Post details" links with image in MCP. (Bug #39845 - Patch by leviatan21)</li> <li>[Change] PM history now only shows PMs of users you currently reply to. (Bug #39505)</li> |
From: Meik S. <acy...@ph...> - 2009-10-24 14:29:51
|
Author: acydburn Date: Sat Oct 24 15:28:59 2009 New Revision: 10231 Log: fix table creation in db_tools. Modified: branches/phpBB-3_0_0/phpBB/includes/db/db_tools.php Modified: branches/phpBB-3_0_0/phpBB/includes/db/db_tools.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/db/db_tools.php (original) --- branches/phpBB-3_0_0/phpBB/includes/db/db_tools.php Sat Oct 24 15:28:59 2009 *************** *** 453,463 **** --- 453,469 ---- case 'firebird': case 'mssql': + // We need the data here + $old_return_statements = $this->return_statements; + $this->return_statements = true; + $primary_key_stmts = $this->sql_create_primary_key($table_name, $table_data['PRIMARY_KEY']); foreach ($primary_key_stmts as $pk_stmt) { $statements[] = $pk_stmt; } + + $this->return_statements = $old_return_statements; break; case 'oracle': |
From: Meik S. <acy...@ph...> - 2009-10-24 14:29:05
|
Author: acydburn Date: Sat Oct 24 15:28:41 2009 New Revision: 10230 Log: two obvious mistakes (thanks Jon :)) Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html ============================================================================== *** branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html (original) --- branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html Sat Oct 24 15:28:41 2009 *************** *** 235,241 **** <li>[Change] Cache version check.</li> <li>[Change] When creating a new forum without copying permissions, ask again.</li> <li>[Change] Introduce new parameter to page_header() for forum specific who is online listings.</li> ! <li>[Change] Lifted minimum requirement for Firebird DBMS from 2.0+ to 2.1+.</li> <li>[Change] Unapproved topics can no longer be replied to. (Bug #44005, #47675, #23605)</li> <li>[Change] Require user to be registered and logged in to search for unread posts if topic read tracking is disabled for guests. (Bug #49525)</li> <li>[Change] Allow three-digit hex notation in color BBcode. (Bug #39965 - Patch by m0rpha)</li> --- 235,241 ---- <li>[Change] Cache version check.</li> <li>[Change] When creating a new forum without copying permissions, ask again.</li> <li>[Change] Introduce new parameter to page_header() for forum specific who is online listings.</li> ! <li>[Change] Changed minimum requirement for Firebird DBMS from 2.0+ to 2.1+.</li> <li>[Change] Unapproved topics can no longer be replied to. (Bug #44005, #47675, #23605)</li> <li>[Change] Require user to be registered and logged in to search for unread posts if topic read tracking is disabled for guests. (Bug #49525)</li> <li>[Change] Allow three-digit hex notation in color BBcode. (Bug #39965 - Patch by m0rpha)</li> *************** *** 244,250 **** <li>[Change] Resize oversized topic icons. (Bug #44415)</li> <li>[Change] Banned IPs are now sorted. (Bug #43045 - Patch by DavidIQ)</li> <li>[Change] phpBB updater now skips sole whitespace/tab changes while computing differences. This reduces the chance of conflicts tremendously.</li> ! <li>[Change] phpBB updater now solves common conflicts on it's own. This further reduces the chance of conflicts.</li> <li>[Feature] Add language selection to the registration terms page. (Bug #15085 - Patch by leviatan21)</li> <li>[Feature] Backported 3.2 captcha plugins: <ul> --- 244,250 ---- <li>[Change] Resize oversized topic icons. (Bug #44415)</li> <li>[Change] Banned IPs are now sorted. (Bug #43045 - Patch by DavidIQ)</li> <li>[Change] phpBB updater now skips sole whitespace/tab changes while computing differences. This reduces the chance of conflicts tremendously.</li> ! <li>[Change] phpBB updater now solves common conflicts on its own. This further reduces the chance of conflicts.</li> <li>[Feature] Add language selection to the registration terms page. (Bug #15085 - Patch by leviatan21)</li> <li>[Feature] Backported 3.2 captcha plugins: <ul> |
From: Meik S. <acy...@ph...> - 2009-10-24 13:05:12
|
Author: acydburn Date: Sat Oct 24 14:04:26 2009 New Revision: 10229 Log: revert r9910 - ticket #1309 Reason for revert: http://www.phpbb.com/bugs/phpbb3/ticket.php?ticket_id=1309&start=8#post193395 Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html branches/phpBB-3_0_0/phpBB/includes/message_parser.php Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html ============================================================================== *** branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html (original) --- branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html Sat Oct 24 14:04:26 2009 *************** *** 234,240 **** <li>[Change] Cache get_username_string() function calls on viewtopic.</li> <li>[Change] Cache version check.</li> <li>[Change] When creating a new forum without copying permissions, ask again.</li> - <li>[Change] Parse multiline url title for [url] BBCode tag. (Bug #1309)</li> <li>[Change] Introduce new parameter to page_header() for forum specific who is online listings.</li> <li>[Change] Lifted minimum requirement for Firebird DBMS from 2.0+ to 2.1+.</li> <li>[Change] Unapproved topics can no longer be replied to. (Bug #44005, #47675, #23605)</li> --- 234,239 ---- Modified: branches/phpBB-3_0_0/phpBB/includes/message_parser.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/message_parser.php (original) --- branches/phpBB-3_0_0/phpBB/includes/message_parser.php Sat Oct 24 14:04:26 2009 *************** *** 115,121 **** 'attachment' => array('bbcode_id' => 12, 'regexp' => array('#\[attachment=([0-9]+)\](.*?)\[/attachment\]#ise' => "\$this->bbcode_attachment('\$1', '\$2')")), 'b' => array('bbcode_id' => 1, 'regexp' => array('#\[b\](.*?)\[/b\]#ise' => "\$this->bbcode_strong('\$1')")), 'i' => array('bbcode_id' => 2, 'regexp' => array('#\[i\](.*?)\[/i\]#ise' => "\$this->bbcode_italic('\$1')")), ! 'url' => array('bbcode_id' => 3, 'regexp' => array('#\[url(=(.*))?\]((?s).*)\[/url\]#iUe' => "\$this->validate_url('\$2', '\$3')")), 'img' => array('bbcode_id' => 4, 'regexp' => array('#\[img\](.*)\[/img\]#iUe' => "\$this->bbcode_img('\$1')")), 'size' => array('bbcode_id' => 5, 'regexp' => array('#\[size=([\-\+]?\d+)\](.*?)\[/size\]#ise' => "\$this->bbcode_size('\$1', '\$2')")), 'color' => array('bbcode_id' => 6, 'regexp' => array('!\[color=(#[0-9a-f]{3}|#[0-9a-f]{6}|[a-z\-]+)\](.*?)\[/color\]!ise' => "\$this->bbcode_color('\$1', '\$2')")), --- 115,121 ---- 'attachment' => array('bbcode_id' => 12, 'regexp' => array('#\[attachment=([0-9]+)\](.*?)\[/attachment\]#ise' => "\$this->bbcode_attachment('\$1', '\$2')")), 'b' => array('bbcode_id' => 1, 'regexp' => array('#\[b\](.*?)\[/b\]#ise' => "\$this->bbcode_strong('\$1')")), 'i' => array('bbcode_id' => 2, 'regexp' => array('#\[i\](.*?)\[/i\]#ise' => "\$this->bbcode_italic('\$1')")), ! 'url' => array('bbcode_id' => 3, 'regexp' => array('#\[url(=(.*))?\](.*)\[/url\]#iUe' => "\$this->validate_url('\$2', '\$3')")), 'img' => array('bbcode_id' => 4, 'regexp' => array('#\[img\](.*)\[/img\]#iUe' => "\$this->bbcode_img('\$1')")), 'size' => array('bbcode_id' => 5, 'regexp' => array('#\[size=([\-\+]?\d+)\](.*?)\[/size\]#ise' => "\$this->bbcode_size('\$1', '\$2')")), 'color' => array('bbcode_id' => 6, 'regexp' => array('!\[color=(#[0-9a-f]{3}|#[0-9a-f]{6}|[a-z\-]+)\](.*?)\[/color\]!ise' => "\$this->bbcode_color('\$1', '\$2')")), |
From: Meik S. <acy...@ph...> - 2009-10-22 14:36:40
|
Author: acydburn Date: Thu Oct 22 15:35:56 2009 New Revision: 10228 Log: sneaks in and changes the version number. Seems like we see no RC4... Modified: branches/phpBB-3_0_0/phpBB/includes/constants.php branches/phpBB-3_0_0/phpBB/install/database_update.php branches/phpBB-3_0_0/phpBB/install/schemas/schema_data.sql Modified: branches/phpBB-3_0_0/phpBB/includes/constants.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/constants.php (original) --- branches/phpBB-3_0_0/phpBB/includes/constants.php Thu Oct 22 15:35:56 2009 *************** *** 25,31 **** */ // phpBB Version ! define('PHPBB_VERSION', '3.0.6-RC3'); // QA-related // define('PHPBB_QA', 1); --- 25,31 ---- */ // phpBB Version ! define('PHPBB_VERSION', '3.0.6'); // QA-related // define('PHPBB_QA', 1); Modified: branches/phpBB-3_0_0/phpBB/install/database_update.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/install/database_update.php (original) --- branches/phpBB-3_0_0/phpBB/install/database_update.php Thu Oct 22 15:35:56 2009 *************** *** 8,14 **** * */ ! $updates_to_version = '3.0.6-RC3'; // Enter any version to update from to test updates. The version within the db will not be updated. $debug_from_version = false; --- 8,14 ---- * */ ! $updates_to_version = '3.0.6'; // Enter any version to update from to test updates. The version within the db will not be updated. $debug_from_version = false; *************** *** 885,890 **** --- 885,892 ---- ), // No changes from 3.0.6-RC2 to 3.0.6-RC3 '3.0.6-RC2' => array(), + // No changes from 3.0.6-RC3 to 3.0.6 + '3.0.6-RC3' => array(), ); } *************** *** 1528,1533 **** --- 1530,1539 ---- $no_updates = false; break; + + // No changes from 3.0.6-RC3 to 3.0.6 + case '3.0.6-RC3': + break; } } Modified: branches/phpBB-3_0_0/phpBB/install/schemas/schema_data.sql ============================================================================== *** branches/phpBB-3_0_0/phpBB/install/schemas/schema_data.sql (original) --- branches/phpBB-3_0_0/phpBB/install/schemas/schema_data.sql Thu Oct 22 15:35:56 2009 *************** *** 239,245 **** INSERT INTO phpbb_config (config_name, config_value) VALUES ('tpl_allow_php', '0'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_icons_path', 'images/upload_icons'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_path', 'files'); ! INSERT INTO phpbb_config (config_name, config_value) VALUES ('version', '3.0.6-RC3'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_expire_days', '90'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_gc', '14400'); --- 239,245 ---- INSERT INTO phpbb_config (config_name, config_value) VALUES ('tpl_allow_php', '0'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_icons_path', 'images/upload_icons'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('upload_path', 'files'); ! INSERT INTO phpbb_config (config_name, config_value) VALUES ('version', '3.0.6'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_expire_days', '90'); INSERT INTO phpbb_config (config_name, config_value) VALUES ('warnings_gc', '14400'); |
From: Meik S. <acy...@ph...> - 2009-10-21 19:57:29
|
Author: acydburn Date: Wed Oct 21 20:56:40 2009 New Revision: 10227 Log: adjust changelog (spelling, etc.) and removed our loved JD's from the patch lines (they are now listed within the AUTHORS file). Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html Modified: branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html ============================================================================== *** branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html (original) --- branches/phpBB-3_0_0/phpBB/docs/CHANGELOG.html Wed Oct 21 20:56:40 2009 *************** *** 90,203 **** <ul> <li>[Fix] Allow whitespaces in avatar gallery names. (Bug #44955)</li> <li>[Fix] Sorting by author or subject on viewtopic now preserves the order. (Bug #44875)</li> ! <li>[Fix] Correctly determine writable status of files on Windows operating system. (Bug #39035)</li> ! <li>[Fix] Show report button in prosilver for guests who are allowed to report posts. (Bug #45695 - Patch by bantu)</li> ! <li>[Fix] Correctly show private message history (Bug #46065 - Patch by bantu)</li> ! <li>[Fix] Various XHTML mistakes in prosilver, subsilver2 and the ACP. (Bugs #25545 - Patch by bantu, #26315, #38555, #45505 - Patch by Raimon, #45785, #45865, #47085 - Patch by Raimon)</li> ! <li>[Fix] Fix some ACP style issues (Bug #16109 - Patch by prototech)</li> ! <li>[Fix] Move post bump information markup to the template. (Bug #34295 - Patch by bantu)</li> ! <li>[Fix] Show error in the ACP when template folder is not readable. (Bug #45705 - Patch by bantu)</li> ! <li>[Fix] Adjust viewonline filename regular expression to be less strict. (Bug #46215 - Patch by bantu)</li> ! <li>[Fix] Correctly apply the can change vote permission again. Regression introduced in r9470. (Bug #45895)</li> ! <li>[Fix] Also remove data from friend/foe table when deleting user. (Bug #45345 - Patch by nickvergessen)</li> <li>[Fix] Correctly hide skiplink in prosilver right-to-left mode. (Bug #45765 - Patch by prototech and bantu)</li> ! <li>[Fix] Fix dynamic config update routine error if firebird is used (Bug #46315)</li> ! <li>[Fix] Allow friends/foes to be added and removed at the same time. (Bug #46255 - Patch by bantu)</li> ! <li>[Fix] Only change topic/post icon if icons are enabled and user is allowed to. (Bug #46355 - Patch by bantu)</li> <li>[Fix] Fix saving custom profile fields in ACP if Oracle is used. (Bug #46015)</li> <li>[Fix] Make view_log() more resilient to corrupt serialized data. (Bug #46545)</li> ! <li>[Fix] Show error if hostname lookup doesn't return a valid IP address when banning. (Bug #45585 - Patch by bantu)</li> <li>[Fix] Fix incorrect layout when loading private message draft. (Bug #38435 - Patch by nickvergessen)</li> ! <li>[Fix] Show proper error message when trying to add bots to friends/foes list. (Bug #40205 - Patch by nickvergessen)</li> ! <li>[Fix] Fix Oracle database backup (Bug #46715)</li> ! <li>[Fix] Update attachments table when deleting user and retaining his posts. (Bug #40245 - Patch by rxu)</li> ! <li>[Fix] Correctly detect files in subfolders when viewing cached template files. (Bug #46145 - Patch by nickvergessen)</li> ! <li>[Fix] Display user's Jabber address in popup when Jabber functionality is disabled (Bug #20775 - Patch by nickvergessen)</li> ! <li>[Fix] Correctly exclude forums from active topics list. (Bug #19135 - Patch by nickvergessen)</li> ! <li>[Fix] Do not display birthdays of banned users (Bug #20625 - Patch by nickvergessen)</li> ! <li>[Fix] Fix function to recalculate Nested Sets (Bug #41555 - Patch by EXreaction)</li> ! <li>[Fix] Display but also highlight already used rank images when creating new ranks. (Bug #22665 - Patch by nickvergessen)</li> ! <li>[Fix] Correctly orientate quoted text image on RTL languages (Bug #33745 - Patch by nickvergessen)</li> ! <li>[Fix] Do not display "View user notes" and "Warn user" links in user profile if corresponding MCP modules are disabled. (Bug #10519 - Patch by rxu)</li> ! <li>[Fix] Show proper error message when trying to create a private messages folder with an empty name. (Bug #39875 - Patch by nickvergessen)</li> ! <li>[Fix] No longer state that it is possible to manage group leaders from the UCP. (Bug #19945 - Patch by nickvergessen)</li> <li>[Fix] Do not throw an error when PDO is a shared module and not loaded preventing SQLite from being loaded.</li> ! <li>[Fix] Fix censoring of unicode words. (Bug #16555 - Patches by rxu)</li> ! <li>[Fix] Display coloured usernames in ACP groups management screens</li> ! <li>[Fix] Correctly describe founder permissions on trace-information (Bug #37235 - Patch by nickvergessen)</li> ! <li>[Fix] Correct the width value for poll_center.gif omitted in imageset.cfg for subsilver2. (Bug #43005 - Patch by rxu)</li> ! <li>[Fix] Correctly load complex language variable using acp_language (Bug #45735 - Patch by leviatan21)</li> ! <li>[Fix] Fix reapply_sid() to correctly strip session id in certain circumstances (Bug #43125 - Patch by leviatan21)</li> ! <li>[Fix] Correctly state why one language pack is marked with an asterisk in the ACP. (Bug #37565 - Patch by bantu)</li> ! <li>[Fix] Correctly check if install directory is still present. (Bug #46965 - Patch by rxu)</li> ! <li>[Fix] Correct banned user behaviour when "force password change" is enabled (Bug #47145 - Patch by nickvergessen and leviatan21)</li> <li>[Fix] Correctly display ACP logs options, without permission to clear logs. (Bug #24155 - Patch by leviatan21)</li> <li>[Fix] Display topic icons in MCP forum view again (only prosilver).</li> <li>[Fix] Properly display post status messages in topic when post is reported and unapproved (Bug #44455 - Patch by leviatan21)</li> ! <li>[Fix] Do not remove recipients when loading private message draft. (Bug #38395 - Patch by nickvergessen)</li> ! <li>[Fix] Add author name to moderator log when deleting post/topic. (Bug #46225 - Patch by nickvergessen)</li> ! <li>[Fix] Fix broken "Report details" link in the MCP. (Bug #46975 - Patch by nickvergessen)</li> ! <li>[Fix] Resolve accesskey conflicts in prosilver. (Bug #44685 - Patch by bantu)</li> ! <li>[Fix] Check if template file is empty before trying to read from it. (Bug #47345 - Patch by bantu)</li> ! <li>[Fix] Correct descriptions of the permissions to use BBCode, smilies, images and flash to be more relevant. (Bug #36065 - Patch by rxu)</li> <li>[Fix] Fix style issues in print mode. (Bug #26375 - Patch by leviatan21)</li> ! <li>[Fix] Fix minor issue with L_QUOTE language string missing in several PM composing modes. (Bug #39625 - Patch by rxu)</li> ! <li>[Fix] Also fetch posts of guests and deleted or deactivated users when searching for author names. (Bug #36565, #47765 - Patch by nickvergessen)</li> <li>[Fix] Show end of ban in MCP and ACP when user is banned by duration. (Bug #47815 - Patch by Pyramide)</li> ! <li>[Fix] Correctly count posts awaiting approval in the MCP. (Bug #47685 - Patch by nickvergessen)</li> ! <li>[Fix] Display user's posts count in private message when it is equal to 0 (prosilver). (Bug #40155 - Patch by rxu)</li> <li>[Fix] Only allow users to disable word censor if globally allowed. (Bug #47575 - Patch by 00mohgta7)</li> ! <li>[Fix] Fix database updater and db tools to support multiple column changes/additions/removals with SQLite</li> ! <li>[Fix] Correctly detect GZIP status in debug mode. (Bug #24075 - Patch by rxu)</li> ! <li>[Fix] Posting smilies in view more smilies now work again in IE (Bug #46025 - Patch by leviatan21)</li> ! <li>[Fix] Properly convert and show filesize information. (Bug #47775 - Patch by bantu)</li> ! <li>[Fix] Add ability to prune users who never logged in. (Bug #44295 - Patch by rxu)</li> ! <li>[Fix] Show smilies and images in topic print view. (Bug #47265 - Patch by nickvergessen)</li> ! <li>[Fix] Force full date in private message print view. (Patch by nickvergessen)</li> ! <li>[Fix] Fix "Always show a scrollbar for short pages" for IE8 and Firefox 3.5 (Bug #47865 - Patch by stokerpiller)</li> ! <li>[Fix] Do not allow setting group as default group for pending users. (Bug #45675 - Patch by nickvergessen)</li> <li>[Fix] Fail gracefully if store folder is not writable during update. (Bugs #46615, #46945)</li> ! <li>[Fix] Hide profile-icon from viewtopic-page if user has no permissions (subsilver2 only) (Bug #37635 - Patch by leviatan21)</li> <li>[Fix] Correct escaping/unescaping in the LDAP authentication plugin. (Bug #48175)</li> <li>[Fix] Add hard limit for smilies.</li> <li>[Fix] Remove redundant SQL query from ucp.php. (Bug #40305)</li> ! <li>[Fix] Reorder frame order of animated subsilver2 topic icons to be useful when animation is disabled. (Bug #29385 - Patch by prototech)</li> <li>[Fix] Ensure user errors are displayed regardless of PHP settings. (Bug #47505)</li> <li>[Fix] Permit null values for non-required integer custom profile fields and ensure zero complies with the range limits. (Bug #40925)</li> <li>[Fix] Allow changing forum from select box under certain circumstances. (Bug #37525)</li> <li>[Fix] Display required fields notice on registration above the custom profile fields. (Bug #39665)</li> <li>[Fix] Copy poll options properly when copying topic. (Bug #39065)</li> ! <li>[Fix] Fix error with disapproval of topics having several queued posts only. (Bug #47705 - Patch by rxu)</li> ! <li>[Fix] Preserve newlines in template files (one newline had been always dropped after a template variable due to PHP's handling of closing tags)</li> ! <li>[Fix] Be less strict with FTP daemons when getting directory filelists. (Bug #46295)</li> ! <li>[Fix] Fix set_custom_template for database-stored styles (Bug #40515 - Patch by nickvergessen)</li> ! <li>[Fix] Banning an already banned user states to be successful, but has no effect (Bug #47825 - Patch by Pyramide)</li> ! <li>[Fix] Do not add style-parameter to URL again, after admin re-authentification (Bug #18005 - Patch by leviatan21)</li> ! <li>[Fix] Do not cut post-message in between HTML-Entities on search.php (Bug #31505 - Patch by leviatan21)</li> ! <li>[Fix] Correctly set attachment flag for topics, posts and pms after deleting attachments (Bug #48265 - Patch by MarcoDM and nickvergessen)</li> <li>[Fix] Display "Locked" button instead of "Reply" one for locked forum in viewtopic (prosilver). (Bug #38055 - Patch by Raimon)</li> ! <li>[Fix] Correctly propagate umlauts over search result pages (Bug #33755)</li> <li>[Fix] Preserve post options when refusing to save the post as a draft. (Bug #39115)</li> <li>[Fix] Do not send private message back to sender if sender is in the same group the private message was sent to.</li> ! <li>[Fix] Correctly add user to a group making it a default one. (Bug #48345 - Patch by rxu)</li> <li>[Fix] Add log entry when copying forum permissions.</li> ! <li>[Fix] Min/max characters per posts no longer affects poll options (Bug #47295 - Patch by nickvergessen)</li> ! <li>[Fix] Correctly log action when users request to join a group (Bug #37585 - Patch by nickvergessen)</li> <li>[Fix] Do not try to create thumbnails for images we cannot open properly. (Bug #48695)</li> <li>[Fix] Apply locale-independent basename() to attachment filenames. New function added: utf8_basename(). (Bug #43335 - Patch by ocean=Yohsuke)</li> <li>[Fix] Adjust build_url() to not prepend $phpbb_root_path if path returned from redirect() is an URL. This fixes redirect issues with some installations and bridges. (Bug #47535)</li> <li>[Fix] Do not mark global announcements as read if all topics in a forum become read (Bug #15729).</li> ! <li>[Fix] Fix general error while registration, through undefined variable $config in validate_referer (Bug #49035 - Patch by wjvriend)</li> <li>[Fix] Correctly extract column default value when exporting PostgreSQL tables. (Bug #48955)</li> <li>[Fix] Allow updater to work correctly with PHP filename extensions other than ".php". (Bugs #15809, #49215)</li> <li>[Fix] Update search index if only post subject changed. (Bug #49435)</li> <li>[Fix] Fix who is online displaying incorrect data. (Bug #49485, thanks Brainy)</li> ! <li>[Fix] Fixed incorrect "topic does not exist" when unapproved posts were visited without global moderator permissions. (Bug #47795)</li> <li>[Fix] Prevent style switcher from blocking the tab key. (Bug #49335)</li> ! <li>[Fix] Correctly redirect on MCP main page after posts approval/disapproval from it. (Bug #49625)</li> <li>[Fix] Do not display topic approval status image for shadow topic if a user is not a moderator in the forum the topic has been moved to. (Bug #43295)</li> ! <li>[Fix] Fix email problems on servers with PHP installations not accepting RFC-compliant subject string passed to the the mail()-function. (Bug #46725)</li> ! <li>[Fix] Correctly orientate Control-Panel-Navigation background-image on RTL languages. (Bug #49945)</li> <li>[Fix] Sort private messages by message time and not message id. (Bug #50015)</li> <li>[Fix] Make sure only logs for existing users are displayed and user-specific logs removed on user deletion. (Bug #49855)</li> <li>[Fix] Only show "Add friend" and "Add foe" links if the specific module is enabled. (Bug #50475)</li> --- 90,203 ---- <ul> <li>[Fix] Allow whitespaces in avatar gallery names. (Bug #44955)</li> <li>[Fix] Sorting by author or subject on viewtopic now preserves the order. (Bug #44875)</li> ! <li>[Fix] Correctly determine writable status of files on Windows operating systems. (Bug #39035)</li> ! <li>[Fix] Show report button in prosilver for guests who are allowed to report posts. (Bug #45695)</li> ! <li>[Fix] Correctly show private message history. (Bug #46065)</li> ! <li>[Fix] Various XHTML mistakes in prosilver, subsilver2 and the ACP. (Bugs #25545, #26315, #38555, #45505 - Patch by Raimon, #45785, #45865, #47085 - Patch by Raimon)</li> ! <li>[Fix] Fix some ACP style issues. (Bug #16109 - Patch by prototech)</li> ! <li>[Fix] Move post bump information markup to the template. (Bug #34295)</li> ! <li>[Fix] Show error in the ACP when template folder is not readable. (Bug #45705)</li> ! <li>[Fix] Adjust viewonline filename regular expression to be less strict. (Bug #46215)</li> ! <li>[Fix] Correctly apply the "can change vote" permission again. Regression introduced in r9470. (Bug #45895)</li> ! <li>[Fix] Remove data from friend/foe table when deleting user. (Bug #45345)</li> <li>[Fix] Correctly hide skiplink in prosilver right-to-left mode. (Bug #45765 - Patch by prototech and bantu)</li> ! <li>[Fix] Fix dynamic config update routine error if firebird is used. (Bug #46315)</li> ! <li>[Fix] Allow friends/foes to be added and removed at the same time. (Bug #46255)</li> ! <li>[Fix] Only change topic/post icon on edit if icons are enabled and user is allowed to use icons. (Bug #46355)</li> <li>[Fix] Fix saving custom profile fields in ACP if Oracle is used. (Bug #46015)</li> <li>[Fix] Make view_log() more resilient to corrupt serialized data. (Bug #46545)</li> ! <li>[Fix] Show error if hostname lookup doesn't return a valid IP address when banning. (Bug #45585)</li> <li>[Fix] Fix incorrect layout when loading private message draft. (Bug #38435 - Patch by nickvergessen)</li> ! <li>[Fix] Show proper error message when trying to add bots to friends/foes list. (Bug #40205)</li> ! <li>[Fix] Fixed database backup and restore with Oracle DBMS. (Bug #46715)</li> ! <li>[Fix] Update attachments table when deleting user and retaining his posts. (Bug #40245)</li> ! <li>[Fix] Correctly detect files in subfolders when viewing cached template files. (Bug #46145)</li> ! <li>[Fix] Display user's jabber address in popup if jabber functionality is disabled. (Bug #20775)</li> ! <li>[Fix] Correctly exclude forums from active topics list. (Bug #19135)</li> ! <li>[Fix] Do not display banned users in birthday list. (Bug #20625)</li> ! <li>[Fix] Fix function to recalculate nested sets. (Bug #41555 - Patch by EXreaction)</li> ! <li>[Fix] Display but also highlight already used rank images while assigning new ranks. (Bug #22665)</li> ! <li>[Fix] Correctly orientate quoted text image on RTL languages. (Bug #33745)</li> ! <li>[Fix] Do not display "View user notes" and "Warn user" links in user profile if corresponding MCP modules are disabled. (Bug #10519)</li> ! <li>[Fix] Show proper error message when trying to create a private messages folder with an empty name. (Bug #39875)</li> ! <li>[Fix] No longer state that it is possible to manage group leaders from the UCP. (Bug #19945)</li> <li>[Fix] Do not throw an error when PDO is a shared module and not loaded preventing SQLite from being loaded.</li> ! <li>[Fix] Fix censoring of unicode words. (Bug #16555)</li> ! <li>[Fix] Display coloured usernames in ACP groups management screens.</li> ! <li>[Fix] Correctly describe founder permissions on trace-information. (Bug #37235)</li> ! <li>[Fix] Correct the width value for poll_center.gif omitted in imageset.cfg for subsilver2. (Bug #43005)</li> ! <li>[Fix] Correctly load complex language variable using acp_language. (Bug #45735 - Patch by leviatan21)</li> ! <li>[Fix] Fix reapply_sid() to correctly strip session id in certain circumstances. (Bug #43125 - Patch by leviatan21)</li> ! <li>[Fix] Correctly state why one language pack is marked with an asterisk in the ACP. (Bug #37565)</li> ! <li>[Fix] Correctly check if install directory is still present. (Bug #46965)</li> ! <li>[Fix] Correct banned user behaviour when "force password change" is enabled. (Bug #47145 - Patch by nickvergessen and leviatan21)</li> <li>[Fix] Correctly display ACP logs options, without permission to clear logs. (Bug #24155 - Patch by leviatan21)</li> <li>[Fix] Display topic icons in MCP forum view again (only prosilver).</li> <li>[Fix] Properly display post status messages in topic when post is reported and unapproved (Bug #44455 - Patch by leviatan21)</li> ! <li>[Fix] Do not remove recipients when loading private message draft. (Bug #38395)</li> ! <li>[Fix] Add author name to moderator log when deleting post/topic. (Bug #46225)</li> ! <li>[Fix] Fix broken "Report details" link in the MCP. (Bug #46975)</li> ! <li>[Fix] Resolve accesskey conflicts in prosilver. (Bug #44685)</li> ! <li>[Fix] Check if template file is empty before trying to read from it. (Bug #47345)</li> ! <li>[Fix] More descriptive descriptions for permissions to use BBCode, smilies, images and flash. (Bug #36065)</li> <li>[Fix] Fix style issues in print mode. (Bug #26375 - Patch by leviatan21)</li> ! <li>[Fix] Fix minor issue with L_QUOTE language string missing in several PM composing modes. (Bug #39625)</li> ! <li>[Fix] Also fetch posts of guests and deleted or deactivated users while searching for author names. (Bug #36565, #47765)</li> <li>[Fix] Show end of ban in MCP and ACP when user is banned by duration. (Bug #47815 - Patch by Pyramide)</li> ! <li>[Fix] Correctly count posts awaiting approval in the MCP. (Bug #47685)</li> ! <li>[Fix] Display user's posts count in private message when it is equal to 0 (prosilver). (Bug #40155)</li> <li>[Fix] Only allow users to disable word censor if globally allowed. (Bug #47575 - Patch by 00mohgta7)</li> ! <li>[Fix] Fix database updater and db tools to support multiple column changes/additions/removals with SQLite.</li> ! <li>[Fix] Correctly detect GZIP status in debug mode. (Bug #24075)</li> ! <li>[Fix] Posting smilies in view more smilies screen now works again in IE. (Bug #46025 - Patch by leviatan21)</li> ! <li>[Fix] Properly convert and show filesize information. (Bug #47775)</li> ! <li>[Fix] Add ability to prune users who never logged in. (Bug #44295)</li> ! <li>[Fix] Show smilies and images in topic print view. (Bug #47265)</li> ! <li>[Fix] Force full date in private message print view.</li> ! <li>[Fix] Fix "Always show a scrollbar for short pages" for IE8 and Firefox 3.5. (Bug #47865 - Patch by stokerpiller)</li> ! <li>[Fix] Do not allow setting group as default group for pending users. (Bug #45675)</li> <li>[Fix] Fail gracefully if store folder is not writable during update. (Bugs #46615, #46945)</li> ! <li>[Fix] Hide profile-icon from viewtopic page if user has no permissions (subsilver2 only). (Bug #37635 - Patch by leviatan21)</li> <li>[Fix] Correct escaping/unescaping in the LDAP authentication plugin. (Bug #48175)</li> <li>[Fix] Add hard limit for smilies.</li> <li>[Fix] Remove redundant SQL query from ucp.php. (Bug #40305)</li> ! <li>[Fix] Reorder frame order of animated subsilver2 topic icons to be useful when animations are disabled. (Bug #29385 - Patch by prototech)</li> <li>[Fix] Ensure user errors are displayed regardless of PHP settings. (Bug #47505)</li> <li>[Fix] Permit null values for non-required integer custom profile fields and ensure zero complies with the range limits. (Bug #40925)</li> <li>[Fix] Allow changing forum from select box under certain circumstances. (Bug #37525)</li> <li>[Fix] Display required fields notice on registration above the custom profile fields. (Bug #39665)</li> <li>[Fix] Copy poll options properly when copying topic. (Bug #39065)</li> ! <li>[Fix] Fix error with disapproval of topics having several queued posts only. (Bug #47705)</li> ! <li>[Fix] Preserve newlines in template files (one newline had been always dropped after a template variable due to PHP's handling of closing tags).</li> ! <li>[Fix] Be less strict with FTP daemons for getting directory filelists. (Bug #46295)</li> ! <li>[Fix] Fix set_custom_template for database-stored styles. (Bug #40515)</li> ! <li>[Fix] Banning an already banned user states to be successful, but has no effect. (Bug #47825 - Patch by Pyramide)</li> ! <li>[Fix] Do not add style parameter again to URL after admin re-authentification. (Bug #18005 - Patch by leviatan21)</li> ! <li>[Fix] Do not cut post-message in between HTML-Entities on search.php. (Bug #31505 - Patch by leviatan21)</li> ! <li>[Fix] Correctly set attachment flag for topics, posts and pms after deleting attachments. (Bug #48265 - Patch by MarcoDM and nickvergessen)</li> <li>[Fix] Display "Locked" button instead of "Reply" one for locked forum in viewtopic (prosilver). (Bug #38055 - Patch by Raimon)</li> ! <li>[Fix] Correctly propagate umlauts over search result pages. (Bug #33755)</li> <li>[Fix] Preserve post options when refusing to save the post as a draft. (Bug #39115)</li> <li>[Fix] Do not send private message back to sender if sender is in the same group the private message was sent to.</li> ! <li>[Fix] Correctly add user to a group making it a default one. (Bug #48345)</li> <li>[Fix] Add log entry when copying forum permissions.</li> ! <li>[Fix] Min/max characters per posts no longer affects poll options. (Bug #47295)</li> ! <li>[Fix] Correctly log action when users request to join a group. (Bug #37585)</li> <li>[Fix] Do not try to create thumbnails for images we cannot open properly. (Bug #48695)</li> <li>[Fix] Apply locale-independent basename() to attachment filenames. New function added: utf8_basename(). (Bug #43335 - Patch by ocean=Yohsuke)</li> <li>[Fix] Adjust build_url() to not prepend $phpbb_root_path if path returned from redirect() is an URL. This fixes redirect issues with some installations and bridges. (Bug #47535)</li> <li>[Fix] Do not mark global announcements as read if all topics in a forum become read (Bug #15729).</li> ! <li>[Fix] Fix general error in registration, caused by an undefined $config variable in validate_referer(). (Bug #49035 - Patch by wjvriend)</li> <li>[Fix] Correctly extract column default value when exporting PostgreSQL tables. (Bug #48955)</li> <li>[Fix] Allow updater to work correctly with PHP filename extensions other than ".php". (Bugs #15809, #49215)</li> <li>[Fix] Update search index if only post subject changed. (Bug #49435)</li> <li>[Fix] Fix who is online displaying incorrect data. (Bug #49485, thanks Brainy)</li> ! <li>[Fix] Fixed incorrect "topic does not exist" if unapproved posts were visited without global moderator permissions. (Bug #47795)</li> <li>[Fix] Prevent style switcher from blocking the tab key. (Bug #49335)</li> ! <li>[Fix] Correctly redirect back to MCP main page after posts approval/disapproval from it. (Bug #49625)</li> <li>[Fix] Do not display topic approval status image for shadow topic if a user is not a moderator in the forum the topic has been moved to. (Bug #43295)</li> ! <li>[Fix] Fix email problems on servers with PHP installations not accepting RFC-compliant subject string passed to the mail()-function. (Bug #46725)</li> ! <li>[Fix] Correctly orientate control panel navigation background-image on RTL languages. (Bug #49945)</li> <li>[Fix] Sort private messages by message time and not message id. (Bug #50015)</li> <li>[Fix] Make sure only logs for existing users are displayed and user-specific logs removed on user deletion. (Bug #49855)</li> <li>[Fix] Only show "Add friend" and "Add foe" links if the specific module is enabled. (Bug #50475)</li> *************** *** 210,254 **** <li>[Fix] Fix icon alignment for forums with large descriptions in subsilver2. (Bug #50445)</li> <li>[Fix] Correctly display underlined links placed in last line in viewtopic. (Bug #14811 - Patch by primehalo)</li> <li>[Fix] Only check whether forum image exists if forum image is specified. (Bug #51905)</li> ! <li>[Fix] Fixed database backup and restore with Oracle DBMS.</li> ! <li>[Fix] Fixed database updater for changes to columns having default value in MSSQL (adding/dropping constraints)</li> <li>[Change] Database updater now supports checking for existing/missing indexes.</li> <li>[Change] submit_post() now accepts force_approved_state key passed to $data to indicate new posts being approved (true) or unapproved (false).</li> <li>[Change] Change the data format of the default file ACM to be more secure from tampering and have better performance.</li> ! <li>[Change] Template engine now permits to a limited extent variable includes.</li> <li>[Change] Quote BBCode no longer requires the f_reply permission. (Bug #16079)</li> ! <li>[Change] Banning/unbanning users now generates an entry in their user notes (Bug #21825 - Patch by nickvergessen)</li> <li>[Change] Smilies no longer require the f_bbcode permission. (Bug #26545)</li> ! <li>[Change] Ability to define column split in FAQ/BBCode help (Bug #31405)</li> ! <li>[Change] Changed behaviour of group_create() function to support specifying additional group columns</li> ! <li>[Change] Hide avatar when avatar-type is not allowed (Bug #46785 - Patch by cYbercOsmOnauT and nickvergessen)</li> ! <li>[Change] INCLUDEPHP not depending on phpbb_root_path (Bug #45805 - Patch by nickvergessen)</li> <li>[Change] Ability to fetch moderators with get_moderators() even if load_moderators setting is off. (Bug #35955)</li> <li>[Change] "Post details" links with image in MCP. (Bug #39845 - Patch by leviatan21)</li> ! <li>[Change] PM history now only shows PMs of users you currently reply to. (Bug #39505 - Patch by nickvergessen)</li> ! <li>[Change] Show quote button for own PMs in PM history. (Bug #37285 - Patch by nickvergessen)</li> <li>[Change] Fetch requested cookie variables directly from cookie super global. (Bug #47785)</li> ! <li>[Change] Add confirmation for deactivating styles (Bug #14304 - Patch by leviatan21)</li> ! <li>[Change] Add confirmation for deactivating language packs (Patch by leviatan21)</li> ! <li>[Change] Add confirm-box when deleting permissions (Bug #13673 - Patch by nickvergessen)</li> ! <li>[Change] Add pagination for icons and smilies in the ACP and smilies in the smiley popup</li> <li>[Change] Cache get_username_string() function calls on viewtopic.</li> <li>[Change] Cache version check.</li> <li>[Change] When creating a new forum without copying permissions, ask again.</li> <li>[Change] Parse multiline url title for [url] BBCode tag. (Bug #1309)</li> <li>[Change] Introduce new parameter to page_header() for forum specific who is online listings.</li> <li>[Change] Lifted minimum requirement for Firebird DBMS from 2.0+ to 2.1+.</li> ! <li>[Change] Unapproved topics can no longer be replied to (Bug #44005, #47675, #23605)</li> ! <li>[Change] Require user to be registered and logged in to search for unread posts if topic read tracking is disabled for guests (Bug #49525)</li> ! <li>[Change] Allow three-digit hex notation in Color BBcode. (Bug #39965 - Patch by m0rpha)</li> <li>[Change] Simplified login_box() and redirection after login. S_LOGIN_ACTION can now be used on every page. (Bug #50285)</li> <li>[Change] Do not take edit post time into account for determining permission to delete last post in topic. (Bug #48615)</li> ! <li>[Change] Resize oversized Topic icons (Bug #44415)</li> ! <li>[Change] Banned IPs are now sorted (Bug #43045 - Patch by DavidIQ)</li> <li>[Change] phpBB updater now skips sole whitespace/tab changes while computing differences. This reduces the chance of conflicts tremendously.</li> <li>[Change] phpBB updater now solves common conflicts on it's own. This further reduces the chance of conflicts.</li> ! <li>[Feature] Add language selection on the registration terms page (Bug #15085 - Patch by leviatan21)</li> ! <li>[Feature] Backported 3.2 captcha plugins. <ul> <li>Classic and GD CAPTCHA</li> <li>reCaptcha (based on API from recaptcha.net by Mike Crawford and Ben Maurer)</li> --- 210,253 ---- <li>[Fix] Fix icon alignment for forums with large descriptions in subsilver2. (Bug #50445)</li> <li>[Fix] Correctly display underlined links placed in last line in viewtopic. (Bug #14811 - Patch by primehalo)</li> <li>[Fix] Only check whether forum image exists if forum image is specified. (Bug #51905)</li> ! <li>[Fix] Fixed database updater for changes to columns having default value in MSSQL (adding/dropping constraints).</li> <li>[Change] Database updater now supports checking for existing/missing indexes.</li> <li>[Change] submit_post() now accepts force_approved_state key passed to $data to indicate new posts being approved (true) or unapproved (false).</li> <li>[Change] Change the data format of the default file ACM to be more secure from tampering and have better performance.</li> ! <li>[Change] Template engine now permits variable includes to a limited extent.</li> <li>[Change] Quote BBCode no longer requires the f_reply permission. (Bug #16079)</li> ! <li>[Change] Banning/unbanning users now generates an entry in their user notes. (Bug #21825)</li> <li>[Change] Smilies no longer require the f_bbcode permission. (Bug #26545)</li> ! <li>[Change] Ability to define column split in FAQ/BBCode help. (Bug #31405)</li> ! <li>[Change] Changed behaviour of group_create() function to support specifying additional group columns.</li> ! <li>[Change] Hide avatar when avatar-type is not allowed. (Bug #46785 - Patch by cYbercOsmOnauT and nickvergessen)</li> ! <li>[Change] INCLUDEPHP no longer depends on $phpbb_root_path. (Bug #45805)</li> <li>[Change] Ability to fetch moderators with get_moderators() even if load_moderators setting is off. (Bug #35955)</li> <li>[Change] "Post details" links with image in MCP. (Bug #39845 - Patch by leviatan21)</li> ! <li>[Change] PM history now only shows PMs of users you currently reply to. (Bug #39505)</li> ! <li>[Change] Show quote button for own PMs in PM history. (Bug #37285)</li> <li>[Change] Fetch requested cookie variables directly from cookie super global. (Bug #47785)</li> ! <li>[Change] Add confirmation for deactivating styles. (Bug #14304 - Patch by leviatan21)</li> ! <li>[Change] Add confirmation for deactivating language packs. (Patch by leviatan21)</li> ! <li>[Change] Add confirmation for deleting permissions. (Bug #13673)</li> ! <li>[Change] Add pagination for icons and smilies in the ACP and smilies in the smiley popup.</li> <li>[Change] Cache get_username_string() function calls on viewtopic.</li> <li>[Change] Cache version check.</li> <li>[Change] When creating a new forum without copying permissions, ask again.</li> <li>[Change] Parse multiline url title for [url] BBCode tag. (Bug #1309)</li> <li>[Change] Introduce new parameter to page_header() for forum specific who is online listings.</li> <li>[Change] Lifted minimum requirement for Firebird DBMS from 2.0+ to 2.1+.</li> ! <li>[Change] Unapproved topics can no longer be replied to. (Bug #44005, #47675, #23605)</li> ! <li>[Change] Require user to be registered and logged in to search for unread posts if topic read tracking is disabled for guests. (Bug #49525)</li> ! <li>[Change] Allow three-digit hex notation in color BBcode. (Bug #39965 - Patch by m0rpha)</li> <li>[Change] Simplified login_box() and redirection after login. S_LOGIN_ACTION can now be used on every page. (Bug #50285)</li> <li>[Change] Do not take edit post time into account for determining permission to delete last post in topic. (Bug #48615)</li> ! <li>[Change] Resize oversized topic icons. (Bug #44415)</li> ! <li>[Change] Banned IPs are now sorted. (Bug #43045 - Patch by DavidIQ)</li> <li>[Change] phpBB updater now skips sole whitespace/tab changes while computing differences. This reduces the chance of conflicts tremendously.</li> <li>[Change] phpBB updater now solves common conflicts on it's own. This further reduces the chance of conflicts.</li> ! <li>[Feature] Add language selection to the registration terms page. (Bug #15085 - Patch by leviatan21)</li> ! <li>[Feature] Backported 3.2 captcha plugins: <ul> <li>Classic and GD CAPTCHA</li> <li>reCaptcha (based on API from recaptcha.net by Mike Crawford and Ben Maurer)</li> *************** *** 256,287 **** <li>3D Wave (by Robert "Xore" Hetzler)</li> </ul> </li> ! <li>[Feature] Introduced new ACM plugins: <ul> ! <li>null</li> <li><a href="http://pecl.php.net/package/memcache">memcache</a></li> <li><a href="http://pecl.php.net/package/APC">APC</a></li> <li><a href="http://xcache.lighttpd.net/">XCache</a></li> <li><a href="http://eaccelerator.net/">eAccelerator</a></li> </ul> </li> ! <li>[Feature] ATOM Feeds (Idea and diversed from RSS Feed 2.0 MOD (Version 1.0.8/9) by leviatan21)</li> ! <li>[Feature] New groups option to excempt group leaders from group permissions</li> <li>[Feature] New "Newly Registered Users" group for assigning permissions to newly registered users. They will be removed from this group once they reach a defineable amount of posts.</li> <li>[Feature] Ability to define if the "Newly Registered Users" group will be assigned as the default group to newly registered users.</li> ! <li>[Feature] Add new option to disable avatars board-wide (Bug #46785 - Patch by cYbercOsmOnauT and nickvergessen)</li> ! <li>[Feature] Enhance obtain_users_online_string to be able to return user-lists for other session-items (Bug #31975 - Patch by nickvergessen)</li> ! <li>[Feature] Add unapproved topic icon for moderators on forum list (Bug #46865 - Patch by nickvergessen)</li> ! <li>[Feature] Ability to define minimum number of characters for posts/pms</li> ! <li>[Feature] Store signature configuration options in database (Bug #45115 - Patch by rxu)</li> <li>[Feature] Add bare-bones quick-reply editor to viewtopic.</li> ! <li>[Feature] Detect when a post has been altered by someone else while editing. (Patch by bantu)</li> ! <li>[Feature] Add unread posts quick search option (Bug #46765 - Patch by rxu)</li> ! <li>[Feature] Add option to disable avatar uploads from remote locations. (Bug #45375 - Patch by nickvergessen)</li> ! <li>[Feature] Ability to delete warnings and keep warnings permanently (Bug #43375 - Patch by nickvergessen)</li> <li>[Feature] Ability to empty a user's outbox from the user ACP quick tools.</li> ! <li>[Feature] Ability to search ACP / MCP logs</li> ! <li>[Feature] Users can report PMs to moderators which are then visible in a new MCP module</li> <li>[Feature] Parse email text files with the template engine.</li> <li>[Feature] Use email-style quoting when bbcodes are disabled.</li> <li>[Feature] Added new functionality to inactive users module: --- 255,286 ---- <li>3D Wave (by Robert "Xore" Hetzler)</li> </ul> </li> ! <li>[Feature] Introduced new ACM (Cache) plugins: <ul> ! <li>null (to disable caching completely)</li> <li><a href="http://pecl.php.net/package/memcache">memcache</a></li> <li><a href="http://pecl.php.net/package/APC">APC</a></li> <li><a href="http://xcache.lighttpd.net/">XCache</a></li> <li><a href="http://eaccelerator.net/">eAccelerator</a></li> </ul> </li> ! <li>[Feature] ATOM Feeds (Idea from RSS Feed 2.0 MOD (Version 1.0.8/9) by leviatan21)</li> ! <li>[Feature] New groups option to excempt group leaders from group permissions.</li> <li>[Feature] New "Newly Registered Users" group for assigning permissions to newly registered users. They will be removed from this group once they reach a defineable amount of posts.</li> <li>[Feature] Ability to define if the "Newly Registered Users" group will be assigned as the default group to newly registered users.</li> ! <li>[Feature] Add new option to disable avatars board-wide. (Bug #46785 - Patch by cYbercOsmOnauT and nickvergessen)</li> ! <li>[Feature] Enhance obtain_users_online_string to be able to return user-lists for other session items. (Bug #31975)</li> ! <li>[Feature] Add unapproved topic icon for moderators on forum list. (Bug #46865)</li> ! <li>[Feature] Ability to define minimum number of characters for posts/pms.</li> ! <li>[Feature] Store signature configuration options in database. (Bug #45115)</li> <li>[Feature] Add bare-bones quick-reply editor to viewtopic.</li> ! <li>[Feature] Detect if a post has been altered by someone else while editing.</li> ! <li>[Feature] Add unread posts quick search option. (Bug #46765)</li> ! <li>[Feature] Add option to disable avatar uploads from remote locations. (Bug #45375)</li> ! <li>[Feature] Ability to delete warnings and keep warnings permanently. (Bug #43375)</li> <li>[Feature] Ability to empty a user's outbox from the user ACP quick tools.</li> ! <li>[Feature] Ability to search ACP/MCP logs.</li> ! <li>[Feature] Users can report PMs to moderators which are then visible in a new MCP module.</li> <li>[Feature] Parse email text files with the template engine.</li> <li>[Feature] Use email-style quoting when bbcodes are disabled.</li> <li>[Feature] Added new functionality to inactive users module: *************** *** 295,310 **** </li> <li>[Feature] Display version check on ACP main page.</li> <li>[Feature] Ability to copy permissions from one forum to several other forums.</li> ! <li>[Feature] Ability to control the display of custom profile fields on viewtopic (Bug #48985).</li> <li>[Feature] Fallback options for missing language files. (Bug #38575 - Patch by EXreaction)</li> ! <li>[Feature] Separate PM Reply and PM Reply to all in prosilver.</li> <li>[Feature] Place debug notices during captcha rendering in the error log - useful for debugging output already started errors.</li> ! <li>[Feature] Ability to define constant PHPBB_USE_BOARD_URL_PATH to use board url for images/avatars/ranks/imageset...</li> ! <li>[Feature] Added function to generate Email hash. (Bug #49195)</li> ! <li>[Feature] Style authors are now able to define the default submit button used for form submission on ENTER keypress on forms using more than one. Prosilver uses this for the posting page(s) and registration screen.</li> <li>[Feature] Ability to specify amount of time user is able to delete his last post in topic.</li> <li>[Feature] Send anonymous statistical information to phpBB on installation and update (optional).</li> </ul> <a name="v304"></a><h3>1.ii. Changes since 3.0.4</h3> <ul> --- 294,310 ---- </li> <li>[Feature] Display version check on ACP main page.</li> <li>[Feature] Ability to copy permissions from one forum to several other forums.</li> ! <li>[Feature] Ability to control the display of custom profile fields on viewtopic. (Bug #48985)</li> <li>[Feature] Fallback options for missing language files. (Bug #38575 - Patch by EXreaction)</li> ! <li>[Feature] Separate "PM Reply" and "PM Reply to all" in prosilver.</li> <li>[Feature] Place debug notices during captcha rendering in the error log - useful for debugging output already started errors.</li> ! <li>[Feature] Ability to define constant PHPBB_USE_BOARD_URL_PATH to use board url for images/avatars/ranks/imageset (useful for bridges and applications using phpBB).</li> ! <li>[Feature] Added function to generate email hash. (Bug #49195)</li> ! <li>[Feature] Style authors are now able to define the default submit button used for form submission on ENTER keypress on forms using more than one submit button. Prosilver uses this for the posting page(s) and registration screen.</li> <li>[Feature] Ability to specify amount of time user is able to delete his last post in topic.</li> <li>[Feature] Send anonymous statistical information to phpBB on installation and update (optional).</li> </ul> + <a name="v304"></a><h3>1.ii. Changes since 3.0.4</h3> <ul> |
From: Meik S. <acy...@ph...> - 2009-10-20 11:17:14
|
Author: acydburn Date: Tue Oct 20 12:16:30 2009 New Revision: 10226 Log: add default_lang to statistics Modified: branches/phpBB-3_0_0/phpBB/includes/questionnaire/questionnaire.php Modified: branches/phpBB-3_0_0/phpBB/includes/questionnaire/questionnaire.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/questionnaire/questionnaire.php (original) --- branches/phpBB-3_0_0/phpBB/includes/questionnaire/questionnaire.php Tue Oct 20 12:16:30 2009 *************** *** 303,308 **** --- 303,309 ---- 'database_gc' => true, 'dbms_version' => true, 'default_dateformat' => true, + 'default_lang' => true, 'display_last_edited' => true, 'display_order' => true, 'edit_time' => true, |
From: Meik S. <acy...@ph...> - 2009-10-20 11:04:49
|
Author: acydburn Date: Tue Oct 20 12:04:00 2009 New Revision: 10225 Log: fix bug #53045 the simple way. ;) Modified: branches/phpBB-3_0_0/phpBB/feed.php Modified: branches/phpBB-3_0_0/phpBB/feed.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/feed.php (original) --- branches/phpBB-3_0_0/phpBB/feed.php Tue Oct 20 12:04:00 2009 *************** *** 430,436 **** /** * Default cache time of entries in seconds */ ! var $cache_time = 300; /** * Separator for title elements to separate items (for example forum / topic) --- 430,436 ---- /** * Default cache time of entries in seconds */ ! var $cache_time = 0; /** * Separator for title elements to separate items (for example forum / topic) |
From: Henry S. <kel...@ph...> - 2009-10-15 10:52:56
|
Author: Kellanved Date: Thu Oct 15 11:52:41 2009 New Revision: 10224 Log: #52875 working around php4 bug 24631 - call_user_func doesn't return references. This causes php4 to create a copy. Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/captcha_factory.php Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/captcha_factory.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/captcha/captcha_factory.php (original) --- branches/phpBB-3_0_0/phpBB/includes/captcha/captcha_factory.php Thu Oct 15 11:52:41 2009 *************** *** 35,41 **** { include($phpbb_root_path . "includes/captcha/plugins/{$name}_plugin." . $phpEx); } ! $instance & call_user_func(array($name, 'get_instance')); return $instance; } --- 35,41 ---- { include($phpbb_root_path . "includes/captcha/plugins/{$name}_plugin." . $phpEx); } ! $instance = call_user_func(array($name, 'get_instance')); return $instance; } |
From: Henry S. <kel...@ph...> - 2009-10-15 10:52:17
|
Author: Kellanved Date: Thu Oct 15 11:51:32 2009 New Revision: 10223 Log: #52875 working around php4 bug 24631 - call_user_func doesn't return references. This causes php4 to create a copy. Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/captcha_factory.php Modified: branches/phpBB-3_0_0/phpBB/includes/captcha/captcha_factory.php ============================================================================== *** branches/phpBB-3_0_0/phpBB/includes/captcha/captcha_factory.php (original) --- branches/phpBB-3_0_0/phpBB/includes/captcha/captcha_factory.php Thu Oct 15 11:51:32 2009 *************** *** 35,41 **** { include($phpbb_root_path . "includes/captcha/plugins/{$name}_plugin." . $phpEx); } ! $instance =& call_user_func(array($name, 'get_instance')); return $instance; } --- 35,41 ---- { include($phpbb_root_path . "includes/captcha/plugins/{$name}_plugin." . $phpEx); } ! $instance & call_user_func(array($name, 'get_instance')); return $instance; } |