Fixed BUG in phpagi.php - and new hope!

[suther]

First, i enjoy the feeling of new hope, cause i see some activity on this Project.
Cause of this, i use my chance to send new Bug-Fix based on the newest Trunk-version of masham.

I looking forward to hear something from masham, cause i wan't to support this project instead to create my own one.
Masham - please tell me, in wich i can support the Project.

Here My BugFix:

phpagi.pgp Line 874:
return $this->exec('Dial', trim("$type/$identifier,$timeout,$options,$url", ','));

Here the delemiter is still wrong. Have to set to "|", cause in asterisk 1,6 the "," is deprecated.
  return $this->exec('Dial', trim("$type/$identifier|$timeout|$options|$url", '|'));

And on the End of phpagi.php in trunk, at the bottom of the document, "?>" is missed.

[Matthew Asham]

> I looking forward to hear something from masham, cause i wan't to support this project instead to create my own one.

By all means - fork or start your own if you feel there is a need. 

If you wish to submit bugs or patches for phpagi you can submit them to the tracker. 

> Here the delemiter is still wrong. Have to set to "|", cause in asterisk 1,6 the "," is deprecated.

What version of Asterisk are you using?  The version of 1.6.1 I've tested against and the source 1.6.2.13 use a comma, not a pipe.

I've added a public variable option_delim to the class to specify which delimiter to use. 

>And on the End of phpagi.php in trunk, at the bottom of the document, "?>" is missed.

The missing ?> is deliberate and in place to avoid new lines from being injected into the stdout agi stream if, for example, phpagi.php is uploaded with dos-like crlf's.

[suther]

Thanks, and great, that you answer my Request. Try many times before, with no response. I'm glad to see that some changes was made… I see no reason to make a own project, if the user-requests and Bugfixes will be added as soon as possible after sending them.

Before it was little sad about the long time and the missing response of you. Therefor i got the wish, tzo become a developer of phpagi, to make time of reaction a little shorter.
But if u now back - great! Thats all i wan't… and i support you by posting my wishes und bigfixes to the tracker.

Many greetings, and take on - your good job.