Well, the tag collection was changed in the recent version here and is discussed a little in the readme.
Alot of folks were getting 'undefined' entries in the older version, so some rules were proposed for the script tag reading given that tags might be missing or incomplete. The rules we implemented were:
1. If no title tag, then use filename. (This prevents list of just artist tag, not very informative)
2. If no tags exist, then use filename.
3. If both title and artist tags are present, then use these.
Let me point out that while tags might exist in mp3 files, they may contain problematic characters like & and $ that php will try to process and will result in an 'undefined' entry. We have not designed a filter yet to qualify the tag input.
Also we have not tried concatenating the filename with artist tag if title tag is missing - this might cause some weirdness with someones collection.
So we tried to pick tag usage rules that would work for most peoples collections or habits. For example in my own mp3 collection of original music the tagging is spotty ;) But this script produces useful output regardless because of the filename fallback; just a few else statements after the tag calls.
If you are really curious about why your tags are not coming through, then check them out in software that lets you edit them. I usually grab NI Traktor because it lets me modify gobs of mp3 tags at a time. Most software only lets you set the tags on the mp3 render/print...like logic.
Hope this helps ;)
jonathan / sleen
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I too am having trouble with ID3 tags. The script works great, but only delivers file name. I have been through rules above, and my MP3's have both title and artist with no unusual characters (only alphanumeric with spaces)...
Also, how does the image grab work - does it draw an image from the MP3 ID3 information? The MP3's contain a cover image, but it does not get displayed....
Thanks for the fantastic work!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've understood the image-grab from the original xspf_player-0.2.3 - it depends on an image URL in the xml/xspf file. Is there a way to do this in the PHP dynamic version?
Thanks again...
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Ok first my directory structure
I have a website set up like this:
baseurl/mixes
baseurl/player/playlist_generator.php
baseurl/player/getid3/getid3.php
so i've modified the following line of code in playlist_generator.php.
"define("MP3_PATH","/mixes");
It comes out like this:
<location>http://www.myurl.com//mixes/Filename.mp3</location>
<!-- artist or band name -->
<creator></creator>
<!-- album name -->
<album></album>
<!-- name of the song -->
<title>Filename</title>
Is there a way of changing it so that instead of:
http://www.myurl.com//mixes/Filename.mp3
I can get it to read:
http://www.myurl.com/mixes/Filename.mp3
Or doesn't that matter?
Also get the ID3 tags working too..
Haven't changed the
$dir = PATH . MP3_PATH;
I think there's just something wrong with my MP3_PATH definition
Any help would be much appreciated!
Just fixed the
http://www.myurl.com//mixes/Filename.mp3
to read:
http://www.myurl.com/mixes/Filename.mp3
by changing this line:
$url = ROOT . "/" . MP3_PATH . "/" . $short_name;
to:
$url = ROOT . MP3_PATH . "/" . $short_name;
Glad that works for you! Do the tags work correctly yet?
-jonathan
Nah not yet. They're just the file name still.. Mind you it looks kinda cool haha and i'm not too fussed.
Perhaps it's a chmod issue or a file issue on the server. I might try dropping the playlist_generator.php into just the mixes folder.
Might piece apart the coding of getid3 folder also, but I don't know too much about how the tags work.
Well, the tag collection was changed in the recent version here and is discussed a little in the readme.
Alot of folks were getting 'undefined' entries in the older version, so some rules were proposed for the script tag reading given that tags might be missing or incomplete. The rules we implemented were:
1. If no title tag, then use filename. (This prevents list of just artist tag, not very informative)
2. If no tags exist, then use filename.
3. If both title and artist tags are present, then use these.
Let me point out that while tags might exist in mp3 files, they may contain problematic characters like & and $ that php will try to process and will result in an 'undefined' entry. We have not designed a filter yet to qualify the tag input.
Also we have not tried concatenating the filename with artist tag if title tag is missing - this might cause some weirdness with someones collection.
So we tried to pick tag usage rules that would work for most peoples collections or habits. For example in my own mp3 collection of original music the tagging is spotty ;) But this script produces useful output regardless because of the filename fallback; just a few else statements after the tag calls.
If you are really curious about why your tags are not coming through, then check them out in software that lets you edit them. I usually grab NI Traktor because it lets me modify gobs of mp3 tags at a time. Most software only lets you set the tags on the mp3 render/print...like logic.
Hope this helps ;)
jonathan / sleen
I too am having trouble with ID3 tags. The script works great, but only delivers file name. I have been through rules above, and my MP3's have both title and artist with no unusual characters (only alphanumeric with spaces)...
Also, how does the image grab work - does it draw an image from the MP3 ID3 information? The MP3's contain a cover image, but it does not get displayed....
Thanks for the fantastic work!
I've understood the image-grab from the original xspf_player-0.2.3 - it depends on an image URL in the xml/xspf file. Is there a way to do this in the PHP dynamic version?
Thanks again...