Re: [Php-tuxedo-development] CVS updates (resend)

[Brian F. <bf...@mn...>]

ChoelMin, 

Good to hear from you.  Several of the earlier messages
bounced so I thought maybe you had changed your
email address.

On Fri, 28 Dec 2001 16:22:34 +0900, CheolMin Lee wrote:

>LTNS :)
>
>On Sun, Dec 23, 2001 at 02:00:54AM -0600, Brian Foddy wrote:
>> CheolMin,
>> Haven't heard from you in awhile, how goes Php-Tuxedo?
>> 
>> I've been making some updates to get it running on
>> Php 4.1 and some other long overdue changes, and
>> I'd like to propose a small change to your
>> tux_ffprint function...
>> 
>> Rather than have it open and close the file,
>> how about passing it a already open PHP open
>> file reference, and have it use it.  I've got
>> most of the designs ready to do this, but it
>> would probably involve changing the arg types,
>> hence would break anything you've written using your
>> arguments.
>> 
>> Thoughts?  
>
>good idea. BTW, is it working well for pipe or socket?
>I checked in your recently updated code and found that 
>php_file_le_fopen() was used to get the resource.
>I'm wondering that php_file_le_fopen() works for pipe or socket 
>even if not using php_file_le_popen() or php_file_le_socket().
>

To be honest, I've not tried it for anything except regular
files, I made this just before leaving for vacation.  I'm
back now, I will try and test it somehow with other file types.


>> Also, I was looking at the "data" argument you added
>> to tux_tpinit...  Is it ever possible "data" could be
>> a binary value, hence the strlen and strcpy could fail?
>> I'm proposing we use memcpy and the internal PHP API
>> data length argument for binary safeness.
>> 
>
>I like it.

Brian Douglas and I traded a couple emails debating if
tux_tpinit should accept all the arguments of the real
tpinit.  His position was it should accept all the real
args in the same order, even the "group" arg which is
always NULL for us.  Apparently some other packages use 
these same API calls and they do use the "group" argument.

Technically, I think I can rely on
PHP to tell me how long a string or binary value is, but
if people are used to using all these args, I have no problem
adding them.

Other thoughts from others?

Brian