|
From: Garvin H. <squ...@su...> - 2003-08-17 16:13:03
|
Hi Tom!
> +} else if (preg_match('@/unsubscribe/(.*)/([0-9]+)@', $uri, $res)) {
> + serendipity_cancelSubscription($res[1], $res[2]);
> + /* Fixme: send the user to the unsubscribed entry */
> + header("Location: {$serendipity['serendipityHTTPPath']}index.php");
> + exit;
I'd like to have any textual feedback that my unsubscription succeeded or failed.
Could/should be embedded into the serendipity_displayCommentForm() function.
And instead redirecting to index.php we could use the same functionality of the
preg_match('@/archives/...') string and immediately display the entry. Instead of
redirection, which should be avoided where possible.
We could also send a mail to the user, like: "You were unsubscribed". This should
prevent users from unsubscribing me without knowledge.
BTW, if we use a complete E-Mail in the URI of the unsubscription-URL, it should get
properly urlencode()ed to avoid browser nastyness.
Apart from that, I like the feature, thanks! :))
Regards,
Garvin.
--
Garvin Hicking | Mediengestalter
www.supergarv.de | #ICQ 21392242
|
