Re: [php-blog-cvs] serendipity comment.php,1.11,1.12

[Sterling H. <ste...@bu...>]

The indentation of the closing ?> doesn't really matter, the Zend lexer
will fold that whitespace.  It is purely a style guideline.

-sterling

On Fri, 2003-07-04 at 12:33, gar...@us... wrote:
> Update of /cvsroot/php-blog/serendipity
> In directory sc8-pr-cvs1:/tmp/cvs-serv21145
> 
> Modified Files:
> 	comment.php 
> Log Message:
> Removed indenting on ?> (and <?) tags, put them to top level to not let PHP introduce
> any extra spaces/linefeeds to the HTML output. (as [being] discussed on the
> mailinglist)
> 
> 
> Index: comment.php
> ===================================================================
> RCS file: /cvsroot/php-blog/serendipity/comment.php,v
> retrieving revision 1.11
> retrieving revision 1.12
> diff -u -d -r1.11 -r1.12
> --- comment.php	4 Jul 2003 10:36:37 -0000	1.11
> +++ comment.php	4 Jul 2003 16:33:16 -0000	1.12
> @@ -63,7 +63,7 @@
>                     . 'archives/'
>                     . $serendipity['GET']['entry_id']
>                     . '_' . serendipity_makeFilename($entry[0]['title']) . '.html';
> -        ?>
> +?>
>  <div id="serendipity_bodyLevel">
>      <div class="serendipity_commentsTitle">Trackbacks</div><br />
>      <dl>
> @@ -77,11 +77,11 @@
>      </dl>
>  <?php
>          } else {
> -        ?>
> +?>
>      <div class="serendipity_commentsTitle">Comments</div>
>  <?php
> -            serendipity_printComments(serendipity_fetchComments($id)); ?>
> -
> +            serendipity_printComments(serendipity_fetchComments($id)); 
> +?>
>  
>      <div class="serendipity_commentsTitle">Add A Comment</div>
>  <?php
> @@ -94,18 +94,18 @@
>          $comment['email']   = $serendipity['POST']['email'];
>          if ( !empty($comment['comment']) ) {
>              serendipity_saveComment($serendipity['POST']['entry_id'], $comment, 'NORMAL');
> -        ?>
> +?>
>      Your comment was successfully added.
>      Click <a href="<?php echo $_SERVER['PHP_SELF']; ?>?serendipity[entry_id]=<?php echo $serendipity['POST']['entry_id']; ?>">here to return</a> to
>      the comments, and <a href="#" onClick="self.close()">here to close</a> this window.
>  <?php
>          } else {
> -        ?>
> +?>
>      Your comment did not contain anything, please <a href="#" onClick="history.go(-1)">go back</a> and try again
>  <?php
>          }
>      }
> -    ?>
> +?>
>  </div>
>  </body>
>  </html>
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> Data Reports, E-commerce, Portals, and Forums are available now.
> Download today and enter to win an XBOX or Visual Studio .NET.
> http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01
> _______________________________________________
> php-blog-cvs mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/php-blog-cvs
-- 
"The three most dangerous things in the world are a programmer  
 with a soldering iron, a hardware type with a program patch and  
 a user with an idea." 
    - Unknown