pgsqlclient-checkins

[<car...@us...>]

Update of /cvsroot/pgsqlclient/pgsqlclient_10/PostgreSql.Data.PgSqlClient/source
In directory sc8-pr-cvs1:/tmp/cvs-serv17753

Modified Files:
	PgCommand.cs PgCommandBuilder.cs PgConnection.cs 
	PgDataAdapter.cs 
Log Message:
2003-11-19 Carlos Guzmán Álvarez  <car...@te...>

	* source/PgCommand.cs:
	* source/PgConnection.cs:
	* source/PgDataAdapter.cs:
	* source/PgCommandBuilder.cs:

		- Added better implementation of constructors and dispose methods.


Index: PgCommand.cs
===================================================================
RCS file: /cvsroot/pgsqlclient/pgsqlclient_10/PostgreSql.Data.PgSqlClient/source/PgCommand.cs,v
retrieving revision 1.13
retrieving revision 1.14
diff -C2 -d -r1.13 -r1.14
*** PgCommand.cs	17 Nov 2003 09:12:43 -0000	1.13
--- PgCommand.cs	19 Nov 2003 15:19:18 -0000	1.14
***************
*** 209,213 ****
  		#region CONSTRUCTORS
  
! 		public PgCommand()
  		{
  			this.commandText		= String.Empty;
--- 209,213 ----
  		#region CONSTRUCTORS
  
! 		public PgCommand() : base()
  		{
  			this.commandText		= String.Empty;
***************
*** 220,223 ****
--- 220,225 ----
  			this.parameters			= new PgParameterCollection();
  			this.search				= new Regex("(@([a-zA-Z-$][a-zA-Z0-9_$]*))");
+ 
+ 			GC.SuppressFinalize(this);
  		}
  
***************
*** 239,249 ****
  		#endregion
  
! 		#region DESTRUCTORS
! 
! 		void IDisposable.Dispose() 
! 		{
! 			this.Dispose(true);
! 			System.GC.SuppressFinalize(this);
! 		}
  		
  		protected override void Dispose(bool disposing)
--- 241,245 ----
  		#endregion
  
! 		#region DISPOSE_METHODS
  		
  		protected override void Dispose(bool disposing)

Index: PgCommandBuilder.cs
===================================================================
RCS file: /cvsroot/pgsqlclient/pgsqlclient_10/PostgreSql.Data.PgSqlClient/source/PgCommandBuilder.cs,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** PgCommandBuilder.cs	17 Oct 2003 18:21:14 -0000	1.12
--- PgCommandBuilder.cs	19 Nov 2003 15:19:19 -0000	1.13
***************
*** 120,124 ****
  		#region CONSTRUCTORS
  
! 		public PgCommandBuilder()
  		{			
  			sqlInsert		= "INSERT INTO {0} ({1}) VALUES ({2})";
--- 120,124 ----
  		#region CONSTRUCTORS
  
! 		public PgCommandBuilder() : base()
  		{			
  			sqlInsert		= "INSERT INTO {0} ({1}) VALUES ({2})";
***************
*** 131,134 ****
--- 131,136 ----
  			quotePrefix		= String.Empty;
  			quoteSuffix		= String.Empty;
+ 
+ 			GC.SuppressFinalize(this);
  		}
  		
***************
*** 140,149 ****
  		#endregion
  
! 		#region DESTRUCTORS
! 
! 		~PgCommandBuilder() 
! 		{
! 			Dispose(false);
! 		}
  
  		protected override void Dispose(bool disposing)
--- 142,146 ----
  		#endregion
  
! 		#region DISPOSE_METHODS
  
  		protected override void Dispose(bool disposing)

Index: PgConnection.cs
===================================================================
RCS file: /cvsroot/pgsqlclient/pgsqlclient_10/PostgreSql.Data.PgSqlClient/source/PgConnection.cs,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** PgConnection.cs	8 Nov 2003 12:55:23 -0000	1.5
--- PgConnection.cs	19 Nov 2003 15:19:19 -0000	1.6
***************
*** 190,197 ****
  		#region CONSTRUCTORS
  
! 		public PgConnection()
  		{			
  			state				= ConnectionState.Closed;
  			connectionString	= String.Empty;
  		}
      		
--- 190,199 ----
  		#region CONSTRUCTORS
  
! 		public PgConnection() : base()
  		{			
  			state				= ConnectionState.Closed;
  			connectionString	= String.Empty;
+ 
+ 			GC.SuppressFinalize(this);
  		}
      		
***************
*** 203,213 ****
  		#endregion
  
! 		#region DESTRUCTORS
! 
! 		void IDisposable.Dispose() 
! 		{
! 			this.Dispose(true);
! 			System.GC.SuppressFinalize(this);
! 		}
  
  		protected override void Dispose(bool disposing)
--- 205,209 ----
  		#endregion
  
! 		#region DISPOSE_METHODS
  
  		protected override void Dispose(bool disposing)

Index: PgDataAdapter.cs
===================================================================
RCS file: /cvsroot/pgsqlclient/pgsqlclient_10/PostgreSql.Data.PgSqlClient/source/PgDataAdapter.cs,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** PgDataAdapter.cs	8 Nov 2003 12:55:23 -0000	1.2
--- PgDataAdapter.cs	19 Nov 2003 15:19:19 -0000	1.3
***************
*** 113,118 ****
  		#region CONSTRUCTORS
  
! 		public PgDataAdapter()
  		{
  		}
  
--- 113,119 ----
  		#region CONSTRUCTORS
  
! 		public PgDataAdapter() : base()
  		{
+ 			GC.SuppressFinalize(this);
  		}
  
***************
*** 134,138 ****
  		#endregion
  
! 		#region DESTRUCTORS
  
  		protected override void Dispose(bool disposing)
--- 135,139 ----
  		#endregion
  
! 		#region DISPOSE_METHODS
  
  		protected override void Dispose(bool disposing)