Menu

#26 URL decoding causing issues with folders/files with ampersand's

v1.0 (example)
open
nobody
None
5
2013-05-01
2013-05-01
allistera
No

When generating a thumbnail when viewing a folder the source encodes the path and filename using urlencode and uses AJAX to post it, but in UrlThumb.php when parsing it out in the _getParamsFromUrl private method it uses strip_tags & htmlspecialchars (Line 60 Mainly), this can cause issues with some characters not being decoded correctly, I found this out when trying to view images in a folder with an ampersand.

To fix this issue you can change the htmlspecialchars function in line 60 to urldecode like so:

$relPath = strip_tags(urldecode($_GET['src']));

Not sure how to submit a patch to SourceForge.

Discussion


Log in to post a comment.

Monday.com Logo