Menu

#45 2.1.0 Build error with parallel build

v1.0 (example)
closed-fixed
None
5
2022-01-03
2018-01-01
No

Hello,

pfstools 2.1.0 FTBFS on parallel build (make -j3). The octave files custom_command includes a -lpfs but there is no dependency defined in the CMake infrastructure.

Find attached a works-for-me patch. Please doublecheck.

cu Andreas

1 Attachments

Discussion

  • Stefan Brüns

    Stefan Brüns - 2019-01-21

    I think the correct place to specify the dependency is in the "DEPENDS" of the custom command.
    Otherwise, make may create e.g. pfsread.oct and libpfs in parallel. You only specify libpfs as a dependency of the .mkoct target.

     
  • Stefan Brüns

    Stefan Brüns - 2022-01-03

    The following works, and is IMHO the correct way to specify the dependency:

     
    • Rafal Mantiuk

      Rafal Mantiuk - 2022-01-03

      Patch applied. Compiles fine on my side.

       
  • Rafal Mantiuk

    Rafal Mantiuk - 2022-01-03
    • status: open --> closed-fixed
    • assigned_to: Rafal Mantiuk
     

Log in to post a comment.