Re: [Perlunit-devel] commits

[Piers C. <pdc...@bo...>]

Adam Spiers <ad...@sp...> writes:

> Weaver, Quinn BGI SF (Qui...@ba...) wrote:
>> > From: Adam Spiers [mailto:ad...@sp...]
>> 
>> > Time for a quick poll; can we reach a consensus on whitespace policy?
>> 
>> I'm with you.
> 
> Cool :-)
> 
> While we're at it, another quick poll:
> 
>   my $self = shift;
>   my $arg = shift;
> 
> or
> 
>   my ($self, $arg) = @_;
> 
> ?
> 
> IIRC some of my cow-orkers here benchmarked it and found that the
> latter was noticeably faster.

I prefer the former of the two options. I think it reveals your
intention better (and makes life easier for the refactoring browser
I'm working on...). However, my current favourite is:

    my $self = shift;
    my($arg1, $arg2, @foo) = @_;

(Note the lack of space between my and the opening brace...

> I've added a coding conventions section to doc/consensus.txt for this
> stuff.  With the presence of the various branches around, I think it's
> important that we only edit doc/consensus.txt in HEAD.

Frankly, I'd like to see PDC_REFACTOR merged ASAP, but I think there
might be a few more modules to move around, I'm really not keen on the
Test::Unit::TestFoo style, and, from discussions elsewhere, I think
it'd be a good idea to move Test::Unit itself into
Test::Unit::Procedural. There seem to be a fair few folks at the
moment who think that Test::Unit is the main interface to PerlUnit.

-- 
Piers

   "It is a truth universally acknowledged that a language in
    possession of a rich syntax must be in need of a rewrite."
         -- Jane Austen?