[perlce-user] Re: Merge WinCE and Win32 directories -- Initial patch

[demerphq <dem...@gm...>]

On 5/1/06, Vadim <va...@vk...> wrote:
>
> > Since folks seemed interested (and since i apparently have some free
> > time I didnt expect) I put the current state of my merging efforts
> > online as
> >
> >  http://flux8.com:8079/perl/win.tar.bz2
>
>
> Attached is a patch against this, and also updated directory online.
>
> http://feather.perl6.nl/~vkon/win-28029.zip
> (Thanks to Juerd for providing this for Perl6 efforts, I hope he will
> not be disappointed by using perl6 resource for perl5 needs, as we're
> moving towards perl6 anyways :):)
> (zip is not needed if attached patch is used)
>
> Another 2 tiny patches are to perl.h and perlio.c
>
> Because now host perl and cross-compiled perl are built in the same dir,
> I propose to have config.h for cross-compilation to be named "xconfig.h"
>
> Looking at perlio.c, it is a bit strange to have "config.h" included
> from there; is it unavoidable?? perlio.c is the only C file including
> "config.h", thus making it very different.
>
> Now stuff builds okay; I didn't tried running executables yet, but there
> should be no problem on this.

Great! Ive been too busy to work on it this w/e but I will follow up soon.

> >
> > Just to recap my methodology was as follows:
> >
> > First i diffed WinCE and Win32 and realized that there were basically
> > three classes of file:
> >
> > A. Additions in Win32 that hadnt been applied to the wince directory.
> > B. Stuff in the WinCE directory that had been written with Win32
> > compatibilty in mind
> > C. Suff in the Wince directory that had assumed that Win32 stuff didnt
> > matter.
>
>
> remarkably, win/include/sys/socket.h just lost some twisted stuff during
> merger, because for some reason win32/include/sys/socket.h contained
> some "WINCE" #ifdef-s which were never happen.

I think that might have been me, I merged much of the changes that
were in socket.h in the wince directory into the win32 directory
already, and raphael applied the patch.

>
> > Miscleaneous stufff:
> >
> > One difference that i decided in the favour of the Win32 branch was
> > the icon for the exe. Im not sure if the WinCE one was intended as a
> > lower resolution icon or not, it certainly was smaller. Possibly this
> > change needs to be enhanced to allow selecting the icon from the
> > cmdline.
>
>
> I just didn't pay enough time for looking into win32/makeico.pl and
> wince/makeico.pl closely; actually I did small steps in merging of such
> files earlier.

In some ways I like the way the Wince build does the ico stuff better
than I like the way the mainline does it.

> >
> > An interesting issue are the additional files in the WinCE directory,
> > some of them (the batch files) are kindof interesting and long term
> > might be made to do the right thing for a normal win32 build. Likewise
> > there are some interesting stuff in the Makefile.ce
>
>
> may be wince-only batch files should be in separate subdirectory?

Well, if you really think so then sure, but I was think not, just to
encourage the idea that long term it would be nice to have as many of
them as possible do the right thing regardless. It seemed to me that
some of them are almost like a first step towards a win32  configure
process, which seems to me to be useful.

> To summarize, I am very glad of this merger process: not only number of
> files will be smaller, also some build features will become available
> (e.g. static links).

Thats great, thanks a bunch for your help!

Cheers,
Yves

--
perl -Mre=3Ddebug -e "/just|another|perl|hacker/"