Thread: [Perl-workflow-devel] Bug found in Workflow::Action::init
Brought to you by:
jonasbn
From: Alejandro I. <ai...@ya...> - 2009-09-20 14:58:57
|
I can almost confirm there is a bug in Workflow::Action::init Workflow::Action::init currently reads: sub init { my ( $self, $wf, $params ) = @_; When in fact, I think it should read: sub init { my ( $self, $params ) = @_; Just like the init() in Condition, State, Validator and so on. In fact Base::new() calls $self->init(@params); sow where the heck is $wf supposed to come from? If all this is true, then it's a fact that the Action accessors are currently broken and $self->param() of Action is being clobbered by the wrong object properties. Can _anyone_ , _please_, _pretty pleae_ confirm this? I have sent 3 mails regarding this issue and it's hard to believe I'm the only one that has problems using the Action accessors!!! Thanks, Alejandro Imass |
From: Alejandro I. <ai...@p2...> - 2009-09-20 15:07:47
|
I can almost confirm there is a bug in Workflow::Action::init Workflow::Action::init currently reads: sub init { my ( $self, $wf, $params ) = @_; When in fact, I think it should read: sub init { my ( $self, $params ) = @_; Just like the init() in Condition, State, Validator and so on. In fact Base::new() calls $self->init(@params); sow where the heck is $wf supposed to come from? If all this is true, then it's a fact that the Action accessors are currently broken and $self->param() of Action is being clobbered by the wrong object properties. Can _anyone_ , _please_, _pretty pleae_ confirm this? I have sent 3 mails regarding this issue and it's hard to believe I'm the only one that has problems using the Action accessors!!! Thanks, Alejandro Imass |
From: Alejandro I. <ai...@p2...> - 2009-09-21 19:15:11
|
Ok, my bad, sorry folks. I was overriding init() but did not realize it was later called by Base::new(), so I was calling it twice and with the wrong params. Oops. I am now overriding new() and everything seems to be working fine. BTW, seems like I'm talking to myself here but what the heck, better to resolve the thread for future reference.... Thanks, Alejandro Imass On Sun, Sep 20, 2009 at 11:07 AM, Alejandro Imass <ai...@p2...> wrote: > I can almost confirm there is a bug in Workflow::Action::init > > Workflow::Action::init currently reads: > > sub init { > my ( $self, $wf, $params ) = @_; > > When in fact, I think it should read: > > sub init { > my ( $self, $params ) = @_; > > Just like the init() in Condition, State, Validator and so on. > > In fact Base::new() calls $self->init(@params); sow where the heck is > $wf supposed to come from? > If all this is true, then it's a fact that the Action accessors are > currently broken and $self->param() of Action is being clobbered by > the wrong object properties. > > Can _anyone_ , _please_, _pretty pleae_ confirm this? > I have sent 3 mails regarding this issue and it's hard to believe I'm > the only one that has problems using the Action accessors!!! > > Thanks, > Alejandro Imass > |
From: Jonas B. N. <jo...@gm...> - 2009-09-21 19:38:07
|
Hi Alejandro, Sorry for not responding, I have flagged your mail for follow-up, but never really got around to it. Please keep using the list, I am at least reading everything :-) jonasbn On 21/09/2009, at 21.14, Alejandro Imass wrote: > Ok, my bad, sorry folks. > > I was overriding init() but did not realize it was later called by > Base::new(), so I was calling it twice and with the wrong params. > Oops. > > I am now overriding new() and everything seems to be working fine. > > BTW, seems like I'm talking to myself here but what the heck, better > to resolve the thread for future reference.... > > Thanks, > Alejandro Imass > > On Sun, Sep 20, 2009 at 11:07 AM, Alejandro Imass <ai...@p2...> > wrote: >> I can almost confirm there is a bug in Workflow::Action::init >> >> Workflow::Action::init currently reads: >> >> sub init { >> my ( $self, $wf, $params ) = @_; >> >> When in fact, I think it should read: >> >> sub init { >> my ( $self, $params ) = @_; >> >> Just like the init() in Condition, State, Validator and so on. >> >> In fact Base::new() calls $self->init(@params); sow where the heck is >> $wf supposed to come from? >> If all this is true, then it's a fact that the Action accessors are >> currently broken and $self->param() of Action is being clobbered by >> the wrong object properties. >> >> Can _anyone_ , _please_, _pretty pleae_ confirm this? >> I have sent 3 mails regarding this issue and it's hard to believe I'm >> the only one that has problems using the Action accessors!!! >> >> Thanks, >> Alejandro Imass >> > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart > your > developing skills, take BlackBerry mobile applications to market and > stay > ahead of the curve. Join us from November 9-12, 2009. Register > now! > http://p.sf.net/sfu/devconf > _______________________________________________ > Perl-workflow-devel mailing list > Per...@li... > https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel |