perl-workflow-devel

[Perl-workflow-devel] RFE / Patchset - Custom Workflow Class

[Oliver W. <ma...@ol...>]

Hi Jonas,

please find attached another patch that enables users to have a custom
class for their workflow objects. It extends the create_workflow and
fetch_workflow methods by an additional parameter "wf_class". It is
fully backwards compatible, as long as one did not override the
footprint of those factory methods.

Also attached is a one-liner that prevents some warnings during testing.

Oliver

-- 
Protect your environment -  close windows and adopt a penguin!
PGP-Key: 3B2C 8095 A7DF 8BB5 2CFF  8168 CAB7 B0DD 3985 1721

Re: [Perl-workflow-devel] RFE / Patchset - Custom Workflow Class

[Jonas B. N. <jo...@gm...>]

Hi all and Oliver,

I have just released yet another developer release 1.34_3 containing patches from Oliver Welter.

From the Changes file:

- Applied patch from Oliver Welter implementing support for multiple factories

- Added patch from Oliver Welter implementing the feature of creating custom 
  workflow classes, in addition a patch to silence some warning emitted during test
  from Workflow::Validator

Feedback most welcome - have a nice weekend,

jonasbn
--
pauseid: JONASBN
email: jo...@cp...
twitter: jonasbn
blog: http://logicLAB.org/

On 24/09/2012, at 08.48, Oliver Welter <ma...@ol...> wrote:

> Hi Jonas,
> 
> please find attached another patch that enables users to have a custom
> class for their workflow objects. It extends the create_workflow and
> fetch_workflow methods by an additional parameter "wf_class". It is
> fully backwards compatible, as long as one did not override the
> footprint of those factory methods.
> 
> Also attached is a one-liner that prevents some warnings during testing.
> 
> Oliver
> 
> -- 
> Protect your environment -  close windows and adopt a penguin!
> PGP-Key: 3B2C 8095 A7DF 8BB5 2CFF  8168 CAB7 B0DD 3985 1721
> 
> <0001-Custom-Workflow-Class-Patch.patch><0002-Fix-a-undef-warning-in-Validator-during-tests.patch>------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel

Re: [Perl-workflow-devel] RFE / Patchset - Custom Workflow Class

[Oliver W. <ma...@ol...>]

Hi Jonas,

I need to come back to that really old post as I made a mistake when 
creating the patches, so the upstream code now misses one very important 
change.

In Workflow::Factory, Line 401 the invocation "Workflow->new" needs to 
be replaced with "$wf_class->new".

A patchfile against 1.35 is attached.

sorry for the inconvenience

Oliver

On 24.09.2012 08:48, Oliver Welter wrote:
> Hi Jonas,
>
> please find attached another patch that enables users to have a custom
> class for their workflow objects. It extends the create_workflow and
> fetch_workflow methods by an additional parameter "wf_class". It is
> fully backwards compatible, as long as one did not override the
> footprint of those factory methods.
>
> Also attached is a one-liner that prevents some warnings during testing.
>
> Oliver
>

-- 
Protect your environment -  close windows and adopt a penguin!
PGP-Key: 3B2C 8095 A7DF 8BB5 2CFF  8168 CAB7 B0DD 3985 1721