Thread: [Perl-workflow-devel] Fwd: Workflow patch
Brought to you by:
jonasbn
Menu
▾
▴
perl-workflow-devel
|
From: Jonas B. N. <jo...@gm...> - 2008-12-09 10:06:18
Attachments:
State.pm.diff
Workflow.pm.diff
|
Hello All,
Robert have now been added to our little group of developer - YAY!.
Which mean that his patch will be added to the branch dedicated for
this. A development release will be made as soon as he gives me a
heads up.
We have received some additional patches from Ivan Paponov (see
below), who has also joined this list.
If anybody has the time to evaluate the patches, please feel free. We
can discuss them openly here and I am sure Ivan will be happy to
answer any questions. If a preliminary review of the patches goes
through, I will create a branch for inclusion and test of the patches.
My $work TODO list is getting shorter, so I think I will be able to
dedicate a lot of time over Christmas for Workflow.
jonasbn
Begin forwarded message:
> From: Ivan Paponov <iva...@gm...>
> Date: 8. dec 2008 21.59.04 GMT+01:00
> To: jo...@cp...
> Subject: Workflow patch
> Reply-To: Ivan Paponov <iva...@gm...>
>
> Hi Jonas,
>
> My name is Ivan. I'm developing request management system, and the
> base of it is Workflow framework. This module is really flexible and
> powerful, it's really a pleasure to work with it.
>
> But I found one detail that I'm missing in Workflow.
> Here is the situation.
> We created request, and placed it into Submitted state.
> In submitted state we have following actions: terminate, place on hold
> and approve.
>
> <action name="terminate" class="MyApp::Action::Terminate" />
> <action name="place on hold" class="MyApp::Action::OnHold" />
> <action name="approve request" class="MyApp::Action::Approve" />
>
> First two should be available on page as simple links, and third is
> approval form, with comment box and approve button. And it's clear
> that
> first two action links have to be placed at the one part of page (in
> header near request title), and approval form at the other.
> Also I want to use $wf->get_current_actions(); function, but how
> should I distinguish where I should place current action, so I decided
> to add additional property to the action tag. It's - block.
>
> <action name="terminate" block="state change" class="..." />
> <action name="place on hold" block="state change" class="..." />
> <action name="approve request" block="approval" class="..." />
>
> And modified get_current_actions(), so now I can call
> my @actions = $wf->get_current_actions("approval");
> or
> my @actions = $wf->get_current_actions("state change");
> And I get only actions that are members of specified block.
>
> Patches are in the attachments, in case if you'll find this idea
> interesting.
>
> Thank you.
>
> --
> Best regards,
> Ivan Paponov
> iva...@gm... |
|
From: Jonas B. N. <jo...@gm...> - 2008-12-12 12:21:11
|
Hola,
I have had a look at Ivan's description of the functionality and it
seems very useful, not to say powerful.
So based on this I will move on with evaluating the actual patches.
I only have one issue at this point and that is the word/attribute
'block', I would prefer another name for this.
What about: type or group
Let me know what you think.
jonasbn
On 09/12/2008, at 11.06, Jonas Brømsø Nielsen wrote:
> Hello All,
>
> Robert have now been added to our little group of developer - YAY!.
>
> Which mean that his patch will be added to the branch dedicated for
> this. A development release will be made as soon as he gives me a
> heads up.
>
> We have received some additional patches from Ivan Paponov (see
> below), who has also joined this list.
>
> If anybody has the time to evaluate the patches, please feel free.
> We can discuss them openly here and I am sure Ivan will be happy to
> answer any questions. If a preliminary review of the patches goes
> through, I will create a branch for inclusion and test of the patches.
>
> My $work TODO list is getting shorter, so I think I will be able to
> dedicate a lot of time over Christmas for Workflow.
>
>
> jonasbn
>
> Begin forwarded message:
>
>> From: Ivan Paponov <iva...@gm...>
>> Date: 8. dec 2008 21.59.04 GMT+01:00
>> To: jo...@cp...
>> Subject: Workflow patch
>> Reply-To: Ivan Paponov <iva...@gm...>
>>
>> Hi Jonas,
>>
>> My name is Ivan. I'm developing request management system, and the
>> base of it is Workflow framework. This module is really flexible and
>> powerful, it's really a pleasure to work with it.
>>
>> But I found one detail that I'm missing in Workflow.
>> Here is the situation.
>> We created request, and placed it into Submitted state.
>> In submitted state we have following actions: terminate, place on
>> hold
>> and approve.
>>
>> <action name="terminate" class="MyApp::Action::Terminate" />
>> <action name="place on hold" class="MyApp::Action::OnHold" />
>> <action name="approve request" class="MyApp::Action::Approve" />
>>
>> First two should be available on page as simple links, and third is
>> approval form, with comment box and approve button. And it's clear
>> that
>> first two action links have to be placed at the one part of page (in
>> header near request title), and approval form at the other.
>> Also I want to use $wf->get_current_actions(); function, but how
>> should I distinguish where I should place current action, so I
>> decided
>> to add additional property to the action tag. It's - block.
>>
>> <action name="terminate" block="state change" class="..." />
>> <action name="place on hold" block="state change" class="..." />
>> <action name="approve request" block="approval" class="..." />
>>
>> And modified get_current_actions(), so now I can call
>> my @actions = $wf->get_current_actions("approval");
>> or
>> my @actions = $wf->get_current_actions("state change");
>> And I get only actions that are members of specified block.
>>
>> Patches are in the attachments, in case if you'll find this idea
>> interesting.
>>
>> Thank you.
>>
>> -- Best regards,
>> Ivan Paponov
>> iva...@gm...
> <State.pm.diff><Workflow.pm.diff>
|
|
From: phil r. <phi...@un...> - 2008-12-12 13:04:28
|
Yes, 'block' suggests that it might be something
to do with 'stop'.
I'd suggest 'section' (if I understand its function
correctly), but your 'type' or 'group' would also,
imho, be better than 'block'.
Cheers, Phil.
+++++++++++++++++++++++++++++++++++++
phi...@un...
Tel: +44 (0)161 257 3532
+++++++++++++++++++++++++++++++++++++
Jonas Brømsø Nielsen wrote:
> Hola,
>
> I have had a look at Ivan's description of the functionality and it
> seems very useful, not to say powerful.
>
> So based on this I will move on with evaluating the actual patches.
>
> I only have one issue at this point and that is the word/attribute
> 'block', I would prefer another name for this.
>
> What about: type or group
>
> Let me know what you think.
>
>
> jonasbn
>
>
> On 09/12/2008, at 11.06, Jonas Brømsø Nielsen wrote:
>
>
>> Hello All,
>>
>> Robert have now been added to our little group of developer - YAY!.
>>
>> Which mean that his patch will be added to the branch dedicated for
>> this. A development release will be made as soon as he gives me a
>> heads up.
>>
>> We have received some additional patches from Ivan Paponov (see
>> below), who has also joined this list.
>>
>> If anybody has the time to evaluate the patches, please feel free.
>> We can discuss them openly here and I am sure Ivan will be happy to
>> answer any questions. If a preliminary review of the patches goes
>> through, I will create a branch for inclusion and test of the patches.
>>
>> My $work TODO list is getting shorter, so I think I will be able to
>> dedicate a lot of time over Christmas for Workflow.
>>
>>
>> jonasbn
>>
>> Begin forwarded message:
>>
>>
>>> From: Ivan Paponov <iva...@gm...>
>>> Date: 8. dec 2008 21.59.04 GMT+01:00
>>> To: jo...@cp...
>>> Subject: Workflow patch
>>> Reply-To: Ivan Paponov <iva...@gm...>
>>>
>>> Hi Jonas,
>>>
>>> My name is Ivan. I'm developing request management system, and the
>>> base of it is Workflow framework. This module is really flexible and
>>> powerful, it's really a pleasure to work with it.
>>>
>>> But I found one detail that I'm missing in Workflow.
>>> Here is the situation.
>>> We created request, and placed it into Submitted state.
>>> In submitted state we have following actions: terminate, place on
>>> hold
>>> and approve.
>>>
>>> <action name="terminate" class="MyApp::Action::Terminate" />
>>> <action name="place on hold" class="MyApp::Action::OnHold" />
>>> <action name="approve request" class="MyApp::Action::Approve" />
>>>
>>> First two should be available on page as simple links, and third is
>>> approval form, with comment box and approve button. And it's clear
>>> that
>>> first two action links have to be placed at the one part of page (in
>>> header near request title), and approval form at the other.
>>> Also I want to use $wf->get_current_actions(); function, but how
>>> should I distinguish where I should place current action, so I
>>> decided
>>> to add additional property to the action tag. It's - block.
>>>
>>> <action name="terminate" block="state change" class="..." />
>>> <action name="place on hold" block="state change" class="..." />
>>> <action name="approve request" block="approval" class="..." />
>>>
>>> And modified get_current_actions(), so now I can call
>>> my @actions = $wf->get_current_actions("approval");
>>> or
>>> my @actions = $wf->get_current_actions("state change");
>>> And I get only actions that are members of specified block.
>>>
>>> Patches are in the attachments, in case if you'll find this idea
>>> interesting.
>>>
>>> Thank you.
>>>
>>> -- Best regards,
>>> Ivan Paponov
>>> iva...@gm...
>>>
>> <State.pm.diff><Workflow.pm.diff>
>>
>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you. Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
>
|
|
From: Ivan P. <iva...@gm...> - 2008-12-12 13:29:52
|
'Section' or 'group' are both good for this attribute name. As for "block", here is my explanation. I choose block on the analogy of "block-level" html elements (http://www.w3.org/TR/REC-html40/struct/global.html#h-7.5.3) > Yes, 'block' suggests that it might be something > to do with 'stop'. > I'd suggest 'section' (if I understand its function > correctly), but your 'type' or 'group' would also, > imho, be better than 'block'. > Cheers, Phil. > +++++++++++++++++++++++++++++++++++++ > phi...@un... > Tel: +44 (0)161 257 3532 > +++++++++++++++++++++++++++++++++++++ > Jonas Brømsø Nielsen wrote: >> Hola, >> >> I have had a look at Ivan's description of the functionality and it >> seems very useful, not to say powerful. >> >> So based on this I will move on with evaluating the actual patches. >> >> I only have one issue at this point and that is the word/attribute >> 'block', I would prefer another name for this. >> >> What about: type or group >> >> Let me know what you think. >> >> >> jonasbn >> >> -- Best regards, Ivan Paponov iva...@gm... |
|
From: Jonas B. N. <jo...@gm...> - 2008-12-15 21:20:12
|
Hi Phil and others,
I have pondered over this for a few days and I feel as you do that
block sounds like stop and in workflow context this might be
misinterpreted.
As for: type, this word could mean something else, since we are
programmers and we are building a framework.
Section is good, but I might prefer to use that for a workflow step or
a section of a workflow.
Which leads me to group.
Any other suggestions, we are talking about actions and logical
grouping (okay that was cheap), of these - what is the best word to
use for this.
I vote for group :)
jonasbn
On 12/12/2008, at 13.47, phil robinson wrote:
> Yes, 'block' suggests that it might be something
> to do with 'stop'.
>
> I'd suggest 'section' (if I understand its function
> correctly), but your 'type' or 'group' would also,
> imho, be better than 'block'.
>
> Cheers, Phil.
>
> +++++++++++++++++++++++++++++++++++++
> phi...@un...
> Tel: +44 (0)161 257 3532
> +++++++++++++++++++++++++++++++++++++
>
>
>
> Jonas Brømsø Nielsen wrote:
>> Hola,
>>
>> I have had a look at Ivan's description of the functionality and it
>> seems very useful, not to say powerful.
>>
>> So based on this I will move on with evaluating the actual patches.
>>
>> I only have one issue at this point and that is the word/attribute
>> 'block', I would prefer another name for this.
>>
>> What about: type or group
>>
>> Let me know what you think.
>>
>>
>> jonasbn
>>
>>
>> On 09/12/2008, at 11.06, Jonas Brømsø Nielsen wrote:
>>
>>
>>> Hello All,
>>>
>>> Robert have now been added to our little group of developer - YAY!.
>>>
>>> Which mean that his patch will be added to the branch dedicated for
>>> this. A development release will be made as soon as he gives me a
>>> heads up.
>>>
>>> We have received some additional patches from Ivan Paponov (see
>>> below), who has also joined this list.
>>>
>>> If anybody has the time to evaluate the patches, please feel free.
>>> We can discuss them openly here and I am sure Ivan will be happy to
>>> answer any questions. If a preliminary review of the patches goes
>>> through, I will create a branch for inclusion and test of the
>>> patches.
>>>
>>> My $work TODO list is getting shorter, so I think I will be able to
>>> dedicate a lot of time over Christmas for Workflow.
>>>
>>>
>>> jonasbn
>>>
>>> Begin forwarded message:
>>>
>>>
>>>> From: Ivan Paponov <iva...@gm...>
>>>> Date: 8. dec 2008 21.59.04 GMT+01:00
>>>> To: jo...@cp...
>>>> Subject: Workflow patch
>>>> Reply-To: Ivan Paponov <iva...@gm...>
>>>>
>>>> Hi Jonas,
>>>>
>>>> My name is Ivan. I'm developing request management system, and the
>>>> base of it is Workflow framework. This module is really flexible
>>>> and
>>>> powerful, it's really a pleasure to work with it.
>>>>
>>>> But I found one detail that I'm missing in Workflow.
>>>> Here is the situation.
>>>> We created request, and placed it into Submitted state.
>>>> In submitted state we have following actions: terminate, place on
>>>> hold
>>>> and approve.
>>>>
>>>> <action name="terminate" class="MyApp::Action::Terminate" />
>>>> <action name="place on hold" class="MyApp::Action::OnHold" />
>>>> <action name="approve request" class="MyApp::Action::Approve" />
>>>>
>>>> First two should be available on page as simple links, and third is
>>>> approval form, with comment box and approve button. And it's clear
>>>> that
>>>> first two action links have to be placed at the one part of page
>>>> (in
>>>> header near request title), and approval form at the other.
>>>> Also I want to use $wf->get_current_actions(); function, but how
>>>> should I distinguish where I should place current action, so I
>>>> decided
>>>> to add additional property to the action tag. It's - block.
>>>>
>>>> <action name="terminate" block="state change" class="..." />
>>>> <action name="place on hold" block="state change"
>>>> class="..." />
>>>> <action name="approve request" block="approval" class="..." />
>>>>
>>>> And modified get_current_actions(), so now I can call
>>>> my @actions = $wf->get_current_actions("approval");
>>>> or
>>>> my @actions = $wf->get_current_actions("state change");
>>>> And I get only actions that are members of specified block.
>>>>
>>>> Patches are in the attachments, in case if you'll find this idea
>>>> interesting.
>>>>
>>>> Thank you.
>>>>
>>>> -- Best regards,
>>>> Ivan Paponov
>>>> iva...@gm...
>>>>
>>> <State.pm.diff><Workflow.pm.diff>
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas,
>> Nevada.
>> The future of the web can't happen without you. Join us at MIX09
>> to help
>> pave the way to the Next Web now. Learn more and register at
>> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
>> _______________________________________________
>> Perl-workflow-devel mailing list
>> Per...@li...
>> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
>>
>
>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas,
> Nevada.
> The future of the web can't happen without you. Join us at MIX09 to
> help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
|
|
From: Andrew O'B. <an...@or...> - 2008-12-16 00:36:06
|
Hi Jonas et al, > Which leads me to group. > > Any other suggestions, we are talking about actions and logical > grouping (okay that was cheap), of these - what is the best word to > use for this. > > I vote for group :) I agree. Makes sense to me that we're talking about a logical, arbitrary group name to be (ab)used as the programmer sees fit. Andrew |
|
From: phil r. <phi...@un...> - 2008-12-16 11:26:17
|
Yep, 'group's good. Cheers, Phil. Andrew O'Brien wrote: > Hi Jonas et al, > > >> Which leads me to group. >> >> Any other suggestions, we are talking about actions and logical >> grouping (okay that was cheap), of these - what is the best word to >> use for this. >> >> I vote for group :) >> > > I agree. > > Makes sense to me that we're talking about a logical, arbitrary group name to be (ab)used as the programmer sees fit. > > Andrew > > -- +++++++++++++++++++++++++++++++++++++ phi...@un... Tel: +44 (0)161 257 3532 +++++++++++++++++++++++++++++++++++++ |
|
From: Stockdale, R. <rf...@bu...> - 2008-12-15 16:00:33
|
Hello,
I have checked in my changes and some new tests for:
http://rt.cpan.org/Public/Bug/Display.html?id=38024
--
Bob Stockdale
Administrative Computing Services
University at Buffalo
(716) 645-5334
rf...@bu...
> From: Jonas Brømsø Nielsen <jo...@gm...>
> Date: Tue, 9 Dec 2008 05:06:12 -0500
> To: Workflow development list <per...@li...>
> Subject: [Perl-workflow-devel] Fwd: Workflow patch
>
> Hello All,
>
> Robert have now been added to our little group of developer - YAY!.
>
> Which mean that his patch will be added to the branch dedicated for
> this. A development release will be made as soon as he gives me a
> heads up.
>
> We have received some additional patches from Ivan Paponov (see
> below), who has also joined this list.
>
> If anybody has the time to evaluate the patches, please feel free. We
> can discuss them openly here and I am sure Ivan will be happy to
> answer any questions. If a preliminary review of the patches goes
> through, I will create a branch for inclusion and test of the patches.
>
> My $work TODO list is getting shorter, so I think I will be able to
> dedicate a lot of time over Christmas for Workflow.
>
>
> jonasbn
>
> Begin forwarded message:
>
>> From: Ivan Paponov <iva...@gm...>
>> Date: 8. dec 2008 21.59.04 GMT+01:00
>> To: jo...@cp...
>> Subject: Workflow patch
>> Reply-To: Ivan Paponov <iva...@gm...>
>>
>> Hi Jonas,
>>
>> My name is Ivan. I'm developing request management system, and the
>> base of it is Workflow framework. This module is really flexible and
>> powerful, it's really a pleasure to work with it.
>>
>> But I found one detail that I'm missing in Workflow.
>> Here is the situation.
>> We created request, and placed it into Submitted state.
>> In submitted state we have following actions: terminate, place on hold
>> and approve.
>>
>> <action name="terminate" class="MyApp::Action::Terminate" />
>> <action name="place on hold" class="MyApp::Action::OnHold" />
>> <action name="approve request" class="MyApp::Action::Approve" />
>>
>> First two should be available on page as simple links, and third is
>> approval form, with comment box and approve button. And it's clear
>> that
>> first two action links have to be placed at the one part of page (in
>> header near request title), and approval form at the other.
>> Also I want to use $wf->get_current_actions(); function, but how
>> should I distinguish where I should place current action, so I decided
>> to add additional property to the action tag. It's - block.
>>
>> <action name="terminate" block="state change" class="..." />
>> <action name="place on hold" block="state change" class="..." />
>> <action name="approve request" block="approval" class="..." />
>>
>> And modified get_current_actions(), so now I can call
>> my @actions = $wf->get_current_actions("approval");
>> or
>> my @actions = $wf->get_current_actions("state change");
>> And I get only actions that are members of specified block.
>>
>> Patches are in the attachments, in case if you'll find this idea
>> interesting.
>>
>> Thank you.
>>
>> --
>> Best regards,
>> Ivan Paponov
>> iva...@gm...
|
|
From: Jonas B. N. <jo...@gm...> - 2008-12-15 20:49:28
|
Hello Robert and all, I have just merged the changes from release 0.32_5 into your branch and have made a release 0.32_6 to CPAN for all of you to evaluate. Thanks for the effort. Please let me know if any of you experience any trouble, all tests currently pass, so I am keen on feedback from those of you who might have the guts to use the release and cover the parts we do not have covered with tests just yet. Of course I will be following the CPAN testers reports closely. Next step will be the patches from Ivan. jonasbn On 15/12/2008, at 17.00, Stockdale, Robert wrote: > Hello, > > I have checked in my changes and some new tests for: > > http://rt.cpan.org/Public/Bug/Display.html?id=38024 > > -- > Bob Stockdale > Administrative Computing Services > University at Buffalo > (716) 645-5334 > rf...@bu... > > >> From: Jonas Brømsø Nielsen <jo...@gm...> >> Date: Tue, 9 Dec 2008 05:06:12 -0500 >> To: Workflow development list <per...@li...> >> Subject: [Perl-workflow-devel] Fwd: Workflow patch >> >> Hello All, >> >> Robert have now been added to our little group of developer - YAY!. >> >> Which mean that his patch will be added to the branch dedicated for >> this. A development release will be made as soon as he gives me a >> heads up. >> >> We have received some additional patches from Ivan Paponov (see >> below), who has also joined this list. >> >> If anybody has the time to evaluate the patches, please feel free. We >> can discuss them openly here and I am sure Ivan will be happy to >> answer any questions. If a preliminary review of the patches goes >> through, I will create a branch for inclusion and test of the >> patches. >> >> My $work TODO list is getting shorter, so I think I will be able to >> dedicate a lot of time over Christmas for Workflow. >> >> >> jonasbn >> >> Begin forwarded message: >> >>> From: Ivan Paponov <iva...@gm...> >>> Date: 8. dec 2008 21.59.04 GMT+01:00 >>> To: jo...@cp... >>> Subject: Workflow patch >>> Reply-To: Ivan Paponov <iva...@gm...> >>> >>> Hi Jonas, >>> >>> My name is Ivan. I'm developing request management system, and the >>> base of it is Workflow framework. This module is really flexible and >>> powerful, it's really a pleasure to work with it. >>> >>> But I found one detail that I'm missing in Workflow. >>> Here is the situation. >>> We created request, and placed it into Submitted state. >>> In submitted state we have following actions: terminate, place on >>> hold >>> and approve. >>> >>> <action name="terminate" class="MyApp::Action::Terminate" /> >>> <action name="place on hold" class="MyApp::Action::OnHold" /> >>> <action name="approve request" class="MyApp::Action::Approve" /> >>> >>> First two should be available on page as simple links, and third is >>> approval form, with comment box and approve button. And it's clear >>> that >>> first two action links have to be placed at the one part of page (in >>> header near request title), and approval form at the other. >>> Also I want to use $wf->get_current_actions(); function, but how >>> should I distinguish where I should place current action, so I >>> decided >>> to add additional property to the action tag. It's - block. >>> >>> <action name="terminate" block="state change" class="..." /> >>> <action name="place on hold" block="state change" class="..." /> >>> <action name="approve request" block="approval" class="..." /> >>> >>> And modified get_current_actions(), so now I can call >>> my @actions = $wf->get_current_actions("approval"); >>> or >>> my @actions = $wf->get_current_actions("state change"); >>> And I get only actions that are members of specified block. >>> >>> Patches are in the attachments, in case if you'll find this idea >>> interesting. >>> >>> Thank you. >>> >>> -- >>> Best regards, >>> Ivan Paponov >>> iva...@gm... > |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X