perl-workflow-devel

[Perl-workflow-devel] Date formats in Workflow/Persister/DBI.pm

[Jim B. <cb...@bu...>]

Hello all,

I've been working with the Workflow module using Oracle as the DB 
back-end. I found that the default date formats didn't work with our 
Oracle DB. I was able to change them by hacking 
Workflow/Persister/DBI.pm, but I was wondering if there was a way to 
make this easier to configure.

Maybe make the format something you could set in the persister.xml 
config file?

Any other ideas? Anyone else have issues with the default data formats?

The changes I made were like:

#my $parser = DateTime::Format::Strptime->new( pattern => '%Y-%m-%d 
%H:%M' );
my $parser = DateTime::Format::Strptime->new( pattern => 
'%m:%d:%Y:%H:%M:%S' );


Thanks,
Jim


-- 
Jim Brandt
Administrative Computing Services
University at Buffalo

Re: [Perl-workflow-devel] Date formats in Workflow/Persister/DBI.pm

[Jonas B. N. <jo...@gm...>]

Hello Jim and welcome,

Your suggestion for putting the format in the persister config is  
good, since I am sure that the different DB backends use differing  
formats and we also have to adapt/support non-db persisters.

So does anybody else have a take on this, else I will set up a task  
for this and put it in the roadmap.


jonasbn

On 04/06/2007, at 21.35, Jim Brandt wrote:

> Hello all,
>
> I've been working with the Workflow module using Oracle as the DB
> back-end. I found that the default date formats didn't work with our
> Oracle DB. I was able to change them by hacking
> Workflow/Persister/DBI.pm, but I was wondering if there was a way to
> make this easier to configure.
>
> Maybe make the format something you could set in the persister.xml
> config file?
>
> Any other ideas? Anyone else have issues with the default data  
> formats?
>
> The changes I made were like:
>
> #my $parser = DateTime::Format::Strptime->new( pattern => '%Y-%m-%d
> %H:%M' );
> my $parser = DateTime::Format::Strptime->new( pattern =>
> '%m:%d:%Y:%H:%M:%S' );
>
>
> Thanks,
> Jim
>
>
> -- 
> Jim Brandt
> Administrative Computing Services
> University at Buffalo
>
>
>
> ---------------------------------------------------------------------- 
> ---
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel

Re: [Perl-workflow-devel] Date formats in Workflow/Persister/DBI.pm

[Jim B. <cb...@bu...>]

I can work up a patch if you like. I can make the new param optional so 
it defaults to the current setting. This should prevent any fix from 
breaking anyone's current configuration.

The only challenge I see so far is a $parser package variable at the top 
of Persister/DBI.pm:

my $parser = DateTime::Format::Strptime->new( pattern => '%Y-%m-%d %H:%M' );

Anyone know why it's up there? Does it need to be global or could it be 
moved to object data?

Thanks,
Jim


Jonas B. Nielsen wrote:
> Hello Jim and welcome,
> 
> Your suggestion for putting the format in the persister config is good, 
> since I am sure that the different DB backends use differing formats and 
> we also have to adapt/support non-db persisters.
> 
> So does anybody else have a take on this, else I will set up a task for 
> this and put it in the roadmap.
> 
> 
> jonasbn
> 
> On 04/06/2007, at 21.35, Jim Brandt wrote:
> 
>> Hello all,
>>
>> I've been working with the Workflow module using Oracle as the DB
>> back-end. I found that the default date formats didn't work with our
>> Oracle DB. I was able to change them by hacking
>> Workflow/Persister/DBI.pm, but I was wondering if there was a way to
>> make this easier to configure.
>>
>> Maybe make the format something you could set in the persister.xml
>> config file?
>>
>> Any other ideas? Anyone else have issues with the default data formats?
>>
>> The changes I made were like:
>>
>> #my $parser = DateTime::Format::Strptime->new( pattern => '%Y-%m-%d
>> %H:%M' );
>> my $parser = DateTime::Format::Strptime->new( pattern =>
>> '%m:%d:%Y:%H:%M:%S' );
>>
>>
>> Thanks,
>> Jim
>>
>>
>> -- 
>> Jim Brandt
>> Administrative Computing Services
>> University at Buffalo
>>
>>
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by DB2 Express
>> Download DB2 Express C - the FREE version of DB2 express and take
>> control of your XML. No limits. Just data. Click to get it now.
>> http://sourceforge.net/powerbar/db2/
>> _______________________________________________
>> Perl-workflow-devel mailing list
>> Per...@li...
>> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
> 

-- 
Jim Brandt
Administrative Computing Services
University at Buffalo