perl-workflow-devel — discussion list for developers of Perl Workflow

Re: [Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Jonas B. N. <jo...@gm...>]

Hi Kiffin,

How are you invoking the make test step, from the CPAN shell or manually?

jonasbn

On 28/12/2009, at 11.54, Kiffin Gish wrote:

> make test fails for me:
> 
> #   Failed test 'use Workflow::Action::Mailer;'
> #   Failed test 'use Workflow::Action::Null;'
> #   Failed test 'use Workflow::Action;'
> #   Failed test 'use Workflow::Config::Perl;'
> #   Failed test 'use Workflow::Config::XML;'
> #   Failed test 'use Workflow::Config;'
> #   Failed test 'use Workflow::Factory;'
> #   Failed test 'use Workflow::State;'
> #   Failed test 'use Workflow;'
> 
> Any idea what I may be doing wrong?
> 
> On Sun, 2009-12-27 at 15:42 +0100, Jonas Brømsø Nielsen wrote:
>> Hello All,
>> 
>> I just threw some more wood on the fire and merged 1.33_6 into trunk. So all branches have now been merged into trunk. So i have just uploaded the release candidate for 1.33, 1.33_8, it contains all the bug fixes and patches applied since the release of 1.32. All changes are described in the Changes file.
>> 
>> If you have the time, please test and evaluate this release,
>> 
>> We have received some new patches (see RT for reference), so I would love to schedule some more frequent releases,
>> 
>> Take care,
>> 
>> jonasbn
>> ------------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Verizon Developer Community
>> Take advantage of Verizon's best-in-class app development support
>> A streamlined, 14 day to market process makes app distribution fast and easy
>> Join now and get one step closer to millions of Verizon customers
>> http://p.sf.net/sfu/verizon-dev2dev 
>> _______________________________________________
>> Perl-workflow-devel mailing list
>> Per...@li...
>> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
> 
> 
> -- 
> Kiffin Gish <Kif...@pl...>
> Gouda, The Netherlands
> 
> 

Re: [Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Kiffin G. <kif...@pl...>]

Manually the usual way, as follows:

wget
http://search.cpan.org/CPAN/authors/id/J/JO/JONASBN/Workflow-1.33_8.tar.gz
tar xf Workflow-1.33_8.tar.gz
cd Workflow-1.33_8
perl Makefile.PL
make
make test
make install


On Mon, 2009-12-28 at 13:31 +0100, Jonas Brømsø Nielsen wrote:
> Hi Kiffin,
> 
> How are you invoking the make test step, from the CPAN shell or manually?
> 
> jonasbn
> 
> On 28/12/2009, at 11.54, Kiffin Gish wrote:
> 
> > make test fails for me:
> > 
> > #   Failed test 'use Workflow::Action::Mailer;'
> > #   Failed test 'use Workflow::Action::Null;'
> > #   Failed test 'use Workflow::Action;'
> > #   Failed test 'use Workflow::Config::Perl;'
> > #   Failed test 'use Workflow::Config::XML;'
> > #   Failed test 'use Workflow::Config;'
> > #   Failed test 'use Workflow::Factory;'
> > #   Failed test 'use Workflow::State;'
> > #   Failed test 'use Workflow;'
> > 
> > Any idea what I may be doing wrong?
> > 
> > On Sun, 2009-12-27 at 15:42 +0100, Jonas Brømsø Nielsen wrote:
> >> Hello All,
> >> 
> >> I just threw some more wood on the fire and merged 1.33_6 into trunk. So all branches have now been merged into trunk. So i have just uploaded the release candidate for 1.33, 1.33_8, it contains all the bug fixes and patches applied since the release of 1.32. All changes are described in the Changes file.
> >> 
> >> If you have the time, please test and evaluate this release,
> >> 
> >> We have received some new patches (see RT for reference), so I would love to schedule some more frequent releases,
> >> 
> >> Take care,
> >> 
> >> jonasbn
> >> ------------------------------------------------------------------------------
> >> This SF.Net email is sponsored by the Verizon Developer Community
> >> Take advantage of Verizon's best-in-class app development support
> >> A streamlined, 14 day to market process makes app distribution fast and easy
> >> Join now and get one step closer to millions of Verizon customers
> >> http://p.sf.net/sfu/verizon-dev2dev 
> >> _______________________________________________
> >> Perl-workflow-devel mailing list
> >> Per...@li...
> >> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
> > 
> > 
> > -- 
> > Kiffin Gish <Kif...@pl...>
> > Gouda, The Netherlands
> > 
> > 
> 


-- 
Kiffin Gish <Kif...@pl...>
Gouda, The Netherlands

Re: [Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Kiffin G. <kif...@pl...>]

As requested, here is the complete output (see attachment). Hope this
helps.

On Mon, 2009-12-28 at 13:43 +0100, Jonas Brømsø Nielsen wrote:
> Hi Kiffin,
> 
> Can you include the complete output, especially from the step: perl Makefile.PL 
> 
> jonasbn
> 
> On 28/12/2009, at 13.36, Kiffin Gish wrote:
> 
> > Manually the usual way, as follows:
> > 
> > wget
> > http://search.cpan.org/CPAN/authors/id/J/JO/JONASBN/Workflow-1.33_8.tar.gz
> > tar xf Workflow-1.33_8.tar.gz
> > cd Workflow-1.33_8
> > perl Makefile.PL
> > make
> > make test
> > make install
> > 
> > 
> > On Mon, 2009-12-28 at 13:31 +0100, Jonas Brømsø Nielsen wrote:
> >> Hi Kiffin,
> >> 
> >> How are you invoking the make test step, from the CPAN shell or manually?
> >> 
> >> jonasbn
> >> 
> >> On 28/12/2009, at 11.54, Kiffin Gish wrote:
> >> 
> >>> make test fails for me:
> >>> 
> >>> #   Failed test 'use Workflow::Action::Mailer;'
> >>> #   Failed test 'use Workflow::Action::Null;'
> >>> #   Failed test 'use Workflow::Action;'
> >>> #   Failed test 'use Workflow::Config::Perl;'
> >>> #   Failed test 'use Workflow::Config::XML;'
> >>> #   Failed test 'use Workflow::Config;'
> >>> #   Failed test 'use Workflow::Factory;'
> >>> #   Failed test 'use Workflow::State;'
> >>> #   Failed test 'use Workflow;'
> >>> 
> >>> Any idea what I may be doing wrong?
> >>> 
> >>> On Sun, 2009-12-27 at 15:42 +0100, Jonas Brømsø Nielsen wrote:
> >>>> Hello All,
> >>>> 
> >>>> I just threw some more wood on the fire and merged 1.33_6 into trunk. So all branches have now been merged into trunk. So i have just uploaded the release candidate for 1.33, 1.33_8, it contains all the bug fixes and patches applied since the release of 1.32. All changes are described in the Changes file.
> >>>> 
> >>>> If you have the time, please test and evaluate this release,
> >>>> 
> >>>> We have received some new patches (see RT for reference), so I would love to schedule some more frequent releases,
> >>>> 
> >>>> Take care,
> >>>> 
> >>>> jonasbn
> >>>> ------------------------------------------------------------------------------
> >>>> This SF.Net email is sponsored by the Verizon Developer Community
> >>>> Take advantage of Verizon's best-in-class app development support
> >>>> A streamlined, 14 day to market process makes app distribution fast and easy
> >>>> Join now and get one step closer to millions of Verizon customers
> >>>> http://p.sf.net/sfu/verizon-dev2dev 
> >>>> _______________________________________________
> >>>> Perl-workflow-devel mailing list
> >>>> Per...@li...
> >>>> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
> >>> 
> >>> 
> >>> -- 
> >>> Kiffin Gish <Kif...@pl...>
> >>> Gouda, The Netherlands
> >>> 
> >>> 
> >> 
> > 
> > 
> > -- 
> > Kiffin Gish <Kif...@pl...>
> > Gouda, The Netherlands
> > 
> > 
> 


-- 
Kiffin Gish <Kif...@pl...>
Gouda, The Netherlands

Re: [Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Jonas B. N. <jo...@gm...>]

Hi Kiffin,

Can you include the complete output, especially from the step: perl Makefile.PL 

jonasbn

On 28/12/2009, at 13.36, Kiffin Gish wrote:

> Manually the usual way, as follows:
> 
> wget
> http://search.cpan.org/CPAN/authors/id/J/JO/JONASBN/Workflow-1.33_8.tar.gz
> tar xf Workflow-1.33_8.tar.gz
> cd Workflow-1.33_8
> perl Makefile.PL
> make
> make test
> make install
> 
> 
> On Mon, 2009-12-28 at 13:31 +0100, Jonas Brømsø Nielsen wrote:
>> Hi Kiffin,
>> 
>> How are you invoking the make test step, from the CPAN shell or manually?
>> 
>> jonasbn
>> 
>> On 28/12/2009, at 11.54, Kiffin Gish wrote:
>> 
>>> make test fails for me:
>>> 
>>> #   Failed test 'use Workflow::Action::Mailer;'
>>> #   Failed test 'use Workflow::Action::Null;'
>>> #   Failed test 'use Workflow::Action;'
>>> #   Failed test 'use Workflow::Config::Perl;'
>>> #   Failed test 'use Workflow::Config::XML;'
>>> #   Failed test 'use Workflow::Config;'
>>> #   Failed test 'use Workflow::Factory;'
>>> #   Failed test 'use Workflow::State;'
>>> #   Failed test 'use Workflow;'
>>> 
>>> Any idea what I may be doing wrong?
>>> 
>>> On Sun, 2009-12-27 at 15:42 +0100, Jonas Brømsø Nielsen wrote:
>>>> Hello All,
>>>> 
>>>> I just threw some more wood on the fire and merged 1.33_6 into trunk. So all branches have now been merged into trunk. So i have just uploaded the release candidate for 1.33, 1.33_8, it contains all the bug fixes and patches applied since the release of 1.32. All changes are described in the Changes file.
>>>> 
>>>> If you have the time, please test and evaluate this release,
>>>> 
>>>> We have received some new patches (see RT for reference), so I would love to schedule some more frequent releases,
>>>> 
>>>> Take care,
>>>> 
>>>> jonasbn
>>>> ------------------------------------------------------------------------------
>>>> This SF.Net email is sponsored by the Verizon Developer Community
>>>> Take advantage of Verizon's best-in-class app development support
>>>> A streamlined, 14 day to market process makes app distribution fast and easy
>>>> Join now and get one step closer to millions of Verizon customers
>>>> http://p.sf.net/sfu/verizon-dev2dev 
>>>> _______________________________________________
>>>> Perl-workflow-devel mailing list
>>>> Per...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
>>> 
>>> 
>>> -- 
>>> Kiffin Gish <Kif...@pl...>
>>> Gouda, The Netherlands
>>> 
>>> 
>> 
> 
> 
> -- 
> Kiffin Gish <Kif...@pl...>
> Gouda, The Netherlands
> 
> 

Re: [Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Kiffin G. <kif...@pl...>]

make test fails for me:

#   Failed test 'use Workflow::Action::Mailer;'
#   Failed test 'use Workflow::Action::Null;'
#   Failed test 'use Workflow::Action;'
#   Failed test 'use Workflow::Config::Perl;'
#   Failed test 'use Workflow::Config::XML;'
#   Failed test 'use Workflow::Config;'
#   Failed test 'use Workflow::Factory;'
#   Failed test 'use Workflow::State;'
#   Failed test 'use Workflow;'

Any idea what I may be doing wrong?

On Sun, 2009-12-27 at 15:42 +0100, Jonas Brømsø Nielsen wrote:
> Hello All,
> 
> I just threw some more wood on the fire and merged 1.33_6 into trunk. So all branches have now been merged into trunk. So i have just uploaded the release candidate for 1.33, 1.33_8, it contains all the bug fixes and patches applied since the release of 1.32. All changes are described in the Changes file.
> 
> If you have the time, please test and evaluate this release,
> 
> We have received some new patches (see RT for reference), so I would love to schedule some more frequent releases,
> 
> Take care,
> 
> jonasbn
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev 
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel


-- 
Kiffin Gish <Kif...@pl...>
Gouda, The Netherlands

Re: [Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Kiffin G. <kif...@pl...>]

>From CPAN. But now it works, guess it took time to enable.

On Sun, 2009-12-27 at 19:09 +0100, Jonas Brømsø Nielsen wrote:
> Hi,
> 
> Where did you download from?
> 
> Jonas
> 
> Sendt fra min iPhone
> 
> Den 27/12/2009 kl. 16.50 skrev Kiffin Gish <kif...@pl...>:
> 
> > Tried to download but got an object not found error.
> >
> > On Sun, 2009-12-27 at 15:42 +0100, Jonas Brømsø Nielsen wrote:
> >> Hello All,
> >>
> >> I just threw some more wood on the fire and merged 1.33_6 into  
> >> trunk. So all branches have now been merged into trunk. So i have  
> >> just uploaded the release candidate for 1.33, 1.33_8, it contains  
> >> all the bug fixes and patches applied since the release of 1.32.  
> >> All changes are described in the Changes file.
> >>
> >> If you have the time, please test and evaluate this release,
> >>
> >> We have received some new patches (see RT for reference), so I  
> >> would love to schedule some more frequent releases,
> >>
> >> Take care,
> >>
> >> jonasbn
> >> --- 
> >> --- 
> >> --- 
> >> ---------------------------------------------------------------------
> >> This SF.Net email is sponsored by the Verizon Developer Community
> >> Take advantage of Verizon's best-in-class app development support
> >> A streamlined, 14 day to market process makes app distribution fast  
> >> and easy
> >> Join now and get one step closer to millions of Verizon customers
> >> http://p.sf.net/sfu/verizon-dev2dev
> >> _______________________________________________
> >> Perl-workflow-devel mailing list
> >> Per...@li...
> >> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
> >
> >
> > -- 
> > Kiffin Gish <Kif...@pl...>
> > Gouda, The Netherlands
> >
> >


-- 
Kiffin Gish <Kif...@pl...>
Gouda, The Netherlands

Re: [Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Jonas B. N. <jo...@gm...>]

Hi,

Where did you download from?

Jonas

Sendt fra min iPhone

Den 27/12/2009 kl. 16.50 skrev Kiffin Gish <kif...@pl...>:

> Tried to download but got an object not found error.
>
> On Sun, 2009-12-27 at 15:42 +0100, Jonas Brømsø Nielsen wrote:
>> Hello All,
>>
>> I just threw some more wood on the fire and merged 1.33_6 into  
>> trunk. So all branches have now been merged into trunk. So i have  
>> just uploaded the release candidate for 1.33, 1.33_8, it contains  
>> all the bug fixes and patches applied since the release of 1.32.  
>> All changes are described in the Changes file.
>>
>> If you have the time, please test and evaluate this release,
>>
>> We have received some new patches (see RT for reference), so I  
>> would love to schedule some more frequent releases,
>>
>> Take care,
>>
>> jonasbn
>> --- 
>> --- 
>> --- 
>> ---------------------------------------------------------------------
>> This SF.Net email is sponsored by the Verizon Developer Community
>> Take advantage of Verizon's best-in-class app development support
>> A streamlined, 14 day to market process makes app distribution fast  
>> and easy
>> Join now and get one step closer to millions of Verizon customers
>> http://p.sf.net/sfu/verizon-dev2dev
>> _______________________________________________
>> Perl-workflow-devel mailing list
>> Per...@li...
>> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
>
>
> -- 
> Kiffin Gish <Kif...@pl...>
> Gouda, The Netherlands
>
>

Re: [Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Kiffin G. <kif...@pl...>]

Tried to download but got an object not found error.

On Sun, 2009-12-27 at 15:42 +0100, Jonas Brømsø Nielsen wrote:
> Hello All,
> 
> I just threw some more wood on the fire and merged 1.33_6 into trunk. So all branches have now been merged into trunk. So i have just uploaded the release candidate for 1.33, 1.33_8, it contains all the bug fixes and patches applied since the release of 1.32. All changes are described in the Changes file.
> 
> If you have the time, please test and evaluate this release,
> 
> We have received some new patches (see RT for reference), so I would love to schedule some more frequent releases,
> 
> Take care,
> 
> jonasbn
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev 
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel


-- 
Kiffin Gish <Kif...@pl...>
Gouda, The Netherlands

[Perl-workflow-devel] Release 1.33_8, just uploaded to CPAN

[Jonas B. N. <jo...@gm...>]

Hello All,

I just threw some more wood on the fire and merged 1.33_6 into trunk. So all branches have now been merged into trunk. So i have just uploaded the release candidate for 1.33, 1.33_8, it contains all the bug fixes and patches applied since the release of 1.32. All changes are described in the Changes file.

If you have the time, please test and evaluate this release,

We have received some new patches (see RT for reference), so I would love to schedule some more frequent releases,

Take care,

jonasbn

[Perl-workflow-devel] Release 1.33_7, just uploaded to CPAN

[Jonas B. N. <jo...@gm...>]

Hello All,

After a way too long break from Workflow development I finally found the necessary time to get my work on the action_group_patch branch concluded. Ivan's patch has been added and all tests pass again.

This has resulted in the development release 1.33_7, which should be available on CPAN shortly.

The release only contains the patch and is based on 1.32 without any influences from other development releases or branches. 

I expect to make a last development release prior to the release of 1.33, namely: 1.33_8, this will be based on trunk and will include all development releases and will be the release candidate for 1.33, so your feedback is most welcome. The release is scheduled to go our today or tomorrow. Please feel free to test or evaluate the 1.33_7 release and provide me with feedback prior to closing 1.33, of course 1.33_8 is more interesting, but if you cannot wait - 1.33_7 should be up for grasps.

Merry X-mas everybody,

jonasbn

[Perl-workflow-devel] Release 1.33_6

[<jo...@gm...>]

Hello All,

Release 1.33_6 has just been uploaded to CPAN.

This release is a cumulative release of all the developer releases on the  
1.33 roadmap.

It contains development from Alejandro Imass, please see the Changes file  
for details.

Only one branch remains before, we can move on with an actual release of  
1.33

Feedback on the above release is of course welcome, the branch has not been  
merged into trunk at this time.

Take care,

jonasbn

Re: [Perl-workflow-devel] Changes commited for developer release 1.33_6

[Jonas B. N. <jo...@gm...>]

Hi Alejandro,

I will make a release 1.33_6 tomorrow, so we can get the patch out in  
the open, thanks for contributing.

jonasbn

On 26/09/2009, at 20.10, Alejandro Imass wrote:

> Hi all,
>
> I have committed my proposed changes to the branch "field_types",
> corresponding to the next correlative developer release 1.33_6
> (committed to svn revision 491)
>
> These changes allow users to formally override new() in Actions and
> InputFields to better adapt Workflow.p;m to their specific
> implementations. My first thought at this was to extend and complete
> the InputField "type" which was a work in progress according to the
> pod, but later realized that this be better left implementation
> dependent, and it was way more generic to formalize an extension
> mechanism for actions and fields.
>
> Here are the detailed changes:
>
>
> aimass@ctlt10:~/projects/perl-workflow/branches/field_types$ svn log  
> -v -r491
> ------------------------------------------------------------------------
> r491 | aimass | 2009-09-26 14:05:54 -0400 (Sat, 26 Sep 2009) | 1 line
> Changed paths:
>   M /branches/field_types/workflow/Changes
>   M /branches/field_types/workflow/lib/Workflow/Action/InputField.pm
>   M /branches/field_types/workflow/lib/Workflow/Action.pm
>
> formalization of action and input field extentions by making new()
> formally public and safely overrideable; modified pod accordingly with
> detailed examples
> ------------------------------------------------------------------------
>
> aimass@ctlt10:~/projects/perl-workflow/branches/field_types$ cat
> workflow/Changes
>
> # $Id: Changes 491 2009-09-26 18:05:54Z aimass $
>
> 1.33_6
>
> Patches from Alejandrop Imass
>
> - Changed @FIELDS to @PROPS in Action.pm and InputField.pm for
>  mk_accesors as FIELDS was very confusing with regard to action input
>  fields.
>
> - Formalized Workflow::Acction::new() as a public method with
>  corresponding pod example.
>
> - Optional class property for Workflow::Action::InputField.
>  Previously, public method new() made little sense if InputField
>  always instantiates from Workflow::Action::InputField. Now fields
>  can derive from custom class.
>
> - Updated pod to reflect the new formal abillity to add extra
>  properties for actions and input fields.
>
> - With the ability to derive custom properties for classes and fields
>  there is little need IMHO to define InputField "type" any further
>  but leave it implementation dependent. The rationale is that
>  validators intrinsically define this. Updating pod accordingly.
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel

[Perl-workflow-devel] Changes commited for developer release 1.33_6

[Alejandro I. <ai...@p2...>]

Hi all,

I have committed my proposed changes to the branch "field_types",
corresponding to the next correlative developer release 1.33_6
(committed to svn revision 491)

These changes allow users to formally override new() in Actions and
InputFields to better adapt Workflow.p;m to their specific
implementations. My first thought at this was to extend and complete
the InputField "type" which was a work in progress according to the
pod, but later realized that this be better left implementation
dependent, and it was way more generic to formalize an extension
mechanism for actions and fields.

Here are the detailed changes:


aimass@ctlt10:~/projects/perl-workflow/branches/field_types$ svn log -v -r491
------------------------------------------------------------------------
r491 | aimass | 2009-09-26 14:05:54 -0400 (Sat, 26 Sep 2009) | 1 line
Changed paths:
   M /branches/field_types/workflow/Changes
   M /branches/field_types/workflow/lib/Workflow/Action/InputField.pm
   M /branches/field_types/workflow/lib/Workflow/Action.pm

formalization of action and input field extentions by making new()
formally public and safely overrideable; modified pod accordingly with
detailed examples
------------------------------------------------------------------------

aimass@ctlt10:~/projects/perl-workflow/branches/field_types$ cat
workflow/Changes

# $Id: Changes 491 2009-09-26 18:05:54Z aimass $

1.33_6

Patches from Alejandrop Imass

- Changed @FIELDS to @PROPS in Action.pm and InputField.pm for
  mk_accesors as FIELDS was very confusing with regard to action input
  fields.

- Formalized Workflow::Acction::new() as a public method with
  corresponding pod example.

- Optional class property for Workflow::Action::InputField.
  Previously, public method new() made little sense if InputField
  always instantiates from Workflow::Action::InputField. Now fields
  can derive from custom class.

- Updated pod to reflect the new formal abillity to add extra
  properties for actions and input fields.

- With the ability to derive custom properties for classes and fields
  there is little need IMHO to define InputField "type" any further
  but leave it implementation dependent. The rationale is that
  validators intrinsically define this. Updating pod accordingly.

[Perl-workflow-devel] Fwd: Merges on the road to 1.33

[Alejandro I. <ai...@p2...>]

Sorry, replied to Jonas only:


---------- Forwarded message ----------
From: Alejandro Imass <ai...@p2...>
Date: Fri, Sep 25, 2009 at 5:59 PM
Subject: Re: [Perl-workflow-devel] Merges on the road to 1.33
To: Jonas Brømsø Nielsen <jo...@gm...>


Hi Jonas.

I created the field_types branch from trunk a few minutes ago. I will
let you know when these changes are ready to test and merge.

Best,
Alejandro Imass




On Thu, Sep 24, 2009 at 4:34 PM, Jonas Brømsø Nielsen <jo...@gm...> wrote:
> Hello All,
>
> I have merged all branches into trunk apart from one (http://perl-workflow.svn.sourceforge.net/viewvc/perl-workflow/branches/action_group_patch/
> ), which has failing tests - I will look into these in the near future.
>
> I cannot remember if I ever mentioned our commit RSS feed, available
> at: http://rss.gmane.org/messages/excerpts/gmane.comp.lang.perl.modules.workflow.scm
>  you can always follow one is going on a lower level.
>
> I wrote a blog entry about branching strategies and developer releases
> to CPAN if anybody are interested, it uses Workflow as an example:
>
> http://jonasbn.livejournal.com/11978.html
>
> Comments are welcome and we can of course continue a possible
> discussion here.
>
> Anyway 1.33 is well underway, I expect to fix the failing tests and
> release the (hopefully) last developer release (1.33_6) before
> releasing 1.33 sometime next week.
>
> jonasbn
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
>

[Perl-workflow-devel] Merges on the road to 1.33

[Jonas B. N. <jo...@gm...>]

Hello All,

I have merged all branches into trunk apart from one (http://perl-workflow.svn.sourceforge.net/viewvc/perl-workflow/branches/action_group_patch/ 
), which has failing tests - I will look into these in the near future.

I cannot remember if I ever mentioned our commit RSS feed, available  
at: http://rss.gmane.org/messages/excerpts/gmane.comp.lang.perl.modules.workflow.scm 
  you can always follow one is going on a lower level.

I wrote a blog entry about branching strategies and developer releases  
to CPAN if anybody are interested, it uses Workflow as an example:

http://jonasbn.livejournal.com/11978.html

Comments are welcome and we can of course continue a possible  
discussion here.

Anyway 1.33 is well underway, I expect to fix the failing tests and  
release the (hopefully) last developer release (1.33_6) before  
releasing 1.33 sometime next week.

jonasbn

[Perl-workflow-devel] Hack: Adding State Properties to Actions

[Alejandro I. <ai...@ya...>]

After some serious headbanging here is a recipe that may be useful for others...

(Any comments or better ways to doing this welcome!)

Suppose you want some extra properties to your actions depending on state.
For example, you would like to display the actions in a specific order
in a particular state and/or you may want to associate an icon and
other accessors depending on state.

The most maintainable way of doing this is adding the new properties
in the XML like so:

  <!-- INITIAL State -->
  <state name="INITIAL">
    <description>
      OEM Management Start
    </description>
    <action index="0" icon="list_icon" name="OEM Browse"
resulting_state="OEM_BROWSE">
      <condition name="roleis_oem_mgmt"/>
    </action>
    <action index="1" icon="add_icon_med" name="OEM Create"
resulting_state="OEM_CREATE">
      <condition name="roleis_oem_mgmt"/>
    </action>
    <action index="2" icon="back_icon_med" name="Back"
resulting_state="CLOSED"/>
  </state>

As can be seen in the example, there are some new xml properties such
as index and icon.
The XML parser will pick these up and they will be available from the
wf's state configuration.
So if you make all your Action classes derive from a base class of your own:

package your::base::class;

use warnings;
use strict;

use base qw( Workflow::Action );
use Workflow::Exception qw( workflow_error );

# extra action class properties
my @EXTRA_FIELDS = qw( index icon type data );
__PACKAGE__->mk_accessors(@EXTRA_FIELDS);

#FRAGILE: overriding private method
sub new {
  my $class = shift;
  my $wf = shift;
  my $self = $class->SUPER::new($wf, @_);

  #FRAGILE: overriding private method and properties
  my $wf_state = $wf->_get_workflow_state;
  my $action = $wf_state->{_actions}->{$self->name};
  $self->index($action->{index});
  $self->icon($action->{icon});
  $self->type($action->{type});
  $self->data($action->{data});

  return $self;
}

1;

Then you can just implement your Action classes as usual but deriving
from this hacked base class:

package actual::action::class;

use warnings;
use strict;

use base qw( your::base::class );
use Workflow::Exception qw( workflow_error );

sub execute {
   ...
}

1;

This hack takes advantage of the fact that the parsing will pick-up
these extra xml parameters and available as config in the
initialization code.

Best,
Alejandro Imass

Re: [Perl-workflow-devel] [solved] Re: Bug found in Workflow::Action::init

[Jonas B. N. <jo...@gm...>]

Hi Alejandro,

Sorry for not responding, I have flagged your mail for follow-up, but  
never really got around to it.

Please keep using the list, I am at least reading everything :-)

jonasbn

On 21/09/2009, at 21.14, Alejandro Imass wrote:

> Ok, my bad, sorry folks.
>
> I was overriding init() but did not realize it was later called by
> Base::new(), so I was calling it twice and with the wrong params.
> Oops.
>
> I am now overriding new() and everything seems to be working fine.
>
> BTW, seems like I'm talking to myself here but what the heck, better
> to resolve the thread for future reference....
>
> Thanks,
> Alejandro Imass
>
> On Sun, Sep 20, 2009 at 11:07 AM, Alejandro Imass <ai...@p2...>  
> wrote:
>> I can almost confirm there is a bug in Workflow::Action::init
>>
>> Workflow::Action::init currently reads:
>>
>> sub init {
>>   my ( $self, $wf, $params ) = @_;
>>
>> When in fact, I think it should read:
>>
>> sub init {
>>   my ( $self, $params ) = @_;
>>
>> Just like the init() in Condition, State, Validator and so on.
>>
>> In fact Base::new() calls $self->init(@params); sow where the heck is
>> $wf supposed to come from?
>> If all this is true, then it's a fact that the Action accessors are
>> currently broken and $self->param() of Action is being clobbered by
>> the wrong object properties.
>>
>> Can _anyone_ , _please_, _pretty pleae_ confirm this?
>> I have sent 3 mails regarding this issue and it's hard to believe I'm
>> the only one that has problems using the Action accessors!!!
>>
>> Thanks,
>> Alejandro Imass
>>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9&#45;12, 2009. Register  
> now&#33;
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel

[Perl-workflow-devel] [solved] Re: Bug found in Workflow::Action::init

[Alejandro I. <ai...@p2...>]

Ok, my bad, sorry folks.

I was overriding init() but did not realize it was later called by
Base::new(), so I was calling it twice and with the wrong params.
Oops.

I am now overriding new() and everything seems to be working fine.

BTW, seems like I'm talking to myself here but what the heck, better
to resolve the thread for future reference....

Thanks,
Alejandro Imass

On Sun, Sep 20, 2009 at 11:07 AM, Alejandro Imass <ai...@p2...> wrote:
> I can almost confirm there is a bug in Workflow::Action::init
>
> Workflow::Action::init currently reads:
>
> sub init {
>   my ( $self, $wf, $params ) = @_;
>
> When in fact, I think it should read:
>
> sub init {
>   my ( $self, $params ) = @_;
>
> Just like the init() in Condition, State, Validator and so on.
>
> In fact Base::new() calls $self->init(@params); sow where the heck is
> $wf supposed to come from?
> If all this is true, then it's a fact that the Action accessors are
> currently broken and $self->param() of Action is being clobbered by
> the wrong object properties.
>
> Can _anyone_ , _please_, _pretty pleae_ confirm this?
> I have sent 3 mails regarding this issue and it's hard to believe I'm
> the only one that has problems using the Action accessors!!!
>
> Thanks,
> Alejandro Imass
>

[Perl-workflow-devel] Bug found in Workflow::Action::init

[Alejandro I. <ai...@p2...>]

I can almost confirm there is a bug in Workflow::Action::init

Workflow::Action::init currently reads:

sub init {
   my ( $self, $wf, $params ) = @_;

When in fact, I think it should read:

sub init {
   my ( $self, $params ) = @_;

Just like the init() in Condition, State, Validator and so on.

In fact Base::new() calls $self->init(@params); sow where the heck is
$wf supposed to come from?
If all this is true, then it's a fact that the Action accessors are
currently broken and $self->param() of Action is being clobbered by
the wrong object properties.

Can _anyone_ , _please_, _pretty pleae_ confirm this?
I have sent 3 mails regarding this issue and it's hard to believe I'm
the only one that has problems using the Action accessors!!!

Thanks,
Alejandro Imass

[Perl-workflow-devel] Bug found in Workflow::Action::init

[Alejandro I. <ai...@ya...>]

I can almost confirm there is a bug in Workflow::Action::init

Workflow::Action::init currently reads:

sub init {
    my ( $self, $wf, $params ) = @_;

When in fact, I think it should read:

sub init {
    my ( $self, $params ) = @_;

Just like the init() in Condition, State, Validator and so on.

In fact Base::new() calls $self->init(@params); sow where the heck is
$wf supposed to come from?
If all this is true, then it's a fact that the Action accessors are
currently broken and $self->param() of Action is being clobbered by
the wrong object properties.

Can _anyone_ , _please_, _pretty pleae_ confirm this?
I have sent 3 mails regarding this issue and it's hard to believe I'm
the only one that has problems using the Action accessors!!!

Thanks,
Alejandro Imass

Re: [Perl-workflow-devel] Action Input Field Types and Other Enhancements

[Alejandro I. <ai...@p2...>]

I checked out the complete svn tree and tried the trunk, just to make
sure it was consistent.

I'm trying to figure out the best way to propose easy extensions to
Action attributes and I still can't get past

Workflow::Action::init

Are the accessors broken on purpose? I mean are the accessors broken
legacy code or what?

Also, is there any actual interest on completing action field types?

Thanks,
Alejandro Imass



On Tue, Sep 15, 2009 at 11:32 AM, Alejandro Imass <ai...@p2...> wrote:
> Hi all,
>
> Thanks Jonas for pointing out the mailing list, and thanks to all for
> such wonderful work, started out by Chris Winters and continued with
> the current maintainer(s).
>
> I have been fiddling with Workflow.pm for a while now for the p2ee
> project, and now have the need to complete and figure out some stuff
> to discuss here.
>
> First, I would like to know the status of "Action Field Types" and if
> no one is working on this, would like to volunteer to do some work on
> it.
>
> Second, and it's kind-a in-line with the above, there should be an
> easy way to extend the attributes of any of the elements, starting
> with Actions. For example, it should be easy to add new parameters to
> the XML action tag both at the Workflow and the Action levels, and the
> should be automatically added to the object and accessors added to
> fiddle with them.
>
> When starting to figure this out I noticed that
> Workflow::Action::init() is not really doing anything but clobbering
> $self->param, because the $params received is not what is expected for
> things like $copy_params{class} to work. It seems that $params is
> getting the _workflow object_ instead of a filtered Action of it's
> type, So the accesors $self->name, class and such never have the
> actual values. Here is the code I am referring to. If you dump $params
> here you will see what I mean. Everything still works because the
> public functions don't seem to use the acessors but rather scan the
> wf_state in many cases.
>
> ########################################
> # PRIVATE
>
> sub init {
>   my ( $self, $wf, $params ) = @_;
>
>   # So we don't destroy the original...
>   my %copy_params = %{$params};
>
>   $self->class( $copy_params{class} );
>   $self->name( $copy_params{name} );
>   $self->description( $copy_params{description} );
>
>
> Thanks beforehand, and sorry for the long first post.
>
> Alejandro Imass
>

[Perl-workflow-devel] Status on 1.33 road map

[Jonas B. N. <jo...@gm...>]

Hello All,

I am boxing the last branch, focussed on a patch from Ivan Popanov. I  
currently have some tests, which are not passing, I just have to get  
my head around the problem, that is what happens if you let things lay  
around for too long.

I guess release early, release often is a good idea.

So hopefully we can get some closure on release 1.33 within a not too  
distant future...

Well ideas and patches are as always welcome,

jonasbn

[Perl-workflow-devel] Release 1.33_5, patch from Thomas Erskine

[Jonas B. N. <jo...@gm...>]

Here follows the next developer release: 1.33_5

It is holding a patch from Thomas Erskine (thanks Thomas).

 From the Changes file:

- Added 3 new accessors:

	- get_persister_for_workflow_type
	- get_persisters
	- get_validators

- Added check for existing context so context is not overwritten if  
existing,
   fixing a bug

As for this release, discussion, POD, tests more than welcome...

The release is available in Subversion and on your local CPAN mirrors  
eventually,

jonasbn

[Perl-workflow-devel] Release 1.33_4, patch from Danny Sadinoff

[Jonas B. N. <jo...@gm...>]

Hello,

Sorry for the long period of silence, summer holiday and job change  
has occupied me quite a lot.

Anyway, I have received a lot of patches before the summer holiday, so  
this is the first in a series of rapid development releases  
implementing these patches and hopefully getting us closer to 1.33.

The release are based on trunk and does not include each other, if you  
want me do go about this differently please let me know, I am not sure  
what is the recommended  best practice for this. The release is  
actually just made to draw a line in the sand and to put it out there  
for you to evaluate.

This release is based on a patch from Danny Sadinoff, thanks Danny:

 From the Changes file:

	- Adding ability to control initial state name via workflow config
	- Adding ability to control initial history record details via  
Persister subclass code

Additional patches, POD, tests more that welcome and of course we can  
debate the patch here and whether it should go in trunk.

The release is available in Subversion and on your local CPAN mirrors  
eventually,

Thanks for your patience,

jonasbn

[Perl-workflow-devel] Action Input Field Types and Other Enhancements

[Alejandro I. <ai...@p2...>]

Hi all,

Thanks Jonas for pointing out the mailing list, and thanks to all for
such wonderful work, started out by Chris Winters and continued with
the current maintainer(s).

I have been fiddling with Workflow.pm for a while now for the p2ee
project, and now have the need to complete and figure out some stuff
to discuss here.

First, I would like to know the status of "Action Field Types" and if
no one is working on this, would like to volunteer to do some work on
it.

Second, and it's kind-a in-line with the above, there should be an
easy way to extend the attributes of any of the elements, starting
with Actions. For example, it should be easy to add new parameters to
the XML action tag both at the Workflow and the Action levels, and the
should be automatically added to the object and accessors added to
fiddle with them.

When starting to figure this out I noticed that
Workflow::Action::init() is not really doing anything but clobbering
$self->param, because the $params received is not what is expected for
things like $copy_params{class} to work. It seems that $params is
getting the _workflow object_ instead of a filtered Action of it's
type, So the accesors $self->name, class and such never have the
actual values. Here is the code I am referring to. If you dump $params
here you will see what I mean. Everything still works because the
public functions don't seem to use the acessors but rather scan the
wf_state in many cases.

########################################
# PRIVATE

sub init {
   my ( $self, $wf, $params ) = @_;

   # So we don't destroy the original...
   my %copy_params = %{$params};

   $self->class( $copy_params{class} );
   $self->name( $copy_params{name} );
   $self->description( $copy_params{description} );


Thanks beforehand, and sorry for the long first post.

Alejandro Imass