Re: [Perl-workflow-devel] Actions by type feature

[Jim B. <cb...@bu...>]

Alexander Klink wrote:
> Hi Jim,
> 
> On Thu, Dec 13, 2007 at 09:52:09AM -0500, Jim Brandt wrote:
>> I've got a working version of workflow that allows you to have typed 
>> actions in this branch:
>>
>> http://perl-workflow.svn.sourceforge.net/viewvc/perl-workflow/branches/config_types/
> Well, thanks from me to for now. Unfortunately, I guess I won't have
> the time to look at it today - so it will have to wait until next year
> :-/ But I'll definitely have a look at it then, being the one who
> requested the feature in the first place ;-)
> 

We needed it too, so I was helping myself as well. :)

>> * I only put the fix in for the XML configuration. Should I go ahead and 
>> do the same for the Perl config?
> I'd say yes, we should keep it consistent.

Yeah, that's what I figured, but I wasn't sure if anyone was using the 
Perl config.

> 
>> * Has anyone written their own custom config? I'm not sure if these 
>> changes will work seamlessly with custom sub-classed configuration methods.
> Is that even possible? I'd guess it suffers from the same sub-classing
> problems that are all over the place.

I doubt it, but maybe we should add a bit warning in the Changes that 
these change might break a sub-classed config if you had one.

> 
>> * Would anyone want this same functionality for conditions or validators?
> I guess it'd be useful for conditions for us, we don't have too many
> validators. All in all, I'd say it would probably be useful and most
> consistent if it was present for all types.

Yep, I agree here too. I'll take a look at these. I think the changes 
will be similar. The tough part is coming up with all the new tests.

> 
> Merry christmas and a happy new year :-)
>     Alex

Indeed, happy holidays to all! :)

Jim


-- 
Jim Brandt
Administrative Computing Services
University at Buffalo