Re: [Perl-workflow-devel] Making activity configs local to workflow/state?

[jonasbn <jo...@gm...>]

Hi Alex,

The readibility of the XML files are not that good anyway, I am not =20
saying we should not attempt to improve this, but your suggestions are =20=

valid in my eyes.

jonasbn
--
AIM: BjonasN      Gtalk: jo...@gm...
ICQ: 62401545   MSN: jo...@io...


On 27/11/2007, at 11.24, Alexander Klink wrote:

> Hi Jonas,
>
> On Tue, Nov 27, 2007 at 09:47:58AM +0100, jonasbn wrote:
>> I understand and acknowledge the problem and I think it can be fixed.
> Fine :-)
>
>> But I am concerned about backwards compatibility.
>>
>> So perhaps the Workflow configuration should support local and global
>> activities?
>>
>> What do you think?
> Sounds reasonable. Maybe we can do inline configuration of action
> and conditions (I'd assume they have the same problem?) as the
> local method, which would leave it backwards compatible to the old
> version. Example:
>
> Old (still valid):
>  <state name=3D"CREATED" autorun=3D"yes">
>    <action name=3D"null"
>            resulting_state=3D"SERVER_KEY_GENERATION">
>        <condition name=3D"server_key_generation"/>
>    </action>
>
>    <action name=3D"notify_user_of_creation"
>            resulting_state=3D"PENDING">
>        <condition name=3D"!server_key_generation"/>
>    </action>
>  </state>
>
> New:
>  <state name=3D"CREATED" autorun=3D"yes">
>    <action name=3D"null"
>            resulting_state=3D"SERVER_KEY_GENERATION"
>            class=3D"Workflow::Action::Null">
>        <condition name=3D"server_key_generation"
>                   =20
> class=3D"OpenXPKI::Server::Workflow::Condition::IsServerKeyGeneration"/>=

>    </action>
>
>    <action name=3D"notify_user_of_creation"
>            resulting_state=3D"PENDING"
>            =20
> class=3D"OpenXPKI::Server::Workflow::Activity::Tools::Notification"
>            message=3D"csr_created">
>        <condition name=3D"!server_key_generation"/>
>    </action>
>  </state>
>
> Hmmm, on second thought, this does not really increase the readability
> of the config file - anyone with a better idea?
>
> Best regards,
>  Alex
> --=20
> Dipl.-Math. Alexander Klink | IT-Security Engineer |    =
a....@cy...
> mobile: +49 (0)178 2121703 |          Cynops GmbH | =
http://www.cynops.de
> ----------------------------+----------------------=20
> +---------------------
>      HRB 7833, Amtsgericht | USt-Id: DE 213094986 |     =20
> Gesch=E4ftsf=FChrer:
>     Bad Homburg v. d. H=F6he |                      |      Martin =20
> Bartosch