Re: [Perl-workflow-devel] Making activity configs local to workflow/state?

[Alexander K. <a....@cy...>]

Hi Jonas,

On Tue, Nov 27, 2007 at 09:47:58AM +0100, jonasbn wrote:
> I understand and acknowledge the problem and I think it can be fixed.  
Fine :-)

> But I am concerned about backwards compatibility.
> 
> So perhaps the Workflow configuration should support local and global  
> activities?
> 
> What do you think?
Sounds reasonable. Maybe we can do inline configuration of action
and conditions (I'd assume they have the same problem?) as the
local method, which would leave it backwards compatible to the old
version. Example:

Old (still valid):
  <state name="CREATED" autorun="yes">
    <action name="null"
            resulting_state="SERVER_KEY_GENERATION">
        <condition name="server_key_generation"/>
    </action>

    <action name="notify_user_of_creation"
            resulting_state="PENDING">
        <condition name="!server_key_generation"/>
    </action>
  </state>

New:
  <state name="CREATED" autorun="yes">
    <action name="null"
            resulting_state="SERVER_KEY_GENERATION"
            class="Workflow::Action::Null">
        <condition name="server_key_generation"
                   class="OpenXPKI::Server::Workflow::Condition::IsServerKeyGeneration"/>
    </action>

    <action name="notify_user_of_creation"
            resulting_state="PENDING"
            class="OpenXPKI::Server::Workflow::Activity::Tools::Notification"
            message="csr_created">
        <condition name="!server_key_generation"/>
    </action>
  </state>

Hmmm, on second thought, this does not really increase the readability
of the config file - anyone with a better idea?

Best regards,
  Alex
-- 
Dipl.-Math. Alexander Klink | IT-Security Engineer |    a....@cy...
 mobile: +49 (0)178 2121703 |          Cynops GmbH | http://www.cynops.de
----------------------------+----------------------+---------------------
      HRB 7833, Amtsgericht | USt-Id: DE 213094986 |     Geschäftsführer:
     Bad Homburg v. d. Höhe |                      |      Martin Bartosch